fix!(policy/checker): make List and-like

This has the potential to break user configs.

Anubis lets you stack multiple checks at once with blocks like this:

```yaml
name: allow-prometheus
action: ALLOW
user_agent_regex: ^prometheus-probe$
remote_addresses:
  - 192.168.2.0/24
```

Previously, this only returned ALLOW if _any one_ of the conditions
matched. This behaviour has changed to only return ALLOW if _all_ of the
conditions match.

I have marked this as a potentially breaking change because I'm
absolutely certain that someone is relying on this behaviour due to
spacebar heating. If this bites you, please let me know ASAP.

Signed-off-by: Xe Iaso <me@xeiaso.net>
Assisted-by: GPT-OSS 120b on local hardware
This commit is contained in:
Xe Iaso
2025-10-25 00:58:06 +00:00
parent d7459de941
commit b291170cb6
3 changed files with 86 additions and 5 deletions

View File

@@ -16,18 +16,26 @@ type Impl interface {
type List []Impl
// Check runs each checker in the list against the request.
// It returns true only if *all* checkers return true (AND semantics).
// If any checker returns an error, the function returns false and the error.
func (l List) Check(r *http.Request) (bool, error) {
// Assume success until a checker says otherwise.
allOk := true
for _, c := range l {
ok, err := c.Check(r)
if err != nil {
return ok, err
// Propagate the error; overall result is false.
return false, err
}
if ok {
return ok, nil
if !ok {
// One false means the combined result is false. Short-circuit
// so we don't waste time.
allOk = false
break
}
}
return false, nil
return allOk, nil
}
func (l List) Hash() string {