Add "real" TopSongs

core/lastfm/client_test.go

@@ -98,7 +98,45 @@ var _ = Describe("Client", func() {
 			_, err := client.ArtistGetSimilar(context.TODO(), "U2", 2)
 			Expect(err).To(MatchError("invalid character '<' looking for beginning of value"))
 		})
+	})
 
+	Describe("ArtistGetTopTracks", func() {
+		It("returns top tracks for a successful response", func() {
+			f, _ := os.Open("tests/fixtures/lastfm.artist.gettoptracks.json")
+			httpClient.res = http.Response{Body: f, StatusCode: 200}
+
+			tracks, err := client.ArtistGetTopTracks(context.TODO(), "U2", 2)
+			Expect(err).To(BeNil())
+			Expect(len(tracks)).To(Equal(2))
+			Expect(httpClient.savedRequest.URL.String()).To(Equal(apiBaseUrl + "?api_key=API_KEY&artist=U2&format=json&limit=2&method=artist.getTopTracks"))
+		})
+
+		It("fails if Last.FM returns an error", func() {
+			httpClient.res = http.Response{
+				Body:       ioutil.NopCloser(bytes.NewBufferString(`{"error":3,"message":"Invalid Method - No method with that name in this package"}`)),
+				StatusCode: 400,
+			}
+
+			_, err := client.ArtistGetTopTracks(context.TODO(), "U2", 2)
+			Expect(err).To(MatchError("last.fm error(3): Invalid Method - No method with that name in this package"))
+		})
+
+		It("fails if HttpClient.Do() returns error", func() {
+			httpClient.err = errors.New("generic error")
+
+			_, err := client.ArtistGetTopTracks(context.TODO(), "U2", 2)
+			Expect(err).To(MatchError("generic error"))
+		})
+
+		It("fails if returned body is not a valid JSON", func() {
+			httpClient.res = http.Response{
+				Body:       ioutil.NopCloser(bytes.NewBufferString(`<xml>NOT_VALID_JSON</xml>`)),
+				StatusCode: 200,
+			}
+
+			_, err := client.ArtistGetTopTracks(context.TODO(), "U2", 2)
+			Expect(err).To(MatchError("invalid character '<' looking for beginning of value"))
+		})
 	})
 })