arian/navidrome
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Recover from SIGSEGVs in taglib's code

Browse Source
This commit is contained in:
Deluan
2021-11-20 12:33:06 -05:00
parent cbeaadf8e2
commit 0714f08274
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scanner/metadata/taglib/taglib_wrapper.go
+4
View File
@@ -12,6 +12,7 @@ package taglib
import "C" import "C"
import ( import (
"fmt" "fmt"
"runtime/debug"
"strconv" "strconv"
"strings" "strings"
"sync" "sync"
@@ -21,12 +22,15 @@ import (
) )
func Read(filename string) (tags map[string][]string, err error) { func Read(filename string) (tags map[string][]string, err error) {
// Do not crash on failures in the C code/library
debug.SetPanicOnFault(true)
defer func() { defer func() {
if r := recover(); r != nil { if r := recover(); r != nil {
log.Error("TagLib: recovered from panic when reading tags", "file", filename, "error", r) log.Error("TagLib: recovered from panic when reading tags", "file", filename, "error", r)
err = fmt.Errorf("TagLib: recovered from panic: %s", r) err = fmt.Errorf("TagLib: recovered from panic: %s", r)
} }
}() }()
fp := getFilename(filename) fp := getFilename(filename)
defer C.free(unsafe.Pointer(fp)) defer C.free(unsafe.Pointer(fp))
id, m := newMap() id, m := newMap()