Don't try to downsample if requested bitrate is equal or greater than original. Fix #2066

core/media_streamer_Internal_test.go

@@ -75,14 +75,23 @@ var _ = Describe("MediaStreamer", func() {
 				Expect(format).To(Equal("raw"))
 				Expect(bitRate).To(Equal(320))
 			})
-			It("returns the DefaultDownsamplingFormat if a maxBitrate but not the format", func() {
-				conf.Server.DefaultDownsamplingFormat = "opus"
-				mf.Suffix = "FLAC"
-				mf.BitRate = 960
-				format, bitRate := selectTranscodingOptions(ctx, ds, mf, "", 128)
-				Expect(format).To(Equal("opus"))
-				Expect(bitRate).To(Equal(128))
-
+			Context("Downsampling", func() {
+				BeforeEach(func() {
+					conf.Server.DefaultDownsamplingFormat = "opus"
+					mf.Suffix = "FLAC"
+					mf.BitRate = 960
+				})
+				It("returns the DefaultDownsamplingFormat if a maxBitrate is requested but not the format", func() {
+					format, bitRate := selectTranscodingOptions(ctx, ds, mf, "", 128)
+					Expect(format).To(Equal("opus"))
+					Expect(bitRate).To(Equal(128))
+				})
+				It("returns raw if maxBitrate is equal or greater than original", func() {
+					// This happens with DSub (and maybe other clients?). See https://github.com/navidrome/navidrome/issues/2066
+					format, bitRate := selectTranscodingOptions(ctx, ds, mf, "", 960)
+					Expect(format).To(Equal("raw"))
+					Expect(bitRate).To(Equal(0))
+				})
 			})
 		})