Artist page improvements (#1391)

* Seperate mobile desktop components

* Fix err

* Rename classes and fix some styles

* Add lastFM button and remove console log

* Add Mbiz Icon

* render bio as dangerouslySetInnerHTML and remove unused css classes

* Add Fav and Stars

* Remove unstandardised class selector

* Remove ext link from m view

* Fix naming and simplify rounded styling

* Refactor ArtistShow:

- Extracted DesktopArtistDetails to its own file
- Removed album count as it was incorrect, it is not considering compilations
- Show bio and image from Native API, if it is available, before calling `getArtistInfo`

Co-authored-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Dnouv
2021-10-16 06:32:11 +05:30
committed by GitHub
parent 7505b5c554
commit 1d742cf8c7
8 changed files with 343 additions and 257 deletions
+134
View File
@@ -0,0 +1,134 @@
import React, { useState } from 'react'
import { Typography, Collapse } from '@material-ui/core'
import { makeStyles } from '@material-ui/core'
import Card from '@material-ui/core/Card'
import CardContent from '@material-ui/core/CardContent'
import CardMedia from '@material-ui/core/CardMedia'
import ArtistExternalLinks from './ArtistExternalLink'
import config from '../config'
import { LoveButton, RatingField } from '../common'
const useStyles = makeStyles(
(theme) => ({
root: {
display: 'flex',
padding: '1em',
},
details: {
display: 'flex',
flex: '1',
flexDirection: 'column',
},
biography: {
display: 'inline-block',
marginTop: '1em',
float: 'left',
wordBreak: 'break-word',
cursor: 'pointer',
},
content: {
flex: '1 0 auto',
},
cover: {
width: 151,
borderRadius: '6em',
},
artistImage: {
maxHeight: '9.5rem',
backgroundColor: 'inherit',
display: 'flex',
boxShadow: 'none',
},
artistDetail: {
flex: '1',
padding: '3%',
display: 'flex',
minHeight: '10rem',
},
button: {
marginLeft: '0.9em',
},
loveButton: {
top: theme.spacing(-0.2),
left: theme.spacing(0.5),
},
rating: {
marginTop: '5px',
},
artistName: {
wordBreak: 'break-word',
},
}),
{ name: 'NDDesktopArtistDetails' }
)
const DesktopArtistDetails = ({ img, artistInfo, record, biography }) => {
const [expanded, setExpanded] = useState(false)
const classes = useStyles({ img, expanded })
const title = record.name
return (
<div className={classes.root}>
<Card className={classes.artistDetail}>
<Card className={classes.artistImage}>
{artistInfo && (
<CardMedia
className={classes.cover}
image={`${artistInfo.mediumImageUrl}`}
title={title}
/>
)}
</Card>
<div className={classes.details}>
<CardContent className={classes.content}>
<Typography
component="h5"
variant="h5"
className={classes.artistName}
>
{title}
{config.enableFavourites && (
<LoveButton
className={classes.loveButton}
record={record}
resource={'artist'}
size={'default'}
aria-label="love"
color="primary"
/>
)}
</Typography>
{config.enableStarRating && (
<div>
<RatingField
record={record}
resource={'artist'}
size={'small'}
className={classes.rating}
/>
</div>
)}
<Collapse
collapsedHeight={'4.5em'}
in={expanded}
timeout={'auto'}
className={classes.biography}
>
<Typography
variant={'body1'}
onClick={() => setExpanded(!expanded)}
>
<span dangerouslySetInnerHTML={{ __html: biography }} />
</Typography>
</Collapse>
</CardContent>
<Typography component={'div'} className={classes.button}>
<ArtistExternalLinks artistInfo={artistInfo} record={record} />
</Typography>
</div>
</Card>
</div>
)
}
export default DesktopArtistDetails