From 2068e7d413c93bb679e76f8a8247dbe11423e354 Mon Sep 17 00:00:00 2001 From: Deluan Date: Tue, 3 Feb 2026 10:11:55 -0500 Subject: [PATCH] fix(plugins): don't recording metrics for not implemented plugin calls Signed-off-by: Deluan --- plugins/manager_call.go | 3 ++- plugins/manager_call_test.go | 7 ++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/manager_call.go b/plugins/manager_call.go index 834f4542..b5c7536b 100644 --- a/plugins/manager_call.go +++ b/plugins/manager_call.go @@ -73,7 +73,8 @@ func callPluginFunction[I any, O any](ctx context.Context, plugin *plugin, funcN if exit != 0 { if exit == notImplementedCode { log.Trace(ctx, "Plugin function not implemented", "plugin", plugin.name, "function", funcName, "pluginDuration", elapsed, "navidromeDuration", startCall.Sub(start)) - plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, true, elapsed.Milliseconds()) + // TODO Should we record metrics for not implemented calls? + //plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, true, elapsed.Milliseconds()) return result, fmt.Errorf("%w: %s", errNotImplemented, funcName) } plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, false, elapsed.Milliseconds()) diff --git a/plugins/manager_call_test.go b/plugins/manager_call_test.go index 32e9df99..8865e126 100644 --- a/plugins/manager_call_test.go +++ b/plugins/manager_call_test.go @@ -106,7 +106,7 @@ var _ = Describe("callPluginFunction metrics", Ordered, func() { Expect(calls[0].ok).To(BeFalse()) }) - It("records metrics for not-implemented functions", func() { + It("does not record metrics for not-implemented functions", func() { // Use partial metadata agent that doesn't implement GetArtistMBID partialRecorder := &mockMetricsRecorder{} partialManager, _ := createTestManagerWithPluginsAndMetrics( @@ -123,9 +123,6 @@ var _ = Describe("callPluginFunction metrics", Ordered, func() { Expect(err).To(MatchError(errNotImplemented)) calls := partialRecorder.getCalls() - Expect(calls).To(HaveLen(1)) - Expect(calls[0].plugin).To(Equal("partial-metadata-agent")) - Expect(calls[0].method).To(Equal(FuncGetArtistMBID)) - Expect(calls[0].ok).To(BeTrue()) + Expect(calls).To(HaveLen(0)) }) })