From 4359adc042e36096767f4336a7a237d103ad28ab Mon Sep 17 00:00:00 2001 From: Deluan Date: Mon, 16 Jun 2025 13:01:38 -0400 Subject: [PATCH] test: add coverage for missing id parameter in GetCoverArt Signed-off-by: Deluan --- server/subsonic/media_retrieval_test.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/server/subsonic/media_retrieval_test.go b/server/subsonic/media_retrieval_test.go index d80f1f9c..9b3924ad 100644 --- a/server/subsonic/media_retrieval_test.go +++ b/server/subsonic/media_retrieval_test.go @@ -45,12 +45,20 @@ var _ = Describe("MediaRetrievalController", func() { _, err := router.GetCoverArt(w, r) Expect(err).ToNot(HaveOccurred()) - Expect(artwork.recvId).To(Equal("34")) Expect(artwork.recvSize).To(Equal(128)) Expect(artwork.recvSquare).To(BeTrue()) Expect(w.Body.String()).To(Equal(artwork.data)) }) + It("should return placeholder if id parameter is missing (mimicking Subsonic)", func() { + r := newGetRequest() // No id parameter + _, err := router.GetCoverArt(w, r) + + Expect(err).To(BeNil()) + Expect(artwork.recvId).To(BeEmpty()) + Expect(w.Body.String()).To(Equal(artwork.data)) + }) + It("should fail when the file is not found", func() { artwork.err = model.ErrNotFound r := newGetRequest("id=34", "size=128", "square=true")