Artist Detail Page (first cut) (#1287)

* Configure fetching from API and route

* pretty

* Remove errors

* Remove errors

* Remove errors

* Complete page for Desktop view

* Fix error

* Add xs Artist page

* Remove unused import

* Add styles for theme

* Change route path

* Remove artId useEffect array

* Remove array

* Fix cover load err

* Add redirect on err

* Remove route

* What's in a name? consistency :)

* Fix err

* Fix UI changes

* Fetch album from resource

* Renaming done

* Review changes

* Some touch-up

* Small refactor, to make naming and structure more consistent with AlbumShow

* Make artist's album list similar to original implementation

* Reuse AlbumGridView, to avoid duplication

* Add feature flag to enable new Artist Page, default false

* Better biography styling. Small refactorings,

* Don't encode quotes and other symbols

* Moved AlbumShow to correct folder

Co-authored-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Dnouv
2021-09-27 01:02:40 +05:30
committed by GitHub
parent 210dc6b12e
commit 482c2dec0c
15 changed files with 382 additions and 7 deletions
+1 -3
View File
@@ -113,7 +113,7 @@ const Cover = withContentRect('bounds')(
}
)
const AlbumGridTile = ({ showArtist, record, basePath }) => {
const AlbumGridTile = ({ showArtist, record, basePath, ...props }) => {
const classes = useStyles()
const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md'), {
noSsr: true,
@@ -121,7 +121,6 @@ const AlbumGridTile = ({ showArtist, record, basePath }) => {
if (!record) {
return null
}
return (
<div className={classes.albumContainer}>
<Link
@@ -166,7 +165,6 @@ const LoadedAlbumGrid = ({ ids, data, basePath, width }) => {
const classes = useStyles()
const { filterValues } = useListContext()
const isArtistView = !!(filterValues && filterValues.artist_id)
return (
<div className={classes.root}>
<GridList