From 4cca7bce4e36123ca8905115ca819c048f42f500 Mon Sep 17 00:00:00 2001 From: Deluan Date: Mon, 23 Mar 2026 11:59:11 -0400 Subject: [PATCH] test: increase FlakeAttempts for library directory tests and remove flaky job test --- plugins/host_library_test.go | 4 ++-- scheduler/scheduler_test.go | 28 ---------------------------- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/plugins/host_library_test.go b/plugins/host_library_test.go index d92abfe3..5746a3be 100644 --- a/plugins/host_library_test.go +++ b/plugins/host_library_test.go @@ -544,7 +544,7 @@ var _ = Describe("LibraryService Integration", Ordered, func() { // Note: This test is slightly flaky due to a potential race condition in wazero's // WASI filesystem mounting. The test passes ~85% of the time. Using FlakeAttempts // to automatically retry on failure. - It("should read file from mounted library directory", FlakeAttempts(3), func() { + It("should read file from mounted library directory", FlakeAttempts(5), func() { ctx := GinkgoT().Context() output, err := callTestLibrary(ctx, testLibraryInput{ @@ -557,7 +557,7 @@ var _ = Describe("LibraryService Integration", Ordered, func() { }) // Note: Uses FlakeAttempts for the same reason as the read_file test above - It("should list files in mounted library directory", FlakeAttempts(3), func() { + It("should list files in mounted library directory", FlakeAttempts(5), func() { ctx := GinkgoT().Context() output, err := callTestLibrary(ctx, testLibraryInput{ diff --git a/scheduler/scheduler_test.go b/scheduler/scheduler_test.go index 795f0711..1a134a7f 100644 --- a/scheduler/scheduler_test.go +++ b/scheduler/scheduler_test.go @@ -2,7 +2,6 @@ package scheduler import ( "testing" - "time" "github.com/navidrome/navidrome/log" . "github.com/onsi/ginkgo/v2" @@ -48,31 +47,4 @@ var _ = Describe("Scheduler", func() { Expect(id).ToNot(BeZero()) s.Remove(id) }) - - It("removes a job", func() { - done := make(chan struct{}) - - counter := 0 - id, err := s.Add("@every 50ms", func() { - counter++ - if counter == 1 { - close(done) - } - }) - Expect(err).ToNot(HaveOccurred()) - Expect(id).ToNot(BeZero()) - - // Verify job executed - Eventually(done).Should(BeClosed()) - Expect(counter).To(Equal(1)) - - // Remove the job - s.Remove(id) - - // Wait some time to ensure job doesn't execute again - time.Sleep(200 * time.Millisecond) - - // Verify counter didn't increase - Expect(counter).To(Equal(1)) - }) })