refactor: external_metadata -> external.Provider (#3903)

* tests for TopSongs Signed-off-by: Deluan <deluan@navidrome.org> * convert to Ginkgo Signed-off-by: Deluan <deluan@navidrome.org> * consolidate tests Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata -wip Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata to extdata.Provider Signed-off-by: Deluan <deluan@navidrome.org> * refactor tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor test helpers Signed-off-by: Deluan <deluan@navidrome.org> * remove reflection Signed-off-by: Deluan <deluan@navidrome.org> * use mock.Mock Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix Signed-off-by: Deluan <deluan@navidrome.org> * receive Agents interface in Provider constructor Signed-off-by: Deluan <deluan@navidrome.org> * use mock for Agents Signed-off-by: Deluan <deluan@navidrome.org> * tests for SimilarSongs Signed-off-by: Deluan <deluan@navidrome.org> * remove duplication Signed-off-by: Deluan <deluan@navidrome.org> * ArtistImage tests Signed-off-by: Deluan <deluan@navidrome.org> * AlbumImage tests Signed-off-by: Deluan <deluan@navidrome.org> * fix provider error handling Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * UpdateArtistInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * clean up Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix test descriptions Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor: rename extdata package to external Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
2025-04-08 21:11:09 -04:00
parent 6b59f5f73a
commit 58367afaea
26 changed files with 1959 additions and 209 deletions
@@ -10,56 +10,56 @@ import (

 func CreateMockAlbumRepo() *MockAlbumRepo {
 	return &MockAlbumRepo{
-		data: make(map[string]*model.Album),
+		Data: make(map[string]*model.Album),
 	}
 }

 type MockAlbumRepo struct {
 	model.AlbumRepository
-	data    map[string]*model.Album
-	all     model.Albums
-	err     bool
+	Data    map[string]*model.Album
+	All     model.Albums
+	Err     bool
 	Options model.QueryOptions
 }

 func (m *MockAlbumRepo) SetError(err bool) {
-	m.err = err
+	m.Err = err
 }

 func (m *MockAlbumRepo) SetData(albums model.Albums) {
-	m.data = make(map[string]*model.Album, len(albums))
-	m.all = albums
-	for i, a := range m.all {
-		m.data[a.ID] = &m.all[i]
+	m.Data = make(map[string]*model.Album, len(albums))
+	m.All = albums
+	for i, a := range m.All {
+		m.Data[a.ID] = &m.All[i]
 	}
 }

 func (m *MockAlbumRepo) Exists(id string) (bool, error) {
-	if m.err {
+	if m.Err {
 		return false, errors.New("unexpected error")
 	}
-	_, found := m.data[id]
+	_, found := m.Data[id]
 	return found, nil
 }

 func (m *MockAlbumRepo) Get(id string) (*model.Album, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("unexpected error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		return d, nil
 	}
 	return nil, model.ErrNotFound
 }

 func (m *MockAlbumRepo) Put(al *model.Album) error {
-	if m.err {
+	if m.Err {
 		return errors.New("unexpected error")
 	}
 	if al.ID == "" {
 		al.ID = id.NewRandom()
 	}
-	m.data[al.ID] = al
+	m.Data[al.ID] = al
 	return nil
 }

@@ -67,17 +67,17 @@ func (m *MockAlbumRepo) GetAll(qo ...model.QueryOptions) (model.Albums, error) {
 	if len(qo) > 0 {
 		m.Options = qo[0]
 	}
-	if m.err {
+	if m.Err {
 		return nil, errors.New("unexpected error")
 	}
-	return m.all, nil
+	return m.All, nil
 }

 func (m *MockAlbumRepo) IncPlayCount(id string, timestamp time.Time) error {
-	if m.err {
+	if m.Err {
 		return errors.New("unexpected error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		d.PlayCount++
 		d.PlayDate = &timestamp
 		return nil
@@ -85,15 +85,15 @@ func (m *MockAlbumRepo) IncPlayCount(id string, timestamp time.Time) error {
 	return model.ErrNotFound
 }
 func (m *MockAlbumRepo) CountAll(...model.QueryOptions) (int64, error) {
-	return int64(len(m.all)), nil
+	return int64(len(m.All)), nil
 }

 func (m *MockAlbumRepo) GetTouchedAlbums(libID int) (model.AlbumCursor, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("unexpected error")
 	}
 	return func(yield func(model.Album, error) bool) {
-		for _, a := range m.data {
+		for _, a := range m.Data {
 			if a.ID == "error" {
 				if !yield(*a, errors.New("error")) {
 					break
@@ -110,4 +110,11 @@ func (m *MockAlbumRepo) GetTouchedAlbums(libID int) (model.AlbumCursor, error) {
 	}, nil
 }

+func (m *MockAlbumRepo) UpdateExternalInfo(album *model.Album) error {
+	if m.Err {
+		return errors.New("unexpected error")
+	}
+	return nil
+}
+
 var _ model.AlbumRepository = (*MockAlbumRepo)(nil)