refactor: external_metadata -> external.Provider (#3903)

* tests for TopSongs Signed-off-by: Deluan <deluan@navidrome.org> * convert to Ginkgo Signed-off-by: Deluan <deluan@navidrome.org> * consolidate tests Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata -wip Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata to extdata.Provider Signed-off-by: Deluan <deluan@navidrome.org> * refactor tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor test helpers Signed-off-by: Deluan <deluan@navidrome.org> * remove reflection Signed-off-by: Deluan <deluan@navidrome.org> * use mock.Mock Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix Signed-off-by: Deluan <deluan@navidrome.org> * receive Agents interface in Provider constructor Signed-off-by: Deluan <deluan@navidrome.org> * use mock for Agents Signed-off-by: Deluan <deluan@navidrome.org> * tests for SimilarSongs Signed-off-by: Deluan <deluan@navidrome.org> * remove duplication Signed-off-by: Deluan <deluan@navidrome.org> * ArtistImage tests Signed-off-by: Deluan <deluan@navidrome.org> * AlbumImage tests Signed-off-by: Deluan <deluan@navidrome.org> * fix provider error handling Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * UpdateArtistInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * clean up Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix test descriptions Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor: rename extdata package to external Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
2025-04-08 21:11:09 -04:00
parent 6b59f5f73a
commit 58367afaea
26 changed files with 1959 additions and 209 deletions
@@ -10,61 +10,61 @@ import (

 func CreateMockArtistRepo() *MockArtistRepo {
 	return &MockArtistRepo{
-		data: make(map[string]*model.Artist),
+		Data: make(map[string]*model.Artist),
 	}
 }

 type MockArtistRepo struct {
 	model.ArtistRepository
-	data map[string]*model.Artist
-	err  bool
+	Data map[string]*model.Artist
+	Err  bool
 }

 func (m *MockArtistRepo) SetError(err bool) {
-	m.err = err
+	m.Err = err
 }

 func (m *MockArtistRepo) SetData(artists model.Artists) {
-	m.data = make(map[string]*model.Artist)
+	m.Data = make(map[string]*model.Artist)
 	for i, a := range artists {
-		m.data[a.ID] = &artists[i]
+		m.Data[a.ID] = &artists[i]
 	}
 }

 func (m *MockArtistRepo) Exists(id string) (bool, error) {
-	if m.err {
+	if m.Err {
 		return false, errors.New("Error!")
 	}
-	_, found := m.data[id]
+	_, found := m.Data[id]
 	return found, nil
 }

 func (m *MockArtistRepo) Get(id string) (*model.Artist, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("Error!")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		return d, nil
 	}
 	return nil, model.ErrNotFound
 }

 func (m *MockArtistRepo) Put(ar *model.Artist, columsToUpdate ...string) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
 	if ar.ID == "" {
 		ar.ID = id.NewRandom()
 	}
-	m.data[ar.ID] = ar
+	m.Data[ar.ID] = ar
 	return nil
 }

 func (m *MockArtistRepo) IncPlayCount(id string, timestamp time.Time) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		d.PlayCount++
 		d.PlayDate = &timestamp
 		return nil
@@ -72,4 +72,26 @@ func (m *MockArtistRepo) IncPlayCount(id string, timestamp time.Time) error {
 	return model.ErrNotFound
 }

+func (m *MockArtistRepo) GetAll(options ...model.QueryOptions) (model.Artists, error) {
+	if m.Err {
+		return nil, errors.New("mock repo error")
+	}
+	var allArtists model.Artists
+	for _, artist := range m.Data {
+		allArtists = append(allArtists, *artist)
+	}
+	// Apply Max=1 if present (simple simulation for findArtistByName)
+	if len(options) > 0 && options[0].Max == 1 && len(allArtists) > 0 {
+		return allArtists[:1], nil
+	}
+	return allArtists, nil
+}
+
+func (m *MockArtistRepo) UpdateExternalInfo(artist *model.Artist) error {
+	if m.Err {
+		return errors.New("mock repo error")
+	}
+	return nil
+}
+
 var _ model.ArtistRepository = (*MockArtistRepo)(nil)