refactor: external_metadata -> external.Provider (#3903)

* tests for TopSongs Signed-off-by: Deluan <deluan@navidrome.org> * convert to Ginkgo Signed-off-by: Deluan <deluan@navidrome.org> * consolidate tests Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata -wip Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata to extdata.Provider Signed-off-by: Deluan <deluan@navidrome.org> * refactor tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor test helpers Signed-off-by: Deluan <deluan@navidrome.org> * remove reflection Signed-off-by: Deluan <deluan@navidrome.org> * use mock.Mock Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix Signed-off-by: Deluan <deluan@navidrome.org> * receive Agents interface in Provider constructor Signed-off-by: Deluan <deluan@navidrome.org> * use mock for Agents Signed-off-by: Deluan <deluan@navidrome.org> * tests for SimilarSongs Signed-off-by: Deluan <deluan@navidrome.org> * remove duplication Signed-off-by: Deluan <deluan@navidrome.org> * ArtistImage tests Signed-off-by: Deluan <deluan@navidrome.org> * AlbumImage tests Signed-off-by: Deluan <deluan@navidrome.org> * fix provider error handling Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * UpdateArtistInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * clean up Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix test descriptions Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor: rename extdata package to external Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
2025-04-08 21:11:09 -04:00
parent 6b59f5f73a
commit 58367afaea
26 changed files with 1959 additions and 209 deletions
@@ -14,40 +14,40 @@ import (

 func CreateMockMediaFileRepo() *MockMediaFileRepo {
 	return &MockMediaFileRepo{
-		data: make(map[string]*model.MediaFile),
+		Data: make(map[string]*model.MediaFile),
 	}
 }

 type MockMediaFileRepo struct {
 	model.MediaFileRepository
-	data map[string]*model.MediaFile
-	err  bool
+	Data map[string]*model.MediaFile
+	Err  bool
 }

 func (m *MockMediaFileRepo) SetError(err bool) {
-	m.err = err
+	m.Err = err
 }

 func (m *MockMediaFileRepo) SetData(mfs model.MediaFiles) {
-	m.data = make(map[string]*model.MediaFile)
+	m.Data = make(map[string]*model.MediaFile)
 	for i, mf := range mfs {
-		m.data[mf.ID] = &mfs[i]
+		m.Data[mf.ID] = &mfs[i]
 	}
 }

 func (m *MockMediaFileRepo) Exists(id string) (bool, error) {
-	if m.err {
+	if m.Err {
 		return false, errors.New("error")
 	}
-	_, found := m.data[id]
+	_, found := m.Data[id]
 	return found, nil
 }

 func (m *MockMediaFileRepo) Get(id string) (*model.MediaFile, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		// Intentionally clone the file and remove participants. This should
 		// catch any caller that actually means to call GetWithParticipants
 		res := *d
@@ -58,52 +58,52 @@ func (m *MockMediaFileRepo) Get(id string) (*model.MediaFile, error) {
 }

 func (m *MockMediaFileRepo) GetWithParticipants(id string) (*model.MediaFile, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		return d, nil
 	}
 	return nil, model.ErrNotFound
 }

 func (m *MockMediaFileRepo) GetAll(...model.QueryOptions) (model.MediaFiles, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("error")
 	}
-	values := slices.Collect(maps.Values(m.data))
+	values := slices.Collect(maps.Values(m.Data))
 	return slice.Map(values, func(p *model.MediaFile) model.MediaFile {
 		return *p
 	}), nil
 }

 func (m *MockMediaFileRepo) Put(mf *model.MediaFile) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
 	if mf.ID == "" {
 		mf.ID = id.NewRandom()
 	}
-	m.data[mf.ID] = mf
+	m.Data[mf.ID] = mf
 	return nil
 }

 func (m *MockMediaFileRepo) Delete(id string) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
-	if _, ok := m.data[id]; !ok {
+	if _, ok := m.Data[id]; !ok {
 		return model.ErrNotFound
 	}
-	delete(m.data, id)
+	delete(m.Data, id)
 	return nil
 }

 func (m *MockMediaFileRepo) IncPlayCount(id string, timestamp time.Time) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		d.PlayCount++
 		d.PlayDate = &timestamp
 		return nil
@@ -112,12 +112,12 @@ func (m *MockMediaFileRepo) IncPlayCount(id string, timestamp time.Time) error {
 }

 func (m *MockMediaFileRepo) FindByAlbum(artistId string) (model.MediaFiles, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("error")
 	}
-	var res = make(model.MediaFiles, len(m.data))
+	var res = make(model.MediaFiles, len(m.Data))
 	i := 0
-	for _, a := range m.data {
+	for _, a := range m.Data {
 		if a.AlbumID == artistId {
 			res[i] = *a
 			i++
@@ -128,17 +128,17 @@ func (m *MockMediaFileRepo) FindByAlbum(artistId string) (model.MediaFiles, erro
 }

 func (m *MockMediaFileRepo) GetMissingAndMatching(libId int) (model.MediaFileCursor, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("error")
 	}
 	var res model.MediaFiles
-	for _, a := range m.data {
+	for _, a := range m.Data {
 		if a.LibraryID == libId && a.Missing {
 			res = append(res, *a)
 		}
 	}

-	for _, a := range m.data {
+	for _, a := range m.Data {
 		if a.LibraryID == libId && !(*a).Missing && slices.IndexFunc(res, func(mediaFile model.MediaFile) bool {
 			return mediaFile.PID == a.PID
 		}) != -1 {