refactor: external_metadata -> external.Provider (#3903)

* tests for TopSongs Signed-off-by: Deluan <deluan@navidrome.org> * convert to Ginkgo Signed-off-by: Deluan <deluan@navidrome.org> * consolidate tests Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata -wip Signed-off-by: Deluan <deluan@navidrome.org> * rename external metadata to extdata.Provider Signed-off-by: Deluan <deluan@navidrome.org> * refactor tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor test helpers Signed-off-by: Deluan <deluan@navidrome.org> * remove reflection Signed-off-by: Deluan <deluan@navidrome.org> * use mock.Mock Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix Signed-off-by: Deluan <deluan@navidrome.org> * receive Agents interface in Provider constructor Signed-off-by: Deluan <deluan@navidrome.org> * use mock for Agents Signed-off-by: Deluan <deluan@navidrome.org> * tests for SimilarSongs Signed-off-by: Deluan <deluan@navidrome.org> * remove duplication Signed-off-by: Deluan <deluan@navidrome.org> * ArtistImage tests Signed-off-by: Deluan <deluan@navidrome.org> * AlbumImage tests Signed-off-by: Deluan <deluan@navidrome.org> * fix provider error handling Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * UpdateArtistInfo tests - wip Signed-off-by: Deluan <deluan@navidrome.org> * clean up Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * fix test descriptions Signed-off-by: Deluan <deluan@navidrome.org> * refactor Signed-off-by: Deluan <deluan@navidrome.org> * refactor: rename extdata package to external Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
2025-04-08 21:11:09 -04:00
parent 6b59f5f73a
commit 58367afaea
26 changed files with 1959 additions and 209 deletions
@@ -9,9 +9,9 @@ import (

 type MockedRadioRepo struct {
 	model.RadioRepository
-	data    map[string]*model.Radio
-	all     model.Radios
-	err     bool
+	Data    map[string]*model.Radio
+	All     model.Radios
+	Err     bool
 	Options model.QueryOptions
 }

@@ -20,44 +20,44 @@ func CreateMockedRadioRepo() *MockedRadioRepo {
 }

 func (m *MockedRadioRepo) SetError(err bool) {
-	m.err = err
+	m.Err = err
 }

 func (m *MockedRadioRepo) CountAll(options ...model.QueryOptions) (int64, error) {
-	if m.err {
+	if m.Err {
 		return 0, errors.New("error")
 	}
-	return int64(len(m.data)), nil
+	return int64(len(m.Data)), nil
 }

 func (m *MockedRadioRepo) Delete(id string) error {
-	if m.err {
+	if m.Err {
 		return errors.New("Error!")
 	}

-	_, found := m.data[id]
+	_, found := m.Data[id]

 	if !found {
 		return errors.New("not found")
 	}

-	delete(m.data, id)
+	delete(m.Data, id)
 	return nil
 }

 func (m *MockedRadioRepo) Exists(id string) (bool, error) {
-	if m.err {
+	if m.Err {
 		return false, errors.New("Error!")
 	}
-	_, found := m.data[id]
+	_, found := m.Data[id]
 	return found, nil
 }

 func (m *MockedRadioRepo) Get(id string) (*model.Radio, error) {
-	if m.err {
+	if m.Err {
 		return nil, errors.New("Error!")
 	}
-	if d, ok := m.data[id]; ok {
+	if d, ok := m.Data[id]; ok {
 		return d, nil
 	}
 	return nil, model.ErrNotFound
@@ -67,19 +67,19 @@ func (m *MockedRadioRepo) GetAll(qo ...model.QueryOptions) (model.Radios, error)
 	if len(qo) > 0 {
 		m.Options = qo[0]
 	}
-	if m.err {
+	if m.Err {
 		return nil, errors.New("Error!")
 	}
-	return m.all, nil
+	return m.All, nil
 }

 func (m *MockedRadioRepo) Put(radio *model.Radio) error {
-	if m.err {
+	if m.Err {
 		return errors.New("error")
 	}
 	if radio.ID == "" {
 		radio.ID = id.NewRandom()
 	}
-	m.data[radio.ID] = radio
+	m.Data[radio.ID] = radio
 	return nil
 }