Use a RWMutex instead of an AtomicBool, to reduce contention

2020-07-26 00:45:33 -04:00
parent f8f16d676d
commit 67da83c84d
4 changed files with 39 additions and 28 deletions
@@ -32,8 +32,10 @@ func (c *StreamController) Stream(w http.ResponseWriter, r *http.Request) (*resp
 	if err != nil {
 		return nil, err
 	}
+
+	// Make sure the stream will be closed at the end, to avoid leakage
 	defer func() {
-		if err := stream.Close(); err != nil {
+		if err := stream.Close(); err != nil && log.CurrentLevel() >= log.LevelDebug {
 			log.Error("Error closing stream", "id", id, "file", stream.Name(), err)
 		}
 	}()