From 6c7f8314e28d68c56e1088b5aea1e93d1d9574bf Mon Sep 17 00:00:00 2001 From: Boris Rorsvort Date: Tue, 20 Jan 2026 18:45:33 +0100 Subject: [PATCH] fix(ui): UI issues & styling coherence (#4910) * fix: ui issues and styles * fix linter --- ui/src/album/AlbumDetails.jsx | 6 +++--- ui/src/common/LoveButton.jsx | 26 ++++++++++++++++++-------- ui/src/layout/UserMenu.jsx | 6 ++++-- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/ui/src/album/AlbumDetails.jsx b/ui/src/album/AlbumDetails.jsx index 8213eb9d..7b38e53d 100644 --- a/ui/src/album/AlbumDetails.jsx +++ b/ui/src/album/AlbumDetails.jsx @@ -228,7 +228,7 @@ const AlbumDetails = (props) => { let notes = albumInfo?.notes?.replace(new RegExp('<.*>', 'g'), '') || record.notes - if (notes !== undefined) { + if (notes) { notes += '..' } @@ -340,7 +340,7 @@ const AlbumDetails = (props) => { )} )} - {isDesktop && ( + {isDesktop && notes && ( { {!isDesktop && record['comment'] && ( )} - {!isDesktop && ( + {!isDesktop && notes && (
props.color, - visibility: (props) => - props.visible === false ? 'hidden' : props.loved ? 'visible' : 'inherit', +const useStyles = makeStyles( + { + love: { + color: (props) => props.color, + visibility: (props) => + props.visible === false + ? 'hidden' + : props.loved + ? 'visible' + : 'inherit', + }, }, -}) + { name: 'NDLoveButton' }, +) export const LoveButton = ({ resource, @@ -25,9 +33,11 @@ export const LoveButton = ({ component: Button, addLabel, disabled, + className, + record: recordProp, ...rest }) => { - const record = useRecordContext(rest) || {} + const record = useRecordContext({ record: recordProp }) || {} const classes = useStyles({ color, visible, loved: record.starred }) const [toggleLove, loading] = useToggleLove(resource, record) @@ -48,7 +58,7 @@ export const LoveButton = ({ onClick={handleToggleLove} size={'small'} disabled={disabled || loading || record.missing} - className={classes.love} + className={clsx(classes.love, className)} title={ isDateSet(record.starredAt) ? new Date(record.starredAt).toLocaleString() diff --git a/ui/src/layout/UserMenu.jsx b/ui/src/layout/UserMenu.jsx index c7a3deaf..a5757a73 100644 --- a/ui/src/layout/UserMenu.jsx +++ b/ui/src/layout/UserMenu.jsx @@ -28,6 +28,9 @@ import { useDispatch } from 'react-redux' const useStyles = makeStyles((theme) => ({ user: {}, + button: { + color: 'inherit', + }, avatar: { width: theme.spacing(4), height: theme.spacing(4), @@ -72,12 +75,11 @@ const UserMenu = (props) => {
{loaded && identity.avatar ? (