arian/navidrome
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Parse more itunes keys, optimize taglib wrapper (#2680)

Browse Source 
* parse more itunes keys

* Move special iTunes M4A logic to Go code

* Simplify ASF/WMA tags handling

* Simplify ASF/WMA tags handling even more, moving compilation logic to `metadata` normalizer

* Remove strdups from C++ code, `C.GoString` already duplicates the strings

* reduced set

* remove strdup

* Small nitpick

---------

Co-authored-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Kendall Garner
2023-12-03 19:19:16 +00:00
committed by GitHub
parent 7766ee069c
commit 742fd16a01
10 changed files with 70 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scanner/metadata/metadata.go
+1 -1
View File
@@ -107,7 +107,7 @@ func (t Tags) Comment() string { return t.getFirstTagValue("comment"
func (t Tags) Lyrics() string {
return t.getFirstTagValue("lyrics", "lyrics-eng", "unsynced_lyrics", "unsynced lyrics", "unsyncedlyrics")
}
func (t Tags) Compilation() bool { return t.getBool("tcmp", "compilation") }
func (t Tags) Compilation() bool { return t.getBool("tcmp", "compilation", "wm/iscompilation") }
func (t Tags) TrackNumber() (int, int) { return t.getTuple("track", "tracknumber") }
func (t Tags) DiscNumber() (int, int) { return t.getTuple("disc", "discnumber") }
func (t Tags) DiscSubtitle() string {