arian/navidrome
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

refactor: rename spy to streamerSpy in e2e tests for clarity

Browse Source 
Renamed the spy variable to streamerSpy across all e2e test files so
that its purpose is immediately clear without needing to look up the
declaration.
This commit is contained in:
Deluan
2026-03-10 17:19:25 -04:00
parent 053a0fd6c0
commit 75e5bc4e81
4 changed files with 48 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/e2e/subsonic_stream_test.go
+19 -19
View File
@@ -33,25 +33,25 @@ var _ = Describe("stream.view (legacy streaming)", Ordered, func() {
It("streams raw when no format or maxBitRate is specified", func() {
w := doRawReq("stream", "id", flacTrackID)
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(BeElementOf("raw", ""))
Expect(streamerSpy.LastRequest.Format).To(BeElementOf("raw", ""))
})
It("streams raw when format=raw is explicitly requested", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "raw")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(BeElementOf("raw", ""))
Expect(streamerSpy.LastRequest.Format).To(BeElementOf("raw", ""))
})
It("streams raw when maxBitRate is >= source bitrate", func() {
w := doRawReq("stream", "id", flacTrackID, "maxBitRate", "1000")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(BeElementOf("raw", ""))
Expect(streamerSpy.LastRequest.Format).To(BeElementOf("raw", ""))
})
It("streams raw when format matches source and bitrate is not lower", func() {
w := doRawReq("stream", "id", mp3TrackID, "format", "mp3", "maxBitRate", "320")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("raw"))
Expect(streamerSpy.LastRequest.Format).To(Equal("raw"))
})
})
@@ -59,44 +59,44 @@ var _ = Describe("stream.view (legacy streaming)", Ordered, func() {
It("transcodes to mp3 when format=mp3 is requested", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "mp3")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("mp3"))
Expect(streamerSpy.LastRequest.Format).To(Equal("mp3"))
// Should use the mp3 default bitrate (192kbps)
Expect(spy.LastRequest.BitRate).To(Equal(192))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(192))
})
It("transcodes to opus when format=opus is requested (no maxBitRate)", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "opus")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("opus"))
Expect(streamerSpy.LastRequest.Format).To(Equal("opus"))
// Should use the opus default bitrate (128kbps)
Expect(spy.LastRequest.BitRate).To(Equal(128))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(128))
})
It("transcodes to opus with specified maxBitRate", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "opus", "maxBitRate", "192")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("opus"))
Expect(spy.LastRequest.BitRate).To(Equal(192))
Expect(streamerSpy.LastRequest.Format).To(Equal("opus"))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(192))
})
It("transcodes to mp3 with specified maxBitRate", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "mp3", "maxBitRate", "128")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("mp3"))
Expect(spy.LastRequest.BitRate).To(Equal(128))
Expect(streamerSpy.LastRequest.Format).To(Equal("mp3"))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(128))
})
It("transcodes MP3 to opus when format=opus is requested", func() {
w := doRawReq("stream", "id", mp3TrackID, "format", "opus")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("opus"))
Expect(streamerSpy.LastRequest.Format).To(Equal("opus"))
})
It("transcodes same format when maxBitRate is lower than source", func() {
w := doRawReq("stream", "id", mp3TrackID, "format", "mp3", "maxBitRate", "128")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("mp3"))
Expect(spy.LastRequest.BitRate).To(Equal(128))
Expect(streamerSpy.LastRequest.Format).To(Equal("mp3"))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(128))
})
})
@@ -105,15 +105,15 @@ var _ = Describe("stream.view (legacy streaming)", Ordered, func() {
conf.Server.DefaultDownsamplingFormat = "opus"
w := doRawReq("stream", "id", flacTrackID, "maxBitRate", "192")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(Equal("opus"))
Expect(spy.LastRequest.BitRate).To(Equal(192))
Expect(streamerSpy.LastRequest.Format).To(Equal("opus"))
Expect(streamerSpy.LastRequest.BitRate).To(Equal(192))
})
It("streams raw when maxBitRate >= source bitrate (no downsampling needed)", func() {
conf.Server.DefaultDownsamplingFormat = "opus"
w := doRawReq("stream", "id", mp3TrackID, "maxBitRate", "320")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Format).To(BeElementOf("raw", ""))
Expect(streamerSpy.LastRequest.Format).To(BeElementOf("raw", ""))
})
})
@@ -121,7 +121,7 @@ var _ = Describe("stream.view (legacy streaming)", Ordered, func() {
It("passes timeOffset to the stream request", func() {
w := doRawReq("stream", "id", flacTrackID, "format", "mp3", "timeOffset", "30")
Expect(w.Code).To(Equal(http.StatusOK))
Expect(spy.LastRequest.Offset).To(Equal(30))
Expect(streamerSpy.LastRequest.Offset).To(Equal(30))
})
})
})