From 82d437f004c61388cd1a49d1090d9e83e34e8018 Mon Sep 17 00:00:00 2001
From: Deluan <deluan@deluan.com>
Date: Tue, 9 Jun 2020 07:45:23 -0400
Subject: [PATCH] Better defaults to sort orders in List views

---
 ui/src/album/AlbumListView.js   |  6 +++---
 ui/src/artist/ArtistList.js     |  4 ++--
 ui/src/player/PlayerList.js     |  2 +-
 ui/src/playlist/PlaylistList.js |  8 ++++++--
 ui/src/song/SongList.js         | 13 ++++++++++---
 ui/src/user/UserList.js         |  4 ++--
 6 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/ui/src/album/AlbumListView.js b/ui/src/album/AlbumListView.js
index 253875c1..7bc9beb8 100644
--- a/ui/src/album/AlbumListView.js
+++ b/ui/src/album/AlbumListView.js
@@ -84,9 +84,9 @@ const AlbumListView = ({ hasShow, hasEdit, hasList, ...rest }) => {
     <AlbumDatagrid expand={<AlbumDetails />} rowClick={'show'} {...rest}>
       <TextField source="name" />
       <ArtistLinkField />
-      {isDesktop && <NumberField source="songCount" />}
-      {isDesktop && <NumberField source="playCount" />}
-      <RangeField source={'year'} sortBy={'maxYear'} />
+      {isDesktop && <NumberField source="songCount" sortByOrder={'DESC'} />}
+      {isDesktop && <NumberField source="playCount" sortByOrder={'DESC'} />}
+      <RangeField source={'year'} sortBy={'maxYear'} sortByOrder={'DESC'} />
       {isDesktop && <DurationField source="duration" />}
       <AlbumContextMenu />
     </AlbumDatagrid>
diff --git a/ui/src/artist/ArtistList.js b/ui/src/artist/ArtistList.js
index c33c8373..c8881177 100644
--- a/ui/src/artist/ArtistList.js
+++ b/ui/src/artist/ArtistList.js
@@ -24,8 +24,8 @@ const ArtistList = (props) => (
   >
     <Datagrid rowClick={artistLink}>
       <TextField source="name" />
-      <NumberField source="albumCount" />
-      <NumberField source="songCount" />
+      <NumberField source="albumCount" sortByOrder={'DESC'} />
+      <NumberField source="songCount" sortByOrder={'DESC'} />
     </Datagrid>
   </List>
 )
diff --git a/ui/src/player/PlayerList.js b/ui/src/player/PlayerList.js
index 2bf17687..c36ef304 100644
--- a/ui/src/player/PlayerList.js
+++ b/ui/src/player/PlayerList.js
@@ -29,7 +29,7 @@ const PlayerList = (props) => {
             source="maxBitRate"
             render={(r) => (r.maxBitRate ? r.maxBitRate : '-')}
           />
-          <DateField source="lastSeen" showTime />
+          <DateField source="lastSeen" showTime sortByOrder={'DESC'} />
         </Datagrid>
       )}
     </List>
diff --git a/ui/src/playlist/PlaylistList.js b/ui/src/playlist/PlaylistList.js
index 4e06e61e..2d292ecc 100644
--- a/ui/src/playlist/PlaylistList.js
+++ b/ui/src/playlist/PlaylistList.js
@@ -63,8 +63,12 @@ const PlaylistList = ({ permissions, ...props }) => (
       <TextField source="owner" />
       <NumberField source="songCount" />
       <DurationField source="duration" />
-      <DateField source="updatedAt" />
-      <TogglePublicInput source="public" permissions={permissions} />
+      <DateField source="updatedAt" sortByOrder={'DESC'} />
+      <TogglePublicInput
+        source="public"
+        permissions={permissions}
+        sortByOrder={'DESC'}
+      />
       <Writable>
         <EditButton />
       </Writable>
diff --git a/ui/src/song/SongList.js b/ui/src/song/SongList.js
index ff55c4a5..1cc5495f 100644
--- a/ui/src/song/SongList.js
+++ b/ui/src/song/SongList.js
@@ -87,14 +87,21 @@ const SongList = (props) => {
             {isDesktop && <AlbumLinkField source="album" />}
             <TextField source="artist" />
             {isDesktop && <NumberField source="trackNumber" />}
-            {isDesktop && <NumberField source="playCount" />}
             {isDesktop && (
-              <FunctionField source="year" render={(r) => r.year || ''} />
+              <NumberField source="playCount" sortByOrder={'DESC'} />
+            )}
+            {isDesktop && (
+              <FunctionField
+                source="year"
+                render={(r) => r.year || ''}
+                sortByOrder={'DESC'}
+              />
             )}
             <DurationField source="duration" />
             <SongContextMenu
               source={'starred'}
-              sortBy={'starred DESC, starredAt DESC'}
+              sortBy={'starred ASC, starredAt ASC'}
+              sortByOrder={'DESC'}
               label={
                 <StarBorderIcon
                   fontSize={'small'}
diff --git a/ui/src/user/UserList.js b/ui/src/user/UserList.js
index 74775fc1..6a040711 100644
--- a/ui/src/user/UserList.js
+++ b/ui/src/user/UserList.js
@@ -40,8 +40,8 @@ const UserList = (props) => {
           <TextField source="userName" />
           <TextField source="name" />
           <BooleanField source="isAdmin" />
-          <DateField source="lastLoginAt" locales="pt-BR" />
-          <DateField source="updatedAt" locales="pt-BR" />
+          <DateField source="lastLoginAt" sortByOrder={'DESC'} />
+          <DateField source="updatedAt" sortByOrder={'DESC'} />
         </Datagrid>
       )}
     </List>