GetCoverArt returns placeholder if id is missing

This mimics Subsonic behaviour, even if it contradicts the API documentation, which states `id` is required

Fixes #1139

utils/request_helpers.go

@@ -11,6 +11,14 @@ func ParamString(r *http.Request, param string) string {
 	return r.URL.Query().Get(param)
 }
 
+func ParamStringDefault(r *http.Request, param, def string) string {
+	v := ParamString(r, param)
+	if v == "" {
+		return def
+	}
+	return v
+}
+
 func ParamStrings(r *http.Request, param string) []string {
 	return r.URL.Query()[param]
 }

utils/request_helpers_test.go

@@ -27,6 +27,20 @@ var _ = Describe("Request Helpers", func() {
 		})
 	})
 
+	Describe("ParamStringDefault", func() {
+		BeforeEach(func() {
+			r = httptest.NewRequest("GET", "/ping?a=123", nil)
+		})
+
+		It("returns default string if param does not exist", func() {
+			Expect(ParamStringDefault(r, "xx", "default_value")).To(Equal("default_value"))
+		})
+
+		It("returns param as string", func() {
+			Expect(ParamStringDefault(r, "a", "default_value")).To(Equal("123"))
+		})
+	})
+
 	Describe("ParamStrings", func() {
 		BeforeEach(func() {
 			r = httptest.NewRequest("GET", "/ping?a=123&a=456", nil)