arian/navidrome
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Handle "Infinity" values for ReplayGain. Fix #2862

Browse Source
This commit is contained in:
Deluan
2024-02-16 18:44:58 -05:00
parent 0b2cf30096
commit 9a051967f6
3 changed files with 36 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scanner/metadata/metadata.go
+5 -7
View File
@@ -223,7 +223,8 @@ func (t Tags) BirthTime() time.Time {
return time.Now()
}
// Replaygain Properties
// ReplayGain Properties
func (t Tags) RGAlbumGain() float64 { return t.getGainValue("replaygain_album_gain") }
func (t Tags) RGAlbumPeak() float64 { return t.getPeakValue("replaygain_album_peak") }
func (t Tags) RGTrackGain() float64 { return t.getGainValue("replaygain_track_gain") }
@@ -232,15 +233,12 @@ func (t Tags) RGTrackPeak() float64 { return t.getPeakValue("replaygain_track_pe
func (t Tags) getGainValue(tagName string) float64 {
// Gain is in the form [-]a.bb dB
var tag = t.getFirstTagValue(tagName)
if tag == "" {
return 0
}
tag = strings.TrimSpace(strings.Replace(tag, "dB", "", 1))
var value, err = strconv.ParseFloat(tag, 64)
if err != nil {
if err != nil || value == math.Inf(-1) || value == math.Inf(1) {
return 0
}
return value
@@ -249,8 +247,8 @@ func (t Tags) getGainValue(tagName string) float64 {
func (t Tags) getPeakValue(tagName string) float64 {
var tag = t.getFirstTagValue(tagName)
var value, err = strconv.ParseFloat(tag, 64)
if err != nil {
// A default of 1 for peak value resulds in no changes
if err != nil || value == math.Inf(-1) || value == math.Inf(1) {
// A default of 1 for peak value results in no changes
return 1
}
return value