From 9b461735f4d54aff26ea0053843d9103a838113a Mon Sep 17 00:00:00 2001 From: Deluan Date: Fri, 3 Apr 2020 14:48:44 -0400 Subject: [PATCH] Add comments to createXxxxCommand functions to clarify about the filepaths arguments being absolute paths --- engine/transcoder/ffmpeg.go | 1 + scanner/metadata_ffmpeg.go | 1 + 2 files changed, 2 insertions(+) diff --git a/engine/transcoder/ffmpeg.go b/engine/transcoder/ffmpeg.go index 4ab37ab3..1cf6b975 100644 --- a/engine/transcoder/ffmpeg.go +++ b/engine/transcoder/ffmpeg.go @@ -37,6 +37,7 @@ func (ff *ffmpeg) Start(ctx context.Context, command, path string, maxBitRate in return } +// Path will always be an absolute path func createTranscodeCommand(cmd, path string, maxBitRate int, format string) (string, []string) { split := strings.Split(cmd, " ") for i, s := range split { diff --git a/scanner/metadata_ffmpeg.go b/scanner/metadata_ffmpeg.go index e922a3ab..402bbabb 100644 --- a/scanner/metadata_ffmpeg.go +++ b/scanner/metadata_ffmpeg.go @@ -268,6 +268,7 @@ func (m *Metadata) parseDuration(tagName string) float32 { return 0 } +// Inputs will always be absolute paths func createProbeCommand(inputs []string) (string, []string) { cmd := conf.Server.ProbeCommand