fix(server): failed transcoded files should not be cached (#4124)
* Close stream on caching errors * fix(test): replace errPartialReader with errFakeReader to fix lint error Signed-off-by: Deluan <deluan@navidrome.org> * fix(test): update error assertion to check for substring in closed file error Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Vendored
+1
@@ -174,6 +174,7 @@ func (fc *fileCache) Get(ctx context.Context, arg Item) (*CachedStream, error) {
|
||||
go func() {
|
||||
if err := copyAndClose(w, reader); err != nil {
|
||||
log.Debug(ctx, "Error storing file in cache", "cache", fc.name, "key", key, err)
|
||||
_ = r.Close()
|
||||
_ = fc.invalidate(ctx, key)
|
||||
} else {
|
||||
log.Trace(ctx, "File successfully stored in cache", "cache", fc.name, "key", key)
|
||||
|
||||
Reference in New Issue
Block a user