arian/navidrome
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(plugins): silence plugin warnings and folder creation when plugins disabled (#4297)

Browse Source 
* fix(plugins): silence repeated “Plugin not found” spam for inactive Spotify/Last.fm plugins

Navidrome was emitting a warning when the optional Spotify or
Last.fm agents weren’t enabled, filling the journal with entries like:

    level=warning msg="Plugin not found" capability=MetadataAgent name=spotify

Fixed by completely disable the plugin system when Plugins.Enabled = false.

Signed-off-by: Deluan <deluan@navidrome.org>

* style: update test description for clarity

Signed-off-by: Deluan <deluan@navidrome.org>

* fix: ensure plugin folder is created only if plugins are enabled

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan Quintão
2025-07-02 13:17:59 -04:00
committed by GitHub
parent 82f490d066
commit a3d1a9dbe5
18 changed files with 102 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/plugin_lifecycle_manager_test.go
+1 -1
View File
@@ -18,7 +18,7 @@ func hasInitService(info *plugin) bool {
}
var _ = Describe("LifecycleManagement", func() {
Describe("Plugin Lifecycle Manager", func() {
Describe("Plugin Lifecycle managerImpl", func() {
var lifecycleManager *pluginLifecycleManager
BeforeEach(func() {