From a55c4f04108fab215e64cf8e54cb814531b74923 Mon Sep 17 00:00:00 2001 From: Deluan Date: Tue, 27 Jan 2026 14:31:23 -0500 Subject: [PATCH] fix(plugins): log plugin function not implemented and record successful request metrics Signed-off-by: Deluan --- plugins/manager_call.go | 3 ++- plugins/manager_call_test.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/manager_call.go b/plugins/manager_call.go index 957d552f..834f4542 100644 --- a/plugins/manager_call.go +++ b/plugins/manager_call.go @@ -72,7 +72,8 @@ func callPluginFunction[I any, O any](ctx context.Context, plugin *plugin, funcN } if exit != 0 { if exit == notImplementedCode { - plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, false, elapsed.Milliseconds()) + log.Trace(ctx, "Plugin function not implemented", "plugin", plugin.name, "function", funcName, "pluginDuration", elapsed, "navidromeDuration", startCall.Sub(start)) + plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, true, elapsed.Milliseconds()) return result, fmt.Errorf("%w: %s", errNotImplemented, funcName) } plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, false, elapsed.Milliseconds()) diff --git a/plugins/manager_call_test.go b/plugins/manager_call_test.go index 742c0e08..32e9df99 100644 --- a/plugins/manager_call_test.go +++ b/plugins/manager_call_test.go @@ -126,6 +126,6 @@ var _ = Describe("callPluginFunction metrics", Ordered, func() { Expect(calls).To(HaveLen(1)) Expect(calls[0].plugin).To(Equal("partial-metadata-agent")) Expect(calls[0].method).To(Equal(FuncGetArtistMBID)) - Expect(calls[0].ok).To(BeFalse()) + Expect(calls[0].ok).To(BeTrue()) }) })