Restore MediaRetrievalController tests

2020-01-09 21:58:03 -05:00
parent 0c3edc0279
commit b1e58352e9
5 changed files with 88 additions and 141 deletions
@@ -1,74 +1,76 @@
-package api_test
+package api

-//
-//import (
-//	"fmt"
-//	"net/http"
-//	"net/http/httptest"
-//	"testing"
-//
-//	"github.com/astaxie/beego"
-//	"github.com/cloudsonic/sonic-server/api/responses"
-//	"github.com/cloudsonic/sonic-server/domain"
-//	"github.com/cloudsonic/sonic-server/persistence"
-//	. "github.com/cloudsonic/sonic-server/tests"
-//	"github.com/cloudsonic/sonic-server/utils"
-//	. "github.com/smartystreets/goconvey/convey"
-//)
-//
-//func getCoverArt(params ...string) (*http.Request, *httptest.ResponseRecorder) {
-//	url := AddParams("/rest/getCoverArt.view", params...)
-//	r, _ := http.NewRequest("GET", url, nil)
-//	w := httptest.NewRecorder()
-//	beego.BeeApp.Handlers.ServeHTTP(w, r)
-//	log.Debug(r, "testing TestGetCoverArt", fmt.Sprintf("\nUrl: %s\nStatus Code: [%d]\n%#v", r.URL, w.Code, w.HeaderMap))
-//	return r, w
-//}
-//
-//func TestGetCoverArt(t *testing.T) {
-//	Init(t, false)
-//
-//	mockMediaFileRepo := persistence.CreateMockMediaFileRepo()
-//	utils.DefineSingleton(new(domain.MediaFileRepository), func() domain.MediaFileRepository {
-//		return mockMediaFileRepo
-//	})
-//
-//	Convey("Subject: GetCoverArt Endpoint", t, func() {
-//		Convey("Should fail if missing Id parameter", func() {
-//			_, w := getCoverArt()
-//
-//			So(w.Body, ShouldReceiveError, responses.ErrorMissingParameter)
-//		})
-//		Convey("When id is found", func() {
-//			mockMediaFileRepo.SetData(`[{"Id":"2","HasCoverArt":true,"Path":"tests/fixtures/01 Invisible (RED) Edit Version.mp3"}]`, 1)
-//			_, w := getCoverArt("id=2")
-//
-//			So(w.Body.Bytes(), ShouldMatchMD5, "e859a71cd1b1aaeb1ad437d85b306668")
-//			So(w.Header().Get("Content-Type"), ShouldEqual, "image/jpeg")
-//		})
-//		Convey("When id is found but file is unavailable", func() {
-//			mockMediaFileRepo.SetData(`[{"Id":"2","HasCoverArt":true,"Path":"tests/fixtures/NOT_FOUND.mp3"}]`, 1)
-//			_, w := getCoverArt("id=2")
-//
-//			So(w.Body, ShouldReceiveError, responses.ErrorDataNotFound)
-//		})
-//		Convey("When the engine reports an error", func() {
-//			mockMediaFileRepo.SetData(`[{"Id":"2","HasCoverArt":true,"Path":"tests/fixtures/NOT_FOUND.mp3"}]`, 1)
-//			mockMediaFileRepo.SetError(true)
-//			_, w := getCoverArt("id=2")
-//
-//			So(w.Body, ShouldReceiveError, responses.ErrorGeneric)
-//		})
-//		Convey("When specifying a size", func() {
-//			mockMediaFileRepo.SetData(`[{"Id":"2","HasCoverArt":true,"Path":"tests/fixtures/01 Invisible (RED) Edit Version.mp3"}]`, 1)
-//			_, w := getCoverArt("id=2", "size=100")
-//
-//			So(w.Body.Bytes(), ShouldMatchMD5, "04378f523ca3e8ead33bf7140d39799e")
-//			So(w.Header().Get("Content-Type"), ShouldEqual, "image/jpeg")
-//		})
-//		Reset(func() {
-//			mockMediaFileRepo.SetData("[]", 0)
-//			mockMediaFileRepo.SetError(false)
-//		})
-//	})
-//}
+import (
+	"errors"
+	"io"
+	"net/http/httptest"
+
+	"github.com/cloudsonic/sonic-server/domain"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+)
+
+type fakeCover struct {
+	data     string
+	err      error
+	recvId   string
+	recvSize int
+}
+
+func (c *fakeCover) Get(id string, size int, out io.Writer) error {
+	if c.err != nil {
+		return c.err
+	}
+	c.recvId = id
+	c.recvSize = size
+	out.Write([]byte(c.data))
+	return nil
+}
+
+var _ = Describe("MediaRetrievalController", func() {
+	var controller *MediaRetrievalController
+	var cover *fakeCover
+	var w *httptest.ResponseRecorder
+
+	BeforeEach(func() {
+		cover = &fakeCover{}
+		controller = NewMediaRetrievalController(cover)
+		w = httptest.NewRecorder()
+	})
+
+	Describe("GetCoverArt", func() {
+		It("should return data for that id", func() {
+			cover.data = "image data"
+			r := newTestRequest("id=34", "size=128")
+			_, err := controller.GetCoverArt(w, r)
+
+			Expect(err).To(BeNil())
+			Expect(cover.recvId).To(Equal("34"))
+			Expect(cover.recvSize).To(Equal(128))
+			Expect(w.Body.String()).To(Equal(cover.data))
+		})
+
+		It("should fail if missing id parameter", func() {
+			r := newTestRequest()
+			_, err := controller.GetCoverArt(w, r)
+
+			Expect(err).To(MatchError("id parameter required"))
+		})
+
+		It("should fail when the file is not found", func() {
+			cover.err = domain.ErrNotFound
+			r := newTestRequest("id=34", "size=128")
+			_, err := controller.GetCoverArt(w, r)
+
+			Expect(err).To(MatchError("Cover not found"))
+		})
+
+		It("should fail when there is an unknown error", func() {
+			cover.err = errors.New("weird error")
+			r := newTestRequest("id=34", "size=128")
+			_, err := controller.GetCoverArt(w, r)
+
+			Expect(err).To(MatchError("Internal Error"))
+		})
+	})
+})