Change icon on active menu item (#903)

* add icons

* add logic to change the icon

* make the active menu bold

* Encapsulate the dynamic icon behaviour into a self-contained component

Co-authored-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Ruchi Kushwaha
2021-04-17 10:10:07 +05:30
committed by GitHub
parent 16a5ac323b
commit b441260186
8 changed files with 173 additions and 21 deletions
+14 -6
View File
@@ -1,6 +1,6 @@
import React, { useState, createElement } from 'react'
import React, { useState } from 'react'
import { useSelector } from 'react-redux'
import { useMediaQuery } from '@material-ui/core'
import { makeStyles, useMediaQuery } from '@material-ui/core'
import { useTranslate, MenuItemLink, getResources } from 'react-admin'
import { withRouter } from 'react-router-dom'
import LibraryMusicIcon from '@material-ui/icons/LibraryMusic'
@@ -11,6 +11,13 @@ import inflection from 'inflection'
import albumLists from '../album/albumLists'
import { HelpDialog } from '../dialogs'
const useStyles = makeStyles((theme) => ({
active: {
color: theme.palette.text.primary,
fontWeight: 'bold',
},
}))
const translatedResourceName = (resource, translate) =>
translate(`resources.${resource.name}.name`, {
smart_count: 2,
@@ -27,6 +34,7 @@ const Menu = ({ onMenuClick, dense, logout }) => {
const isXsmall = useMediaQuery((theme) => theme.breakpoints.down('xs'))
const open = useSelector((state) => state.admin.ui.sidebarOpen)
const translate = useTranslate()
const classes = useStyles()
const resources = useSelector(getResources)
// TODO State is not persisted in mobile when you close the sidebar menu. Move to redux?
@@ -44,10 +52,9 @@ const Menu = ({ onMenuClick, dense, logout }) => {
<MenuItemLink
key={resource.name}
to={`/${resource.name}`}
activeClassName={classes.active}
primaryText={translatedResourceName(resource, translate)}
leftIcon={
(resource.icon && createElement(resource.icon)) || <ViewListIcon />
}
leftIcon={resource.icon || <ViewListIcon />}
onClick={onMenuClick}
sidebarIsOpen={open}
dense={dense}
@@ -70,8 +77,9 @@ const Menu = ({ onMenuClick, dense, logout }) => {
<MenuItemLink
key={albumListAddress}
to={albumListAddress}
activeClassName={classes.active}
primaryText={name}
leftIcon={(al.icon && createElement(al.icon)) || <ViewListIcon />}
leftIcon={al.icon || <ViewListIcon />}
onClick={onMenuClick}
sidebarIsOpen={open}
dense={dense}