Ignore invalid MBIDs (ex: discogs IDs)

2020-10-20 17:45:32 -04:00
parent 173dd52fe1
commit b5e20c1934
3 changed files with 70 additions and 29 deletions
@@ -6,7 +6,7 @@ import (
 )

 var _ = Describe("ffmpegMetadata", func() {
-	Context("parseYear", func() {
+	Describe("parseYear", func() {
 		It("parses the year correctly", func() {
 			var examples = map[string]int{
 				"1985":         1985,
@@ -31,4 +31,33 @@ var _ = Describe("ffmpegMetadata", func() {
 			Expect(md.Year()).To(Equal(0))
 		})
 	})
+
+	Describe("getMbzID", func() {
+		It("return a valid MBID", func() {
+			md := &baseMetadata{}
+			md.tags = map[string]string{
+				"musicbrainz_trackid":       "8f84da07-09a0-477b-b216-cc982dabcde1",
+				"musicbrainz_albumid":       "f68c985d-f18b-4f4a-b7f0-87837cf3fbf9",
+				"musicbrainz_artistid":      "89ad4ac3-39f7-470e-963a-56509c546377",
+				"musicbrainz_albumartistid": "ada7a83c-e3e1-40f1-93f9-3e73dbc9298a",
+			}
+			Expect(md.MbzTrackID()).To(Equal("8f84da07-09a0-477b-b216-cc982dabcde1"))
+			Expect(md.MbzAlbumID()).To(Equal("f68c985d-f18b-4f4a-b7f0-87837cf3fbf9"))
+			Expect(md.MbzArtistID()).To(Equal("89ad4ac3-39f7-470e-963a-56509c546377"))
+			Expect(md.MbzAlbumArtistID()).To(Equal("ada7a83c-e3e1-40f1-93f9-3e73dbc9298a"))
+		})
+		It("return empty string for invalid MBID", func() {
+			md := &baseMetadata{}
+			md.tags = map[string]string{
+				"musicbrainz_trackid":       "11406732-6",
+				"musicbrainz_albumid":       "11406732",
+				"musicbrainz_artistid":      "200455",
+				"musicbrainz_albumartistid": "194",
+			}
+			Expect(md.MbzTrackID()).To(Equal(""))
+			Expect(md.MbzAlbumID()).To(Equal(""))
+			Expect(md.MbzArtistID()).To(Equal(""))
+			Expect(md.MbzAlbumArtistID()).To(Equal(""))
+		})
+	})
 })