Fix null values in DB (#2840)

* Fix album image_files being null. * Fix small nitpick. * Use ExecContext instead of Exec. * Change more columns to not null and set default values. * Remove columns that don't need to be changed from migration. * Fix typo. * Remove unnecessary select statements. * Remove duplicate code. * Do not apply changes to radio table. * Do not apply changes full_text columns and respective indexes. * Fix musicbrainz columns. * Rename migration. * Make ExternalInfoUpdatedAt nullable * Make Share's timestamps nullable --------- Co-authored-by: Deluan Quintão <deluan@navidrome.org>
2024-02-07 17:45:08 -08:00
parent ac4ceab143
commit bf2bcb1279
11 changed files with 693 additions and 84 deletions
@@ -10,51 +10,51 @@ import (
 type Album struct {
 	Annotations `structs:"-"`

-	ID                    string    `structs:"id" json:"id"`
-	Name                  string    `structs:"name" json:"name"`
-	EmbedArtPath          string    `structs:"embed_art_path" json:"embedArtPath"`
-	ArtistID              string    `structs:"artist_id" json:"artistId"`
-	Artist                string    `structs:"artist" json:"artist"`
-	AlbumArtistID         string    `structs:"album_artist_id" json:"albumArtistId"`
-	AlbumArtist           string    `structs:"album_artist" json:"albumArtist"`
-	AllArtistIDs          string    `structs:"all_artist_ids" json:"allArtistIds"`
-	MaxYear               int       `structs:"max_year" json:"maxYear"`
-	MinYear               int       `structs:"min_year" json:"minYear"`
-	Date                  string    `structs:"date" json:"date,omitempty"`
-	MaxOriginalYear       int       `structs:"max_original_year" json:"maxOriginalYear"`
-	MinOriginalYear       int       `structs:"min_original_year" json:"minOriginalYear"`
-	OriginalDate          string    `structs:"original_date" json:"originalDate,omitempty"`
-	ReleaseDate           string    `structs:"release_date" json:"releaseDate,omitempty"`
-	Releases              int       `structs:"releases" json:"releases"`
-	Compilation           bool      `structs:"compilation" json:"compilation"`
-	Comment               string    `structs:"comment" json:"comment,omitempty"`
-	SongCount             int       `structs:"song_count" json:"songCount"`
-	Duration              float32   `structs:"duration" json:"duration"`
-	Size                  int64     `structs:"size" json:"size"`
-	Genre                 string    `structs:"genre" json:"genre"`
-	Genres                Genres    `structs:"-" json:"genres"`
-	Discs                 Discs     `structs:"discs" json:"discs,omitempty"`
-	FullText              string    `structs:"full_text" json:"fullText"`
-	SortAlbumName         string    `structs:"sort_album_name" json:"sortAlbumName,omitempty"`
-	SortArtistName        string    `structs:"sort_artist_name" json:"sortArtistName,omitempty"`
-	SortAlbumArtistName   string    `structs:"sort_album_artist_name" json:"sortAlbumArtistName,omitempty"`
-	OrderAlbumName        string    `structs:"order_album_name" json:"orderAlbumName"`
-	OrderAlbumArtistName  string    `structs:"order_album_artist_name" json:"orderAlbumArtistName"`
-	CatalogNum            string    `structs:"catalog_num" json:"catalogNum,omitempty"`
-	MbzAlbumID            string    `structs:"mbz_album_id" json:"mbzAlbumId,omitempty"`
-	MbzAlbumArtistID      string    `structs:"mbz_album_artist_id" json:"mbzAlbumArtistId,omitempty"`
-	MbzAlbumType          string    `structs:"mbz_album_type" json:"mbzAlbumType,omitempty"`
-	MbzAlbumComment       string    `structs:"mbz_album_comment" json:"mbzAlbumComment,omitempty"`
-	ImageFiles            string    `structs:"image_files" json:"imageFiles,omitempty"`
-	Paths                 string    `structs:"paths" json:"paths,omitempty"`
-	Description           string    `structs:"description" json:"description,omitempty"`
-	SmallImageUrl         string    `structs:"small_image_url" json:"smallImageUrl,omitempty"`
-	MediumImageUrl        string    `structs:"medium_image_url" json:"mediumImageUrl,omitempty"`
-	LargeImageUrl         string    `structs:"large_image_url" json:"largeImageUrl,omitempty"`
-	ExternalUrl           string    `structs:"external_url" json:"externalUrl,omitempty"`
-	ExternalInfoUpdatedAt time.Time `structs:"external_info_updated_at" json:"externalInfoUpdatedAt"`
-	CreatedAt             time.Time `structs:"created_at" json:"createdAt"`
-	UpdatedAt             time.Time `structs:"updated_at" json:"updatedAt"`
+	ID                    string     `structs:"id" json:"id"`
+	Name                  string     `structs:"name" json:"name"`
+	EmbedArtPath          string     `structs:"embed_art_path" json:"embedArtPath"`
+	ArtistID              string     `structs:"artist_id" json:"artistId"`
+	Artist                string     `structs:"artist" json:"artist"`
+	AlbumArtistID         string     `structs:"album_artist_id" json:"albumArtistId"`
+	AlbumArtist           string     `structs:"album_artist" json:"albumArtist"`
+	AllArtistIDs          string     `structs:"all_artist_ids" json:"allArtistIds"`
+	MaxYear               int        `structs:"max_year" json:"maxYear"`
+	MinYear               int        `structs:"min_year" json:"minYear"`
+	Date                  string     `structs:"date" json:"date,omitempty"`
+	MaxOriginalYear       int        `structs:"max_original_year" json:"maxOriginalYear"`
+	MinOriginalYear       int        `structs:"min_original_year" json:"minOriginalYear"`
+	OriginalDate          string     `structs:"original_date" json:"originalDate,omitempty"`
+	ReleaseDate           string     `structs:"release_date" json:"releaseDate,omitempty"`
+	Releases              int        `structs:"releases" json:"releases"`
+	Compilation           bool       `structs:"compilation" json:"compilation"`
+	Comment               string     `structs:"comment" json:"comment,omitempty"`
+	SongCount             int        `structs:"song_count" json:"songCount"`
+	Duration              float32    `structs:"duration" json:"duration"`
+	Size                  int64      `structs:"size" json:"size"`
+	Genre                 string     `structs:"genre" json:"genre"`
+	Genres                Genres     `structs:"-" json:"genres"`
+	Discs                 Discs      `structs:"discs" json:"discs,omitempty"`
+	FullText              string     `structs:"full_text" json:"fullText"`
+	SortAlbumName         string     `structs:"sort_album_name" json:"sortAlbumName,omitempty"`
+	SortArtistName        string     `structs:"sort_artist_name" json:"sortArtistName,omitempty"`
+	SortAlbumArtistName   string     `structs:"sort_album_artist_name" json:"sortAlbumArtistName,omitempty"`
+	OrderAlbumName        string     `structs:"order_album_name" json:"orderAlbumName"`
+	OrderAlbumArtistName  string     `structs:"order_album_artist_name" json:"orderAlbumArtistName"`
+	CatalogNum            string     `structs:"catalog_num" json:"catalogNum,omitempty"`
+	MbzAlbumID            string     `structs:"mbz_album_id" json:"mbzAlbumId,omitempty"`
+	MbzAlbumArtistID      string     `structs:"mbz_album_artist_id" json:"mbzAlbumArtistId,omitempty"`
+	MbzAlbumType          string     `structs:"mbz_album_type" json:"mbzAlbumType,omitempty"`
+	MbzAlbumComment       string     `structs:"mbz_album_comment" json:"mbzAlbumComment,omitempty"`
+	ImageFiles            string     `structs:"image_files" json:"imageFiles,omitempty"`
+	Paths                 string     `structs:"paths" json:"paths,omitempty"`
+	Description           string     `structs:"description" json:"description,omitempty"`
+	SmallImageUrl         string     `structs:"small_image_url" json:"smallImageUrl,omitempty"`
+	MediumImageUrl        string     `structs:"medium_image_url" json:"mediumImageUrl,omitempty"`
+	LargeImageUrl         string     `structs:"large_image_url" json:"largeImageUrl,omitempty"`
+	ExternalUrl           string     `structs:"external_url" json:"externalUrl,omitempty"`
+	ExternalInfoUpdatedAt *time.Time `structs:"external_info_updated_at" json:"externalInfoUpdatedAt"`
+	CreatedAt             time.Time  `structs:"created_at" json:"createdAt"`
+	UpdatedAt             time.Time  `structs:"updated_at" json:"updatedAt"`
 }

 func (a Album) CoverArtID() ArtworkID {
@@ -5,23 +5,23 @@ import "time"
 type Artist struct {
 	Annotations `structs:"-"`

-	ID                    string    `structs:"id" json:"id"`
-	Name                  string    `structs:"name" json:"name"`
-	AlbumCount            int       `structs:"album_count" json:"albumCount"`
-	SongCount             int       `structs:"song_count" json:"songCount"`
-	Genres                Genres    `structs:"-" json:"genres"`
-	FullText              string    `structs:"full_text" json:"fullText"`
-	SortArtistName        string    `structs:"sort_artist_name" json:"sortArtistName,omitempty"`
-	OrderArtistName       string    `structs:"order_artist_name" json:"orderArtistName"`
-	Size                  int64     `structs:"size" json:"size"`
-	MbzArtistID           string    `structs:"mbz_artist_id" json:"mbzArtistId,omitempty"`
-	Biography             string    `structs:"biography" json:"biography,omitempty"`
-	SmallImageUrl         string    `structs:"small_image_url" json:"smallImageUrl,omitempty"`
-	MediumImageUrl        string    `structs:"medium_image_url" json:"mediumImageUrl,omitempty"`
-	LargeImageUrl         string    `structs:"large_image_url" json:"largeImageUrl,omitempty"`
-	ExternalUrl           string    `structs:"external_url" json:"externalUrl,omitempty"`
-	SimilarArtists        Artists   `structs:"similar_artists"  json:"-"`
-	ExternalInfoUpdatedAt time.Time `structs:"external_info_updated_at" json:"externalInfoUpdatedAt"`
+	ID                    string     `structs:"id" json:"id"`
+	Name                  string     `structs:"name" json:"name"`
+	AlbumCount            int        `structs:"album_count" json:"albumCount"`
+	SongCount             int        `structs:"song_count" json:"songCount"`
+	Genres                Genres     `structs:"-" json:"genres"`
+	FullText              string     `structs:"full_text" json:"fullText"`
+	SortArtistName        string     `structs:"sort_artist_name" json:"sortArtistName,omitempty"`
+	OrderArtistName       string     `structs:"order_artist_name" json:"orderArtistName"`
+	Size                  int64      `structs:"size" json:"size"`
+	MbzArtistID           string     `structs:"mbz_artist_id" json:"mbzArtistId,omitempty"`
+	Biography             string     `structs:"biography" json:"biography,omitempty"`
+	SmallImageUrl         string     `structs:"small_image_url" json:"smallImageUrl,omitempty"`
+	MediumImageUrl        string     `structs:"medium_image_url" json:"mediumImageUrl,omitempty"`
+	LargeImageUrl         string     `structs:"large_image_url" json:"largeImageUrl,omitempty"`
+	ExternalUrl           string     `structs:"external_url" json:"externalUrl,omitempty"`
+	SimilarArtists        Artists    `structs:"similar_artists"  json:"-"`
+	ExternalInfoUpdatedAt *time.Time `structs:"external_info_updated_at" json:"externalInfoUpdatedAt"`
 }

 func (a Artist) ArtistImageUrl() string {
@@ -13,8 +13,8 @@ type Share struct {
 	Username      string     `structs:"-" json:"username,omitempty"`
 	Description   string     `structs:"description" json:"description,omitempty"`
 	Downloadable  bool       `structs:"downloadable" json:"downloadable"`
-	ExpiresAt     time.Time  `structs:"expires_at" json:"expiresAt,omitempty"`
-	LastVisitedAt time.Time  `structs:"last_visited_at" json:"lastVisitedAt,omitempty"`
+	ExpiresAt     *time.Time `structs:"expires_at" json:"expiresAt,omitempty"`
+	LastVisitedAt *time.Time `structs:"last_visited_at" json:"lastVisitedAt,omitempty"`
 	ResourceIDs   string     `structs:"resource_ids" json:"resourceIds,omitempty"`
 	ResourceType  string     `structs:"resource_type" json:"resourceType,omitempty"`
 	Contents      string     `structs:"contents" json:"contents,omitempty"`