Return 404 when artwork is not available in /share/img endpoint

core/artwork/artwork_test.go

@@ -28,20 +28,30 @@ var _ = Describe("Artwork", func() {
 		aw = artwork.NewArtwork(ds, cache, ffmpeg, nil)
 	})
 
-	Context("Empty ID", func() {
-		It("returns placeholder if album is not in the DB", func() {
-			r, _, err := aw.Get(context.Background(), "", 0)
-			Expect(err).ToNot(HaveOccurred())
+	Context("GetOrPlaceholder", func() {
+		Context("Empty ID", func() {
+			It("returns placeholder if album is not in the DB", func() {
+				r, _, err := aw.GetOrPlaceholder(context.Background(), "", 0)
+				Expect(err).ToNot(HaveOccurred())
 
-			ph, err := resources.FS().Open(consts.PlaceholderAlbumArt)
-			Expect(err).ToNot(HaveOccurred())
-			phBytes, err := io.ReadAll(ph)
-			Expect(err).ToNot(HaveOccurred())
+				ph, err := resources.FS().Open(consts.PlaceholderAlbumArt)
+				Expect(err).ToNot(HaveOccurred())
+				phBytes, err := io.ReadAll(ph)
+				Expect(err).ToNot(HaveOccurred())
 
-			result, err := io.ReadAll(r)
-			Expect(err).ToNot(HaveOccurred())
+				result, err := io.ReadAll(r)
+				Expect(err).ToNot(HaveOccurred())
 
-			Expect(result).To(Equal(phBytes))
+				Expect(result).To(Equal(phBytes))
+			})
+		})
+	})
+	Context("Get", func() {
+		Context("Empty ID", func() {
+			It("returns an ErrUnavailable error", func() {
+				_, _, err := aw.Get(context.Background(), model.ArtworkID{}, 0)
+				Expect(err).To(MatchError(artwork.ErrUnavailable))
+			})
 		})
 	})
 })