Return 404 when artwork is not available in /share/img endpoint

server/public/handle_images.go

@@ -7,6 +7,7 @@ import (
 	"net/http"
 	"time"
 
+	"github.com/navidrome/navidrome/core/artwork"
 	"github.com/navidrome/navidrome/log"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/utils"
@@ -28,13 +29,17 @@ func (p *Router) handleImages(w http.ResponseWriter, r *http.Request) {
 	}
 
 	size := utils.ParamInt(r, "size", 0)
-	imgReader, lastUpdate, err := p.artwork.Get(ctx, artId.String(), size)
+	imgReader, lastUpdate, err := p.artwork.Get(ctx, artId, size)
 
 	switch {
 	case errors.Is(err, context.Canceled):
 		return
 	case errors.Is(err, model.ErrNotFound):
-		log.Error(r, "Couldn't find coverArt", "id", id, err)
+		log.Warn(r, "Couldn't find coverArt", "id", id, err)
+		http.Error(w, "Artwork not found", http.StatusNotFound)
+		return
+	case errors.Is(err, artwork.ErrUnavailable):
+		log.Debug(r, "Item does not have artwork", "id", id, err)
 		http.Error(w, "Artwork not found", http.StatusNotFound)
 		return
 	case err != nil: