Allow cache image to be disabled (workaround for #177)

2020-04-14 19:15:47 -04:00
parent 66275d3b94
commit db4479e720
5 changed files with 116 additions and 76 deletions
@@ -20,86 +20,106 @@ var _ = Describe("Cover", func() {
 		ds = &persistence.MockDataStore{MockedTranscoding: &mockTranscodingRepository{}}
 		ds.Album(ctx).(*persistence.MockAlbum).SetData(`[{"id": "222", "coverArtId": "123"}, {"id": "333", "coverArtId": ""}]`)
 		ds.MediaFile(ctx).(*persistence.MockMediaFile).SetData(`[{"id": "123", "path": "tests/fixtures/test.mp3", "hasCoverArt": true, "updatedAt":"2020-04-02T21:29:31.6377Z"}]`)
-		cover = NewCover(ds, testCache)
 	})

-	It("retrieves the original cover art from an album", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "222", 0, buf)).To(BeNil())
-
-		_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("jpeg"))
-	})
-
-	It("accepts albumIds with 'al-' prefix", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "al-222", 0, buf)).To(BeNil())
-
-		_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("jpeg"))
-	})
-
-	It("returns the default cover if album does not have cover", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "333", 0, buf)).To(BeNil())
-
-		_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("png"))
-	})
-
-	It("returns the default cover if album is not found", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "444", 0, buf)).To(BeNil())
-
-		_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("png"))
-	})
-
-	It("retrieves the original cover art from a media_file", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "123", 0, buf)).To(BeNil())
-
-		img, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("jpeg"))
-		Expect(img.Bounds().Size().X).To(Equal(600))
-		Expect(img.Bounds().Size().Y).To(Equal(600))
-	})
-
-	It("resized cover art as requested", func() {
-		buf := new(bytes.Buffer)
-
-		Expect(cover.Get(ctx, "123", 200, buf)).To(BeNil())
-
-		img, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
-		Expect(err).To(BeNil())
-		Expect(format).To(Equal("jpeg"))
-		Expect(img.Bounds().Size().X).To(Equal(200))
-		Expect(img.Bounds().Size().Y).To(Equal(200))
-	})
-
-	Context("Errors", func() {
-		It("returns err if gets error from album table", func() {
-			ds.Album(ctx).(*persistence.MockAlbum).SetError(true)
-			buf := new(bytes.Buffer)
-
-			Expect(cover.Get(ctx, "222", 0, buf)).To(MatchError("Error!"))
+	Context("Cache is configured", func() {
+		BeforeEach(func() {
+			cover = NewCover(ds, testCache)
 		})

-		It("returns err if gets error from media_file table", func() {
-			ds.MediaFile(ctx).(*persistence.MockMediaFile).SetError(true)
+		It("retrieves the original cover art from an album", func() {
 			buf := new(bytes.Buffer)

-			Expect(cover.Get(ctx, "123", 0, buf)).To(MatchError("Error!"))
+			Expect(cover.Get(ctx, "222", 0, buf)).To(BeNil())
+
+			_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("jpeg"))
+		})
+
+		It("accepts albumIds with 'al-' prefix", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "al-222", 0, buf)).To(BeNil())
+
+			_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("jpeg"))
+		})
+
+		It("returns the default cover if album does not have cover", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "333", 0, buf)).To(BeNil())
+
+			_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("png"))
+		})
+
+		It("returns the default cover if album is not found", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "444", 0, buf)).To(BeNil())
+
+			_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("png"))
+		})
+
+		It("retrieves the original cover art from a media_file", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "123", 0, buf)).To(BeNil())
+
+			img, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("jpeg"))
+			Expect(img.Bounds().Size().X).To(Equal(600))
+			Expect(img.Bounds().Size().Y).To(Equal(600))
+		})
+
+		It("resized cover art as requested", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "123", 200, buf)).To(BeNil())
+
+			img, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("jpeg"))
+			Expect(img.Bounds().Size().X).To(Equal(200))
+			Expect(img.Bounds().Size().Y).To(Equal(200))
+		})
+
+		Context("Errors", func() {
+			It("returns err if gets error from album table", func() {
+				ds.Album(ctx).(*persistence.MockAlbum).SetError(true)
+				buf := new(bytes.Buffer)
+
+				Expect(cover.Get(ctx, "222", 0, buf)).To(MatchError("Error!"))
+			})
+
+			It("returns err if gets error from media_file table", func() {
+				ds.MediaFile(ctx).(*persistence.MockMediaFile).SetError(true)
+				buf := new(bytes.Buffer)
+
+				Expect(cover.Get(ctx, "123", 0, buf)).To(MatchError("Error!"))
+			})
+		})
+	})
+	Context("Cache is NOT configured", func() {
+		BeforeEach(func() {
+			cover = NewCover(ds, nil)
+		})
+
+		It("retrieves the original cover art from an album", func() {
+			buf := new(bytes.Buffer)
+
+			Expect(cover.Get(ctx, "222", 0, buf)).To(BeNil())
+
+			_, format, err := image.Decode(bytes.NewReader(buf.Bytes()))
+			Expect(err).To(BeNil())
+			Expect(format).To(Equal("jpeg"))
 		})
 	})
 })