Move artwork id encoding to public package

core/artwork/artwork_test.go

@@ -4,12 +4,10 @@ import (
 	"context"
 	"io"
 
-	"github.com/go-chi/jwtauth/v5"
 	"github.com/navidrome/navidrome/conf"
 	"github.com/navidrome/navidrome/conf/configtest"
 	"github.com/navidrome/navidrome/consts"
 	"github.com/navidrome/navidrome/core/artwork"
-	"github.com/navidrome/navidrome/core/auth"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/resources"
 	"github.com/navidrome/navidrome/tests"
@@ -46,31 +44,4 @@ var _ = Describe("Artwork", func() {
 			Expect(result).To(Equal(phBytes))
 		})
 	})
-
-	Context("Public ID Encoding", func() {
-		BeforeEach(func() {
-			auth.TokenAuth = jwtauth.New("HS256", []byte("super secret"), nil)
-		})
-		It("returns a reversible string representation", func() {
-			id := model.NewArtworkID(model.KindArtistArtwork, "1234")
-			encoded := artwork.EncodeArtworkID(id)
-			decoded, err := artwork.DecodeArtworkID(encoded)
-			Expect(err).ToNot(HaveOccurred())
-			Expect(decoded).To(Equal(id))
-		})
-		It("fails to decode an invalid token", func() {
-			_, err := artwork.DecodeArtworkID("xx-123")
-			Expect(err).To(MatchError("invalid JWT"))
-		})
-		It("fails to decode an invalid id", func() {
-			encoded := artwork.EncodeArtworkID(model.ArtworkID{})
-			_, err := artwork.DecodeArtworkID(encoded)
-			Expect(err).To(MatchError("invalid artwork id"))
-		})
-		It("fails to decode a token without an id", func() {
-			token, _ := auth.CreatePublicToken(map[string]any{})
-			_, err := artwork.DecodeArtworkID(token)
-			Expect(err).To(HaveOccurred())
-		})
-	})
 })