897de02a84e020d6ddefc4e1f426e375dd3aed51
156
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Deluan QuintãoandGitHub
|
2de2484bca |
feat: add go-taglib pure Go metadata extractor (#4902)
* feat: implement go-taglib extractor Signed-off-by: Deluan <[email protected]> * feat: enhance ID3v2 frame parsing for language-specific lyrics Signed-off-by: Deluan <[email protected]> * feat: add support for reading iTunes-specific tags from M4A files Signed-off-by: Deluan <[email protected]> * feat: expose BitDepth in AudioProperties struct Signed-off-by: Deluan <[email protected]> * feat: enhance WMA tag parsing by adding support for ASF attributes Signed-off-by: Deluan <[email protected]> * feat: enhance ID3v2 frame parsing for WAV and AIFF formats to support language codes Signed-off-by: Deluan <[email protected]> * chore: usa a ignored go.work for local dependency management * feat: optimize metadata extraction by consolidating file reads and improving tag processing Signed-off-by: Deluan <[email protected]> * remove comment Signed-off-by: Deluan <[email protected]> * feat: improve language code extraction for lyrics tags in metadata processing Signed-off-by: Deluan <[email protected]> * address PR comments Signed-off-by: Deluan <[email protected]> * chore: remove outdated comments in gotaglib.go Signed-off-by: Deluan <[email protected]> * feat: enhance extractor to utilize filesystem for file handling Signed-off-by: Deluan <[email protected]> * chore: update go-taglib dependency version in go.mod and go.sum Signed-off-by: Deluan <[email protected]> * feat: make new go-taglib extractor default Signed-off-by: Deluan <[email protected]> * chore: formatting Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
7b9bc1c5ac |
refactor: move agent files to adapters for consistency
Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
03a45753e9 |
feat(plugins): New Plugin System with multi-language PDK support (#4833)
* chore(plugins): remove the old plugins system implementation Signed-off-by: Deluan <[email protected]> * feat(plugins): implement new plugin system with using Extism Signed-off-by: Deluan <[email protected]> * feat(plugins): add capability detection for plugins based on exported functions Signed-off-by: Deluan <[email protected]> * feat(plugins): add auto-reload functionality for plugins with file watcher support Signed-off-by: Deluan <[email protected]> * feat(plugins): add auto-reload functionality for plugins with file watcher support Signed-off-by: Deluan <[email protected]> * refactor(plugins): standardize variable names and remove superfluous wrapper functions Signed-off-by: Deluan <[email protected]> * fix(plugins): improve error handling and logging in plugin manager Signed-off-by: Deluan <[email protected]> * refactor(plugins): implement plugin function call helper and refactor MetadataAgent methods Signed-off-by: Deluan <[email protected]> * fix(plugins): race condition in plugin manager * tests(plugins): change BeforeEach to BeforeAll in MetadataAgent tests Signed-off-by: Deluan <[email protected]> * tests(plugins): optimize tests Signed-off-by: Deluan <[email protected]> * tests(plugins): more optimizations Signed-off-by: Deluan <[email protected]> * test(plugins): ignore goroutine leaks from notify library in tests Signed-off-by: Deluan <[email protected]> * feat(plugins): add Wikimedia plugin for Navidrome to fetch artist metadata Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance plugin logging and set User-Agent header Signed-off-by: Deluan <[email protected]> * feat(plugins): implement scrobbler plugin with authorization and scrobbling capabilities Signed-off-by: Deluan <[email protected]> * feat(plugins): integrate logs Signed-off-by: Deluan <[email protected]> * refactor(plugins): clean up manifest struct and improve plugin loading logic Signed-off-by: Deluan <[email protected]> * feat(plugins): add metadata agent and scrobbler schemas for bootstrapping plugins Signed-off-by: Deluan <[email protected]> * feat(hostgen): add hostgen tool for generating Extism host function wrappers - Implemented hostgen tool to generate wrappers from annotated Go interfaces. - Added command-line flags for input/output directories and package name. - Introduced parsing and code generation logic for host services. - Created test data for various service interfaces and expected generated code. - Added documentation for host services and annotations for code generation. - Implemented SubsonicAPI service with corresponding generated code. * feat(subsonicapi): update Call method to return JSON string response Signed-off-by: Deluan <[email protected]> * feat(plugins): implement SubsonicAPI host function integration with permissions Signed-off-by: Deluan <[email protected]> * fix(generator): error-only methods in response handling Signed-off-by: Deluan <[email protected]> * feat(plugins): generate client wrappers for host functions Signed-off-by: Deluan <[email protected]> * refactor(generator): remove error handling for response.Error in client templates Signed-off-by: Deluan <[email protected]> * feat(scheduler): add Scheduler service interface with host function wrappers for scheduling tasks * feat(plugins): add WASI build constraints to client wrapper templates, to avoid lint errors Signed-off-by: Deluan <[email protected]> * feat(scheduler): implement Scheduler service with one-time and recurring scheduling capabilities Signed-off-by: Deluan <[email protected]> * refactor(manifest): remove unused ConfigPermission from permissions schema Signed-off-by: Deluan <[email protected]> * feat(scheduler): add scheduler callback schema and implementation for plugins Signed-off-by: Deluan <[email protected]> * refactor(scheduler): streamline scheduling logic and remove unused callback tracking Signed-off-by: Deluan <[email protected]> * refactor(scheduler): add Close method for resource cleanup on plugin unload Signed-off-by: Deluan <[email protected]> * docs(scheduler): clarify SchedulerCallback requirement for scheduling functions Signed-off-by: Deluan <[email protected]> * fix: update wasm build rule to include all Go files in the directory Signed-off-by: Deluan <[email protected]> * feat: rewrite the wikimedia plugin using the XTP CLI Signed-off-by: Deluan <[email protected]> * refactor(scheduler): replace uuid with id.NewRandom for schedule ID generation Signed-off-by: Deluan <[email protected]> * refactor: capabilities registration Signed-off-by: Deluan <[email protected]> * test: add scheduler service isolation test for plugin instances Signed-off-by: Deluan <[email protected]> * refactor: update plugin manager initialization and encapsulate logic Signed-off-by: Deluan <[email protected]> * feat: add WebSocket service definitions for plugin communication Signed-off-by: Deluan <[email protected]> * feat: implement WebSocket service for plugin integration and connection management Signed-off-by: Deluan <[email protected]> * feat: add Crypto Ticker example plugin for real-time cryptocurrency price updates via Coinbase WebSocket API Also add the lifecycle capability Signed-off-by: Deluan <[email protected]> * fix: use context.Background() in invokeCallback for scheduled tasks Signed-off-by: Deluan <[email protected]> * refactor: rename plugin.create() to plugin.instance() Signed-off-by: Deluan <[email protected]> * refactor: rename pluginInstance to plugin for consistency across the codebase Signed-off-by: Deluan <[email protected]> * refactor: simplify schedule cloning in Close method and enhance plugin cleanup error handling Signed-off-by: Deluan <[email protected]> * feat: implement Artwork service for generating artwork URLs in Navidrome plugins - WIP Signed-off-by: Deluan <[email protected]> * refactor: moved public URL builders to avoid import cycles Signed-off-by: Deluan <[email protected]> * feat: add Cache service for in-memory TTL-based caching in plugins Signed-off-by: Deluan <[email protected]> * feat: add Discord Rich Presence example plugin for Navidrome integration Signed-off-by: Deluan <[email protected]> * refactor: host function wrappers to use structured request and response types - Updated the host function signatures in `nd_host_artwork.go`, `nd_host_scheduler.go`, `nd_host_subsonicapi.go`, and `nd_host_websocket.go` to accept a single parameter for JSON requests. - Introduced structured request and response types for various cache operations in `nd_host_cache.go`. - Modified cache functions to marshal requests to JSON and unmarshal responses, improving error handling and code clarity. - Removed redundant memory allocation for string parameters in favor of JSON marshaling. - Enhanced error handling in WebSocket and cache operations to return structured error responses. * refactor: error handling in various plugins to convert response.Error to Go errors - Updated error handling in `nd_host_scheduler.go`, `nd_host_websocket.go`, `nd_host_artwork.go`, `nd_host_cache.go`, and `nd_host_subsonicapi.go` to convert string errors from responses into Go errors. - Removed redundant error checks in test data plugins for cleaner code. - Ensured consistent error handling across all plugins to improve reliability and maintainability. * refactor: rename fake plugins to test plugins for clarity in integration tests Signed-off-by: Deluan <[email protected]> * feat: add help target to Makefile for plugin usage instructions Signed-off-by: Deluan <[email protected]> * feat: add Cover Art Archive plugin as an example of Python plugin Signed-off-by: Deluan <[email protected]> * feat: update Makefile and README to clarify Go plugin usage Signed-off-by: Deluan <[email protected]> * feat: include plugin capabilities in loading log message Signed-off-by: Deluan <[email protected]> * feat: add trace logging for plugin availability and error handling in agents Signed-off-by: Deluan <[email protected]> * feat: add Now Playing Logger plugin to showcase calling host functions from Python plugins Signed-off-by: Deluan <[email protected]> * feat: generate Python client wrappers for various host services Signed-off-by: Deluan <[email protected]> * feat: add generated host function wrappers for Scheduler and SubsonicAPI services Signed-off-by: Deluan <[email protected]> * feat: update Python plugin documentation and usage instructions for host function wrappers Signed-off-by: Deluan <[email protected]> * feat: add Webhook Scrobbler plugin in Rust to send HTTP notifications on scrobble events Signed-off-by: Deluan <[email protected]> * feat: enable parallel loading of plugins during startup Signed-off-by: Deluan <[email protected]> * docs: update README to include WebSocket callback schema in plugin documentation Signed-off-by: Deluan <[email protected]> * feat: extend plugin watcher with improved logging and debounce duration adjustment Signed-off-by: Deluan <[email protected]> * add trace message for plugin recompiles Signed-off-by: Deluan <[email protected]> * feat: implement plugin cache purging functionality Signed-off-by: Deluan <[email protected]> * test: move purgeCacheBySize unit tests Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add plugin repository and database support Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add plugin management routes and middleware Signed-off-by: Deluan <[email protected]> * feat(plugins UI): implement plugin synchronization with database for add, update, and remove actions Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add PluginList and PluginShow components with plugin management functionality Signed-off-by: Deluan <[email protected]> * feat(plugins): optimize plugin change detection Signed-off-by: Deluan <[email protected]> * refactor(plugins UI): improve PluginList structure Signed-off-by: Deluan <[email protected]> * feat(plugins UI): enhance PluginShow with author, website, and permissions display Signed-off-by: Deluan <[email protected]> * feat(plugins UI): refactor to use MUI and RA components Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add error handling for plugin enable/disable actions Signed-off-by: Deluan <[email protected]> * refactor(plugins): inject PluginManager into native API Signed-off-by: Deluan <[email protected]> * refactor(plugins): update GetManager to accept DataStore parameter Signed-off-by: Deluan <[email protected]> * feat(plugins): add subsonicRouter to Manager and refactor host service registration Signed-off-by: Deluan <[email protected]> * refactor(plugins): enhance debug logging for plugin actions and recompile logic Signed-off-by: Deluan <[email protected]> * refactor(plugins): break manager.go into smaller, focused files Signed-off-by: Deluan <[email protected]> * refactor(plugins): streamline error handling and improve plugin retrieval logic Signed-off-by: Deluan <[email protected]> * refactor(plugins): update newWebSocketService to use WebSocketPermission for allowed hosts Signed-off-by: Deluan <[email protected]> * refactor(plugins): introduce ToggleEnabledSwitch for managing plugin enable/disable state Signed-off-by: Deluan <[email protected]> * docs: update READMEs Signed-off-by: Deluan <[email protected]> * feat(library): add Library service for metadata access and filesystem integration Signed-off-by: Deluan <[email protected]> * feat(plugins): add Library Inspector plugin for periodic library inspection and file size logging Signed-off-by: Deluan <[email protected]> * docs: update README to reflect JSON configuration format for plugins Signed-off-by: Deluan <[email protected]> * fix(build): update target to wasm32-wasip1 for improved WASI support Signed-off-by: Deluan <[email protected]> * feat(plugins): implement configuration management UI with key-value pairs support Signed-off-by: Deluan <[email protected]> * feat(ui): adjust grid layout in InfoRow component for improved responsiveness Signed-off-by: Deluan <[email protected]> * feat(plugins): rename ErrorIndicator to EnabledOrErrorField and enhance error handling logic Signed-off-by: Deluan <[email protected]> * feat(i18n): add Portuguese translations for plugin management and notifications Signed-off-by: Deluan <[email protected]> * feat(plugins): add support for .ndp plugin packages and update build process Signed-off-by: Deluan <[email protected]> * docs: update README for .ndp plugin packaging and installation instructions Signed-off-by: Deluan <[email protected]> * feat(plugins): implement KVStore service for persistent key-value storage Signed-off-by: Deluan <[email protected]> * docs: enhance README with Extism plugin development resources and recommendations Signed-off-by: Deluan <[email protected]> * feat(plugins): integrate event broker into plugin manager Signed-off-by: Deluan <[email protected]> * feat(plugins): update config handling in PluginShow to track last record state Signed-off-by: Deluan <[email protected]> * feat(plugins): add Rust host function library and example implementation of Discord Rich Presence plugin in Rust Signed-off-by: Deluan <[email protected]> * feat(plugins): generate Rust lib.rs file to expose host function wrappers Signed-off-by: Deluan <[email protected]> * refactor(plugins): update JSON field names to camelCase for consistency Signed-off-by: Deluan <[email protected]> * refactor: reduce cyclomatic complexity by refactoring main function Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance Rust code generation with typed struct support and improved type handling Signed-off-by: Deluan <[email protected]> * feat(plugins): add Go client library with host function wrappers and documentation Signed-off-by: Deluan <[email protected]> * feat(plugins): generate Go client stubs for non-WASM platforms Signed-off-by: Deluan <[email protected]> * feat(plugins): update client template file names for consistency Signed-off-by: Deluan <[email protected]> * feat(plugins): add initial implementation of the Navidrome Plugin Development Kit code generator - Pahse 1 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 2 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 2 (2) Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 3 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 4 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 5 Signed-off-by: Deluan <[email protected]> * refactor(plugins): consistent naming/types across PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): streamline plugin function signatures and error handling Signed-off-by: Deluan <[email protected]> * refactor(plugins): update scrobbler interface to return errors directly instead of response structs Signed-off-by: Deluan <[email protected]> * test: make all test plugins use the PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): reorganize and sort type definitions for consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): update error handling for methods to return errors directly Signed-off-by: Deluan <[email protected]> * refactor(plugins): update function signatures to return values directly instead of response structs Signed-off-by: Deluan <[email protected]> * refactor(plugins): update request/response types to use private naming conventions Signed-off-by: Deluan <[email protected]> * build: mark .wasm files as intermediate for cleanup after building .ndp Signed-off-by: Deluan <[email protected]> * refactor(plugins): consolidate PDK module path and update Go version to 1.25 Signed-off-by: Deluan <[email protected]> * feat: implement Rust PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): reorganize Rust output structure to follow standard conventions Signed-off-by: Deluan <[email protected]> * refactor(plugins): update Discord Rich Presence and Library Inspector plugins to use nd-pdk for service calls and implement lifecycle management Signed-off-by: Deluan <[email protected]> * refactor(plugins): update macro names for websocket and metadata registration to improve clarity and consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename scheduler callback methods for consistency and clarity Signed-off-by: Deluan <[email protected]> * refactor(plugins): update export wrappers to use `//go:wasmexport` for WebAssembly compatibility Signed-off-by: Deluan <[email protected]> * docs: update plugin registration docs Signed-off-by: Deluan <[email protected]> * fix(plugins): generate host wrappers Signed-off-by: Deluan <[email protected]> * test(plugins): conditionally run goleak checks based on CI environment Signed-off-by: Deluan <[email protected]> * docs: update README to reflect changes in plugin import paths Signed-off-by: Deluan <[email protected]> * refactor(plugins): update plugin instance creation to accept context for cancellation support Signed-off-by: Deluan <[email protected]> * fix(plugins): update return types in metadata interfaces to use pointers Signed-off-by: Deluan <[email protected]> * fix(plugins): enhance type handling for Rust and XTP output in capability generation Signed-off-by: Deluan <[email protected]> * fix(plugins): update IsAuthorized method to return boolean instead of response object Signed-off-by: Deluan <[email protected]> * test(plugins): add unit tests for rustOutputType and isPrimitiveRustType functions Signed-off-by: Deluan <[email protected]> * feat(plugins): implement XTP JSONSchema validation for generated schemas Signed-off-by: Deluan <[email protected]> * fix(plugins): update response types in testMetadataAgent methods to use pointers Signed-off-by: Deluan <[email protected]> * docs: update Go and Rust plugin developer sections for clarity Signed-off-by: Deluan <[email protected]> * docs: correct example link for library inspector in README Signed-off-by: Deluan <[email protected]> * docs: clarify artwork URL generation capabilities in service descriptions Signed-off-by: Deluan <[email protected]> * docs: update README to include Rust PDK crate information for plugin developers Signed-off-by: Deluan <[email protected]> * fix: handle URL parsing errors and use atomic upsert in plugin repository Added proper error handling for url.Parse calls in PublicURL and AbsoluteURL functions. When parsing fails, PublicURL now falls back to AbsoluteURL, and AbsoluteURL logs the error and returns an empty string, preventing malformed URLs from being generated. Replaced the non-atomic UPDATE-then-INSERT pattern in plugin repository Put method with a single atomic INSERT ... ON CONFLICT statement. This eliminates potential race conditions and improves consistency with the upsert pattern already used in host_kvstore.go. * feat: implement mock service instances for non-WASM builds using testify/mock Signed-off-by: Deluan <[email protected]> * refactor: Discord RPC struct to encapsulate WebSocket logic Signed-off-by: Deluan <[email protected]> * feat: add support for experimental WebAssembly threads Signed-off-by: Deluan <[email protected]> * feat: add PDK abstraction layer with mock support for non-WASM builds Signed-off-by: Deluan <[email protected]> * feat: add unit tests for Discord plugin and RPC functionality Signed-off-by: Deluan <[email protected]> * fix: update return types in minimalPlugin and wikimediaPlugin methods to use pointers Signed-off-by: Deluan <[email protected]> * fix: context cancellation and implement WebSocket callback timeout for improved error handling Signed-off-by: Deluan <[email protected]> * feat: conditionally include error handling in generated client code templates Signed-off-by: Deluan <[email protected]> * feat: implement ConfigService for plugin configuration management Signed-off-by: Deluan <[email protected]> * feat: enhance plugin manager to support metrics recording Signed-off-by: Deluan <[email protected]> * refactor: make MockPDK private Signed-off-by: Deluan <[email protected]> * refactor: update interface types to use 'any' in plugin repository methods Signed-off-by: Deluan <[email protected]> * refactor: rename List method to Keys for clarity in configuration management Signed-off-by: Deluan <[email protected]> * test: add ndpgen plugin tests in the pipeline and update Makefile Signed-off-by: Deluan <[email protected]> * feat: add users permission management to plugin system Signed-off-by: Deluan <[email protected]> * refactor: streamline users integration tests and enhance plugin user management Signed-off-by: Deluan <[email protected]> * refactor: remove UserID from scrobbler request structure Signed-off-by: Deluan <[email protected]> * test: add integration tests for UsersService enable gate behavior Signed-off-by: Deluan <[email protected]> * feat: implement user permissions for SubsonicAPI and scrobbler plugins Signed-off-by: Deluan <[email protected]> * fix: show proper error in the UI when enabling a plugin fails Signed-off-by: Deluan <[email protected]> * feat: add library permission management to plugin system Signed-off-by: Deluan <[email protected]> * feat: add user permission for processing scrobbles in Discord Rich Presence plugin Signed-off-by: Deluan <[email protected]> * fix: implement dynamic loading for buffered scrobbler plugins Signed-off-by: Deluan <[email protected]> * feat: add GetAdmins method to retrieve admin users from the plugin Signed-off-by: Deluan <[email protected]> * feat: update Portuguese translations for user and library permissions Signed-off-by: Deluan <[email protected]> * reorder migrations Signed-off-by: Deluan <[email protected]> * fix: remove unnecessary bulkActionButtons prop from PluginList component * feat: add manual plugin rescan functionality and corresponding UI action Signed-off-by: Deluan <[email protected]> * feat: implement user/library and plugin management integration with cleanup on deletion Signed-off-by: Deluan <[email protected]> * feat: replace core mock services with test-specific implementations to avoid import cycles * feat: add ID fields to Artist and Song structs and enhance track loading logic by prioritizing ID matches Signed-off-by: Deluan <[email protected]> * feat: update plugin permissions from allowedHosts to requiredHosts for better clarity and consistency * feat: refactor plugin host permissions to use RequiredHosts directly for improved clarity * fix: don't record metrics for plugin calls that aren't implemented at all Signed-off-by: Deluan <[email protected]> * fix: enhance connection management with improved error handling and cleanup logic Signed-off-by: Deluan <[email protected]> * feat: introduce ArtistRef struct for better artist representation and update track metadata handling Signed-off-by: Deluan <[email protected]> * feat: update user configuration handling to use user key prefix for improved clarity Signed-off-by: Deluan <[email protected]> * feat: enhance ConfigCard input fields with multiline support and vertical resizing Signed-off-by: Deluan <[email protected]> * fix: rust plugin compilation error Signed-off-by: Deluan <[email protected]> * feat: implement IsOptionPattern method for better return type handling in Rust PDK generation Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
9ed309ac81 |
feat(scanner): implement file-based target passing for large target lists
Signed-off-by: Deluan <[email protected]> |
||
|
|
eaf7795716 |
feat(cli): add user administration (#4754)
* feat(cli): add user administration * clean go.mod, address comments * fix lint, I hope * bump compilation timeoit in adapter_media_agent_test * address initial comments * feedback 2 * update user commands to use context to allow proper cancellation Signed-off-by: Deluan <[email protected]> * enforce admin user requirement in context for command execution Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
33d9ce6ecc |
feat: add configurable transcoding cancellation (#4411)
* feat: add configurable transcoding cancellation Implemented EnableTranscodingCancellation configuration option to control whether FFmpeg transcoding processes can be interrupted when client requests are cancelled. This addresses resource management issues on low-power hardware where transcoding processes would accumulate and cause CPU spikes. Key changes: - Added EnableTranscodingCancellation bool to configuration (default: false) - Added CLI flag --enabletranscodingcancellation and TOML/env support - Modified FFmpeg package to always use exec.CommandContext for consistency - Implemented conditional context handling in NewTranscodingCache function - When enabled: uses request context directly (allows cancellation) - When disabled: uses background context with request metadata preserved - Added comprehensive tests for both FFmpeg and transcoding layers - Maintained backward compatibility with existing behavior as default The implementation follows proper layered architecture with policy decisions at the media streaming layer and execution utilities remaining focused on their core responsibilities. Signed-off-by: Deluan <[email protected]> * test: refactor FFmpeg context cancellation tests for improved clarity and reliability Signed-off-by: Deluan <[email protected]> * test: reset FFmpeg initialization Signed-off-by: Deluan <[email protected]> * test: improve FFmpeg context cancellation tests for cross-platform compatibility Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
6a7381aa5a |
test: prevent environment variables from overriding config file values in tests
Added a loadEnvVars parameter to InitConfig to control whether environment variables should be loaded via viper.AutomaticEnv(). In tests, environment variables (like ND_MUSICFOLDER) were overriding values from config test files, causing tests to fail when these variables were set in the developer's environment. Now tests can pass loadEnvVars=false to isolate from the environment while production code continues to use loadEnvVars=true. Signed-off-by: Deluan <[email protected]> |
||
|
Kendall GarnerandGitHub
|
c40f12e65b | fix(scanner): Use repeated arg instead of comma split (#4727) | ||
|
|
28d5299ffc |
feat(scanner): implement selective folder scanning and file system watcher improvements (#4674)
* feat: Add selective folder scanning capability Implement targeted scanning of specific library/folder pairs without full recursion. This enables efficient rescanning of individual folders when changes are detected, significantly reducing scan time for large libraries. Key changes: - Add ScanTarget struct and ScanFolders API to Scanner interface - Implement CLI flag --targets for specifying libraryID:folderPath pairs - Add FolderRepository.GetByPaths() for batch folder info retrieval - Create loadSpecificFolders() for non-recursive directory loading - Scope GC operations to affected libraries only (with TODO for full impl) - Add comprehensive tests for selective scanning behavior The selective scan: - Only processes specified folders (no subdirectory recursion) - Maintains library isolation - Runs full maintenance pipeline scoped to affected libraries - Supports both full and quick scan modes Examples: navidrome scan --targets "1:Music/Rock,1:Music/Jazz" navidrome scan --full --targets "2:Classical" * feat(folder): replace GetByPaths with GetFolderUpdateInfo for improved folder updates retrieval Signed-off-by: Deluan <[email protected]> * test: update parseTargets test to handle folder names with spaces Signed-off-by: Deluan <[email protected]> * refactor(folder): remove unused LibraryPath struct and update GC logging message Signed-off-by: Deluan <[email protected]> * refactor(folder): enhance external scanner to support target-specific scanning Signed-off-by: Deluan <[email protected]> * refactor(scanner): simplify scanner methods Signed-off-by: Deluan <[email protected]> * feat(watcher): implement folder scanning notifications with deduplication Signed-off-by: Deluan <[email protected]> * refactor(watcher): add resolveFolderPath function for testability Signed-off-by: Deluan <[email protected]> * feat(watcher): implement path ignoring based on .ndignore patterns Signed-off-by: Deluan <[email protected]> * refactor(scanner): implement IgnoreChecker for managing .ndignore patterns Signed-off-by: Deluan <[email protected]> * refactor(ignore_checker): rename scanner to lineScanner for clarity Signed-off-by: Deluan <[email protected]> * refactor(scanner): enhance ScanTarget struct with String method for better target representation Signed-off-by: Deluan <[email protected]> * fix(scanner): validate library ID to prevent negative values Signed-off-by: Deluan <[email protected]> * refactor(scanner): simplify GC method by removing library ID parameter Signed-off-by: Deluan <[email protected]> * feat(scanner): update folder scanning to include all descendants of specified folders Signed-off-by: Deluan <[email protected]> * feat(subsonic): allow selective scan in the /startScan endpoint Signed-off-by: Deluan <[email protected]> * refactor(scanner): update CallScan to handle specific library/folder pairs Signed-off-by: Deluan <[email protected]> * refactor(scanner): streamline scanning logic by removing scanAll method Signed-off-by: Deluan <[email protected]> * test: enhance mockScanner for thread safety and improve test reliability Signed-off-by: Deluan <[email protected]> * refactor(scanner): move scanner.ScanTarget to model.ScanTarget Signed-off-by: Deluan <[email protected]> * refactor: move scanner types to model,implement MockScanner Signed-off-by: Deluan <[email protected]> * refactor(scanner): update scanner interface and implementations to use model.Scanner Signed-off-by: Deluan <[email protected]> * refactor(folder_repository): normalize target path handling by using filepath.Clean Signed-off-by: Deluan <[email protected]> * test(folder_repository): add comprehensive tests for folder retrieval and child exclusion Signed-off-by: Deluan <[email protected]> * refactor(scanner): simplify selective scan logic using slice.Filter Signed-off-by: Deluan <[email protected]> * refactor(scanner): streamline phase folder and album creation by removing unnecessary library parameter Signed-off-by: Deluan <[email protected]> * refactor(scanner): move initialization logic from phase_1 to the scanner itself Signed-off-by: Deluan <[email protected]> * refactor(tests): rename selective scan test file to scanner_selective_test.go Signed-off-by: Deluan <[email protected]> * feat(configuration): add DevSelectiveWatcher configuration option Signed-off-by: Deluan <[email protected]> * feat(watcher): enhance .ndignore handling for folder deletions and file changes Signed-off-by: Deluan <[email protected]> * docs(scanner): comments Signed-off-by: Deluan <[email protected]> * refactor(scanner): enhance walkDirTree to support target folder scanning Signed-off-by: Deluan <[email protected]> * fix(scanner, watcher): handle errors when pushing ignore patterns for folders Signed-off-by: Deluan <[email protected]> * Update scanner/phase_1_folders.go Co-authored-by: Copilot <[email protected]> * refactor(scanner): replace parseTargets function with direct call to scanner.ParseTargets Signed-off-by: Deluan <[email protected]> * test(scanner): add tests for ScanBegin and ScanEnd functionality Signed-off-by: Deluan <[email protected]> * fix(library): update PRAGMA optimize to check table sizes without ANALYZE Signed-off-by: Deluan <[email protected]> * test(scanner): refactor tests Signed-off-by: Deluan <[email protected]> * feat(ui): add selective scan options and update translations Signed-off-by: Deluan <[email protected]> * feat(ui): add quick and full scan options for individual libraries Signed-off-by: Deluan <[email protected]> * feat(ui): add Scan buttonsto the LibraryList Signed-off-by: Deluan <[email protected]> * feat(scan): update scanning parameters from 'path' to 'target' for selective scans. * refactor(scan): move ParseTargets function to model package * test(scan): suppress unused return value from SetUserLibraries in tests * feat(gc): enhance garbage collection to support selective library purging Signed-off-by: Deluan <[email protected]> * fix(scanner): prevent race condition when scanning deleted folders When the watcher detects changes in a folder that gets deleted before the scanner runs (due to the 10-second delay), the scanner was prematurely removing these folders from the tracking map, preventing them from being marked as missing. The issue occurred because `newFolderEntry` was calling `popLastUpdate` before verifying the folder actually exists on the filesystem. Changes: - Move fs.Stat check before newFolderEntry creation in loadDir to ensure deleted folders remain in lastUpdates for finalize() to handle - Add early existence check in walkDirTree to skip non-existent target folders with a warning log - Add unit test verifying non-existent folders aren't removed from lastUpdates prematurely - Add integration test for deleted folder scenario with ScanFolders Fixes the issue where deleting entire folders (e.g., /music/AC_DC) wouldn't mark tracks as missing when using selective folder scanning. * refactor(scan): streamline folder entry creation and update handling Signed-off-by: Deluan <[email protected]> * feat(scan): add '@Recycle' (QNAP) to ignored directories list Signed-off-by: Deluan <[email protected]> * fix(log): improve thread safety in logging level management * test(scan): move unit tests for ParseTargets function Signed-off-by: Deluan <[email protected]> * review Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
5ce6e16d96 |
fix: album statistics not updating after deleting missing files (#4668)
* feat: add album refresh functionality after deleting missing files Implemented RefreshAlbums method in AlbumRepository to recalculate album attributes (size, duration, song count) from their constituent media files. This method processes albums in batches to maintain efficiency with large datasets. Added integration in deleteMissingFiles to automatically refresh affected albums in the background after deleting missing media files, ensuring album statistics remain accurate. Includes comprehensive test coverage for various scenarios including single/multiple albums, empty batches, and large batch processing. Signed-off-by: Deluan <[email protected]> * refactor: extract missing files deletion into reusable service layer Extracted inline deletion logic from server/nativeapi/missing.go into a new core.MissingFiles service interface and implementation. This provides better separation of concerns and testability. The MissingFiles service handles: - Deletion of specific or all missing files via transaction - Garbage collection after deletion - Extraction of affected album IDs from missing files - Background refresh of artist and album statistics The deleteMissingFiles HTTP handler now simply delegates to the service, removing 70+ lines of inline logic. All deletion, transaction, and stat refresh logic is now centralized in core/missing_files.go. Updated dependency injection to provide MissingFiles service to the native API router. Renamed receiver variable from 'n' to 'api' throughout native_api.go for consistency. * refactor: consolidate maintenance operations into unified service Consolidate MissingFiles and RefreshAlbums functionality into a new Maintenance service. This refactoring: - Creates core.Maintenance interface combining DeleteMissingFiles, DeleteAllMissingFiles, and RefreshAlbums methods - Moves RefreshAlbums logic from AlbumRepository persistence layer to core Maintenance service - Removes MissingFiles interface and moves its implementation to maintenanceService - Updates all references in wire providers, native API router, and handlers - Removes RefreshAlbums interface method from AlbumRepository model - Improves separation of concerns by centralizing maintenance operations in the core domain This change provides a cleaner API and better organization of maintenance-related database operations. * refactor: remove MissingFiles interface and update references Remove obsolete MissingFiles interface and its references: - Delete core/missing_files.go and core/missing_files_test.go - Remove RefreshAlbums method from AlbumRepository interface and implementation - Remove RefreshAlbums tests from AlbumRepository test suite - Update wire providers to use NewMaintenance instead of NewMissingFiles - Update native API router to use Maintenance service - Update missing.go handler to use Maintenance interface All functionality is now consolidated in the core.Maintenance service. Signed-off-by: Deluan <[email protected]> * refactor: rename RefreshAlbums to refreshAlbums and update related calls Signed-off-by: Deluan <[email protected]> * refactor: optimize album refresh logic and improve test coverage Signed-off-by: Deluan <[email protected]> * refactor: simplify logging setup in tests with reusable LogHook function Signed-off-by: Deluan <[email protected]> * refactor: add synchronization to logger and maintenance service for thread safety Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
9dbe0c183e |
feat(insights): add plugin and multi-library information (#4391)
* feat(plugins): add PluginList method Signed-off-by: Deluan <[email protected]> * feat: enhance insights collection with plugin awareness and expanded metrics Enhanced the insights collection system to provide more comprehensive telemetry data about Navidrome installations. This update adds plugin awareness through dependency injection integration, expands configuration detection capabilities, and includes additional library metrics. Key improvements include: - Added PluginLoader interface integration to collect plugin information when enabled - Enhanced configuration detection with proper credential validation for LastFM, Spotify, and Deezer - Added new library metrics including Libraries count and smart playlist detection - Expanded configuration insights with reverse proxy, custom PID, and custom tags detection - Updated Wire dependency injection to support the new plugin loader requirement - Added corresponding data structures for plugin information collection This enhancement provides valuable insights into feature usage patterns and plugin adoption while maintaining privacy and following existing telemetry practices. * fix: correct type assertion in plugin manager test Fixed type mismatch in test where PluginManifestCapabilitiesElem was being compared with string literal. The test now properly casts the string to the correct enum type for comparison. * refactor: move static config checks to staticData function Moved HasCustomTags, ReverseProxyConfigured, and HasCustomPID configuration checks from the dynamic collect() function to the static staticData() function where they belong. This eliminates redundant computation on every insights collection cycle and implements the actual logic for HasCustomTags instead of the hardcoded false value. The HasCustomTags field now properly detects if custom tags are configured by checking the length of conf.Server.Tags. This change improves performance by computing static configuration values only once rather than on every insights collection. * feat: add granular control for insights collection Added DevEnablePluginsInsights configuration option to allow fine-grained control over whether plugin information is collected as part of the insights data. This change enhances privacy controls by allowing users to opt-out of plugin reporting while still participating in general insights collection. The implementation includes: - New configuration option DevEnablePluginsInsights with default value true - Gated plugin collection in insights.go based on both plugin enablement and permission flag - Enhanced plugin information to include version data alongside name - Improved code organization with clearer conditional logic for data collection * refactor: rename PluginNames parameter from serviceName to capability Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
00c83af170 |
feat: Multi-library support (#4181)
* feat(database): add user_library table and library access methods Signed-off-by: Deluan <[email protected]> # Conflicts: # tests/mock_library_repo.go * feat(database): enhance user retrieval with library associations Signed-off-by: Deluan <[email protected]> * feat(api): implement library management and user-library association endpoints Signed-off-by: Deluan <[email protected]> * feat(api): restrict access to library and config endpoints to admin users Signed-off-by: Deluan <[email protected]> * refactor(library): implement library management service and update API routes Signed-off-by: Deluan <[email protected]> * feat(database): add library filtering to album, folder, and media file queries Signed-off-by: Deluan <[email protected]> * refactor library service to use REST repository pattern and remove CRUD operations Signed-off-by: Deluan <[email protected]> * add total_duration column to library and update user_library table Signed-off-by: Deluan <[email protected]> * fix migration file name Signed-off-by: Deluan <[email protected]> * feat(library): add library management features including create, edit, delete, and list functionalities - WIP Signed-off-by: Deluan <[email protected]> * feat(library): enhance library validation and management with path checks and normalization - WIP Signed-off-by: Deluan <[email protected]> * feat(library): improve library path validation and error handling - WIP Signed-off-by: Deluan <[email protected]> * use utils/formatBytes Signed-off-by: Deluan <[email protected]> * simplify DeleteLibraryButton.jsx Signed-off-by: Deluan <[email protected]> * feat(library): enhance validation messages and error handling for library paths Signed-off-by: Deluan <[email protected]> * lint Signed-off-by: Deluan <[email protected]> * test(scanner): add tests for multi-library scanning and validation Signed-off-by: Deluan <[email protected]> * test(scanner): improve handling of filesystem errors and ensure warnings are returned Signed-off-by: Deluan <[email protected]> * feat(controller): add function to retrieve the most recent scan time across all libraries Signed-off-by: Deluan <[email protected]> * feat(library): add additional fields and restructure LibraryEdit component for enhanced statistics display Signed-off-by: Deluan <[email protected]> * feat(library): enhance LibraryCreate and LibraryEdit components with additional props and styling Signed-off-by: Deluan <[email protected]> * feat(mediafile): add LibraryName field and update queries to include library name Signed-off-by: Deluan <[email protected]> * feat(missingfiles): add library filter and display in MissingFilesList component Signed-off-by: Deluan <[email protected]> * feat(library): implement scanner interface for triggering library scans on create/update Signed-off-by: Deluan <[email protected]> # Conflicts: # cmd/wire_gen.go # cmd/wire_injectors.go # Conflicts: # cmd/wire_gen.go # Conflicts: # cmd/wire_gen.go # cmd/wire_injectors.go * feat(library): trigger scan after successful library deletion to clean up orphaned data Signed-off-by: Deluan <[email protected]> * rename migration file for user library table to maintain versioning order Signed-off-by: Deluan <[email protected]> * refactor: move scan triggering logic into a helper method for clarity Signed-off-by: Deluan <[email protected]> * feat(library): add library path and name fields to album and mediafile models Signed-off-by: Deluan <[email protected]> * feat(library): add/remove watchers on demand, not only when server starts Signed-off-by: Deluan <[email protected]> * refactor(scanner): streamline library handling by using state-libraries for consistency Signed-off-by: Deluan <[email protected]> * fix: track processed libraries by updating state with scan timestamps Signed-off-by: Deluan <[email protected]> * prepend libraryID for track and album PIDs Signed-off-by: Deluan <[email protected]> * feat(repository): apply library filtering in CountAll methods for albums, folders, and media files Signed-off-by: Deluan <[email protected]> * feat(user): add library selection for user creation and editing Signed-off-by: Deluan <[email protected]> * feat(library): implement library selection functionality with reducer and UI component Signed-off-by: Deluan <[email protected]> # Conflicts: # .github/copilot-instructions.md # Conflicts: # .gitignore * feat(library): add tests for LibrarySelector and library selection hooks Signed-off-by: Deluan <[email protected]> * test: add unit tests for file utility functions Signed-off-by: Deluan <[email protected]> * feat(library): add library ID filtering for album resources Signed-off-by: Deluan <[email protected]> * feat(library): streamline library ID filtering in repositories and update resource filtering logic Signed-off-by: Deluan <[email protected]> * fix(repository): add table name handling in filter functions for SQL queries Signed-off-by: Deluan <[email protected]> * feat(library): add refresh functionality on LibrarySelector close Signed-off-by: Deluan <[email protected]> * feat(artist): add library ID filtering for artists in repository and update resource filtering logic Signed-off-by: Deluan <[email protected]> # Conflicts: # persistence/artist_repository.go * Add library_id field support for smart playlists - Add library_id field to smart playlist criteria system - Supports Is and IsNot operators for filtering by library ID - Includes comprehensive test coverage for single values and lists - Enables creation of library-specific smart playlists * feat(subsonic): implement user-specific library access in GetMusicFolders Signed-off-by: Deluan <[email protected]> * feat(library): enhance LibrarySelectionField to extract library IDs from record Signed-off-by: Deluan <[email protected]> * feat(subsonic): update GetIndexes and GetArtists method to support library ID filtering Signed-off-by: Deluan <[email protected]> * fix: ensure LibrarySelector dropdown refreshes on button close Added refresh() call when closing the dropdown via button click to maintain consistency with the ClickAwayListener behavior. This ensures the UI updates properly regardless of how the dropdown is closed, fixing an inconsistent refresh behavior between different closing methods. The fix tracks the previous open state and calls refresh() only when the dropdown was open and is being closed by the button click. * refactor: simplify getUserAccessibleLibraries function and update related tests Signed-off-by: Deluan <[email protected]> * feat: enhance selectedMusicFolderIds function to handle valid music folder IDs and improve fallback logic Signed-off-by: Deluan <[email protected]> * refactor: change ArtistRepository.GetIndex to accept multiple library IDs Updated the GetIndex method signature to accept a slice of library IDs instead of a single ID, enabling support for filtering artists across multiple libraries simultaneously. Changes include: - Modified ArtistRepository interface in model/artist.go - Updated implementation in persistence/artist_repository.go with improved library filtering logic - Refactored Subsonic API browsing.go to use new selectedMusicFolderIds helper - Added comprehensive test coverage for multiple library scenarios - Updated mock repository implementation for testing This change improves flexibility for multi-library operations while maintaining backward compatibility through the selectedMusicFolderIds helper function. * feat: add library access validation to selectedMusicFolderIds Enhanced the selectedMusicFolderIds function to validate musicFolderId parameters against the user's accessible libraries. Invalid library IDs (those the user doesn't have access to) are now silently filtered out, improving security by preventing users from accessing libraries they don't have permission for. Changes include: - Added validation logic to check musicFolderId parameters against user's accessible libraries - Added slices package import for efficient validation - Enhanced function documentation to clarify validation behavior - Added comprehensive test cases covering validation scenarios - Maintains backward compatibility with existing behavior * feat: implement multi-library support for GetAlbumList and GetAlbumList2 endpoints - Enhanced selectedMusicFolderIds helper to validate and filter library IDs - Added ApplyLibraryFilter function in filter/filters.go for library filtering - Updated getAlbumList to support musicFolderId parameter filtering - Added comprehensive tests for multi-library functionality - Supports single and multiple musicFolderId values - Falls back to all accessible libraries when no musicFolderId provided - Validates library access permissions for user security * feat: implement multi-library support for GetRandomSongs, GetSongsByGenre, GetStarred, and GetStarred2 - Added multi-library filtering to GetRandomSongs endpoint using musicFolderId parameter - Added multi-library filtering to GetSongsByGenre endpoint using musicFolderId parameter - Enhanced GetStarred and GetStarred2 to filter artists, albums, and songs by library - Added Options field to MockMediaFileRepo and MockArtistRepo for test compatibility - Added comprehensive Ginkgo/Gomega tests for all new multi-library functionality - All tests verify proper SQL filter generation and library access validation - Supports single/multiple musicFolderId values with fallback to all accessible libraries * refactor: optimize starred items queries with parallel execution and fix test isolation Refactored starred items functionality by extracting common logic into getStarredItems() method that executes artist, album, and media file queries in parallel for better performance. This eliminates code duplication between GetStarred and GetStarred2 methods while improving response times through concurrent database queries using run.Parallel(). Also fixed test isolation issues by adding missing auth.Init(ds) call in album lists test setup. This resolves nil pointer dereference errors in GetStarred and GetStarred2 tests when run independently. * fix: add ApplyArtistLibraryFilter to filter artists by associated music folders Signed-off-by: Deluan <[email protected]> * feat: add library access methods to User model Signed-off-by: Deluan <[email protected]> * feat: implement library access filtering for artist queries based on user permissions Signed-off-by: Deluan <[email protected]> * feat: enhance artist library filtering based on user permissions and optimize library ID retrieval Signed-off-by: Deluan <[email protected]> * fix: return error when any musicFolderId is invalid or inaccessible Changed behavior from silently filtering invalid library IDs to returning ErrorDataNotFound (code 70) when any provided musicFolderId parameter is invalid or the user doesn't have access to it. The error message includes the specific library number for better debugging. This affects album/song list endpoints (getAlbumList, getRandomSongs, getSongsByGenre, getStarred) to provide consistent error handling across all Subsonic API endpoints. Updated corresponding tests to expect errors instead of silent filtering. * feat: add musicFolderId parameter support to Search2 and Search3 endpoints Implemented musicFolderId parameter support for Subsonic API Search2 and Search3 endpoints, completing multi-library functionality across all Subsonic endpoints. Key changes: - Added musicFolderId parameter handling to Search2 and Search3 endpoints - Updated search logic to filter results by specified library or all accessible libraries when parameter not provided - Added proper error handling for invalid/inaccessible musicFolderId values - Refactored SearchableRepository interface to support library filtering with variadic QueryOptions - Updated repository implementations (Album, Artist, MediaFile) to handle library filtering in search operations - Added comprehensive test coverage with robust assertions verifying library filtering works correctly - Enhanced mock repositories to capture QueryOptions for test validation Signed-off-by: Deluan <[email protected]> * feat: refresh LibraryList on scan end Signed-off-by: Deluan <[email protected]> * fix: allow editing name of main library Signed-off-by: Deluan <[email protected]> * refactor: implement SendBroadcastMessage method for event broadcasting Signed-off-by: Deluan <[email protected]> * feat: add event broadcasting for library creation, update, and deletion Signed-off-by: Deluan <[email protected]> * feat: add useRefreshOnEvents hook for custom refresh logic on event changes Signed-off-by: Deluan <[email protected]> * feat: enhance library management with refresh event broadcasting Signed-off-by: Deluan <[email protected]> * feat: replace AddUserLibrary and RemoveUserLibrary with SetUserLibraries for better library management Signed-off-by: Deluan <[email protected]> * chore: remove commented-out genre repository code from persistence tests * feat: enhance library selection with master checkbox functionality Added a master checkbox to the SelectLibraryInput component, allowing users to select or deselect all libraries at once. This improves user experience by simplifying the selection process when multiple libraries are available. Additionally, updated translations in the en.json file to include a new message for selecting all libraries, ensuring consistency in user interface messaging. Signed-off-by: Deluan <[email protected]> * feat: add default library assignment for new users Introduced a new column `default_new_users` in the library table to facilitate automatic assignment of default libraries to new regular users. When a new user is created, they will now be assigned to libraries marked as default, enhancing user experience by ensuring they have immediate access to essential resources. Additionally, updated the user repository logic to handle this new functionality and modified the user creation validation to reflect that library selection is optional for non-admin users. Signed-off-by: Deluan <[email protected]> * fix: correct updated_at assignment in library repository Signed-off-by: Deluan <[email protected]> * fix: improve cache buffering logic Refactored the cache buffering logic to ensure thread safety when checking the buffer length Signed-off-by: Deluan <[email protected]> * fix formating Signed-off-by: Deluan <[email protected]> * feat: implement per-library artist statistics with automatic aggregation Implemented comprehensive multi-library support for artist statistics that automatically aggregates stats from user-accessible libraries. This fundamental change moves artist statistics from global scope to per-library granularity while maintaining backward compatibility and transparent operation. Key changes include: - Migrated artist statistics from global artist.stats to per-library library_artist.stats - Added automatic library filtering and aggregation in existing Get/GetAll methods - Updated role-based filtering to work with per-library statistics storage - Enhanced statistics calculation to process and store stats per library - Implemented user permission-aware aggregation that respects library access control - Added comprehensive test coverage for library filtering and restricted user access - Created helper functions to ensure proper library associations in tests This enables users to see statistics that accurately reflect only the content from libraries they have access to, providing proper multi-tenant behavior while maintaining the existing API surface and UI functionality. Signed-off-by: Deluan <[email protected]> * feat: add multi-library support with per-library tag statistics - WIP Signed-off-by: Deluan <[email protected]> * refactor: genre and tag repositories. add comprehensive tests Signed-off-by: Deluan <[email protected]> * feat: add multi-library support to tag repository system Implemented comprehensive library filtering for tag repositories to support the multi-library feature. This change ensures that users only see tags from libraries they have access to, while admin users can see all tags. Key changes: - Enhanced TagRepository.Add() method to accept libraryID parameter for proper library association - Updated baseTagRepository to implement library-aware queries with proper joins - Added library_tag table integration for per-library tag statistics - Implemented user permission-based filtering through user_library associations - Added comprehensive test coverage for library filtering scenarios - Updated UI data provider to include tag filtering by selected libraries - Modified scanner to pass library ID when adding tags during folder processing The implementation maintains backward compatibility while providing proper isolation between libraries for tag-based operations like genres and other metadata tags. * refactor: simplify artist repository library filtering Removed conditional admin logic from applyLibraryFilterToArtistQuery method and unified the library filtering approach to match the tag repository pattern. The method now always uses the same SQL join structure regardless of user role, with admin access handled automatically through user_library associations. Added artistLibraryIdFilter function to properly qualify library_id column references and prevent SQL ambiguity errors when multiple tables contain library_id columns. This ensures the filter targets library_artist.library_id specifically rather than causing ambiguous column name conflicts. * fix: resolve LibrarySelectionField validation error for non-admin users Fixed validation error 'At least one library must be selected for non-admin users' that appeared even when libraries were selected. The issue was caused by a data format mismatch between backend and frontend. The backend sends user data with libraries as an array of objects, but the LibrarySelectionField component expects libraryIds as an array of IDs. Added data transformation in the data provider's getOne method to automatically convert libraries array to libraryIds format when fetching user records. Also extracted validation logic into a separate userValidation module for better code organization and added comprehensive test coverage to prevent similar issues. * refactor: remove unused library access functions and related tests Signed-off-by: Deluan <[email protected]> * refactor: rename search_test.go to searching_test.go for consistency Signed-off-by: Deluan <[email protected]> * fix: add user context to scrobble buffer getParticipants call Added user context handling to scrobbleBufferRepository.Next method to resolve SQL error 'no such column: library_artist.library_id' when processing scrobble entries in multi-library environments. The artist repository now requires user context for proper library filtering, so we fetch the user and temporarily inject it into the context before calling getParticipants. This ensures background scrobbling operations work correctly with multi-library support. * feat: add cross-library move detection for scanner Implemented cross-library move detection for the scanner phase 2 to properly handle files moved between libraries. This prevents users from losing play counts, ratings, and other metadata when moving files across library boundaries. Changes include: - Added MediaFileRepository methods for two-tier matching: FindRecentFilesByMBZTrackID (primary) and FindRecentFilesByProperties (fallback) - Extended scanner phase 2 pipeline with processCrossLibraryMoves stage that processes files unmatched within their library - Implemented findCrossLibraryMatch with MusicBrainz Release Track ID priority and intrinsic properties fallback - Updated producer logic to handle missing tracks without matches, ensuring cross-library processing - Updated tests to reflect new producer behavior and cross-library functionality The implementation uses existing moveMatched function for unified move operations, automatically preserving all user data through database foreign key relationships. Cross-library moves are detected using the same Equals() and IsEquivalent() matching logic as within-library moves for consistency. Signed-off-by: Deluan <[email protected]> * feat: add album annotation reassignment for cross-library moves Implemented album annotation reassignment functionality for the scanner's missing tracks phase. When tracks move between libraries and change album IDs, the system now properly reassigns album annotations (starred status, ratings) from the old album to the new album. This prevents loss of user annotations when tracks are moved across library boundaries. The implementation includes: - Thread-safe annotation reassignment using mutex protection - Duplicate reassignment prevention through processed album tracking - Graceful error handling that doesn't fail the entire move operation - Comprehensive test coverage for various scenarios including error conditions This enhancement ensures data integrity and user experience continuity during cross-library media file movements. * fix: address PR review comments for multi-library support Fixed several issues identified in PR review: - Removed unnecessary artist stats initialization check since the map is already initialized in PostScan() - Improved code clarity in user repository by extracting isNewUser variable to avoid checking count == 0 twice - Fixed library selection logic to properly handle initial library state and prevent overriding user selections These changes address code quality and logic issues identified during the multi-library support PR review. * feat: add automatic playlist statistics refreshing Implemented automatic playlist statistics (duration, size, song count) refreshing when tracks are modified. Added new refreshStats() method to recalculate statistics from playlist tracks, and SetTracks() method to update tracks and refresh statistics atomically. Modified all track manipulation methods (RemoveTracks, AddTracks, AddMediaFiles) to automatically refresh statistics. Updated playlist repository to use the new SetTracks method for consistent statistics handling. * refactor: rename AddTracks to AddMediaFilesByID for clarity Renamed the AddTracks method to AddMediaFilesByID throughout the codebase to better reflect its purpose of adding media files to a playlist by their IDs. This change improves code readability and makes the method name more descriptive of its actual functionality. Updated all references in playlist model, tests, core playlist logic, and Subsonic API handlers to use the new method name. * refactor: consolidate user context access in persistence layer Removed duplicate helper functions userId() and isAdmin() from sql_base_repository.go and consolidated all user context access to use loggedUser(r.ctx).ID and loggedUser(r.ctx).IsAdmin consistently across the persistence layer. This change eliminates code duplication and provides a single, consistent pattern for accessing user context information in repository methods. All functionality remains unchanged - this is purely a code cleanup refactoring. * refactor: eliminate MockLibraryService duplication using embedded struct - Replace 235-line MockLibraryService with 40-line embedded struct pattern - Enhance MockLibraryRepo with service-layer methods (192→310 lines) - Maintain full compatibility with existing tests - All 72 nativeapi specs pass with proper error handling Signed-off-by: Deluan <[email protected]> * refactor: cleanup Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
a3d1a9dbe5 |
fix(plugins): silence plugin warnings and folder creation when plugins disabled (#4297)
* fix(plugins): silence repeated “Plugin not found” spam for inactive Spotify/Last.fm plugins
Navidrome was emitting a warning when the optional Spotify or
Last.fm agents weren’t enabled, filling the journal with entries like:
level=warning msg="Plugin not found" capability=MetadataAgent name=spotify
Fixed by completely disable the plugin system when Plugins.Enabled = false.
Signed-off-by: Deluan <[email protected]>
* style: update test description for clarity
Signed-off-by: Deluan <[email protected]>
* fix: ensure plugin folder is created only if plugins are enabled
Signed-off-by: Deluan <[email protected]>
---------
Signed-off-by: Deluan <[email protected]>
|
||
|
|
0cd15c1ddc |
feat(prometheus): add metrics to Subsonic API and Plugins (#4266)
* Add prometheus metrics to subsonic and plugins * address feedback, do not log error if operation is not supported * add missing timestamp and client to stats * remove .view from subsonic route * directly inject DataStore in Prometheus, to avoid having to pass it in every call Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
45c408a674 |
feat(plugins): allow Plugins to call the Subsonic API (#4260)
* chore: .gitignore any navidrome binary Signed-off-by: Deluan <[email protected]> * feat: implement internal authentication handling in middleware Signed-off-by: Deluan <[email protected]> * feat(manager): add SubsonicRouter to Manager for API routing Signed-off-by: Deluan <[email protected]> * feat(plugins): add SubsonicAPI Host service for plugins and an example plugin Signed-off-by: Deluan <[email protected]> * fix lint Signed-off-by: Deluan <[email protected]> * feat(plugins): refactor path handling in SubsonicAPI to extract endpoint correctly Signed-off-by: Deluan <[email protected]> * docs(plugins): add SubsonicAPI service documentation to README Signed-off-by: Deluan <[email protected]> * feat(plugins): implement permission checks for SubsonicAPI service Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance SubsonicAPI service initialization with atomic router handling Signed-off-by: Deluan <[email protected]> * refactor(plugins): better encapsulated dependency injection Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename parameter in WithInternalAuth for clarity Signed-off-by: Deluan <[email protected]> * docs(plugins): update SubsonicAPI permissions section in README for clarity and detail Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance SubsonicAPI permissions output with allowed usernames and admin flag Signed-off-by: Deluan <[email protected]> * feat(plugins): add schema reference to example plugins Signed-off-by: Deluan <[email protected]> * remove import alias Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
177de7269b |
fix(scanner): always check for needed initial scan.
Relates to #4246 Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoGitHubellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> |
f1fc2cd9b9 |
feat(plugins): experimental support for plugins (#3998)
* feat(plugins): add minimal test agent plugin with API definitions Signed-off-by: Deluan <[email protected]> * feat: add plugin manager with auto-registration and unique agent names Introduced a plugin manager that scans the plugins folder for subdirectories containing plugin.wasm files and auto-registers them as agents using the directory name as the unique agent name. Updated the configuration to support plugins with enabled/folder options, and ensured the plugin manager is started as a concurrent task during server startup. The wasmAgent now returns the plugin directory name for AgentName, ensuring each plugin agent is uniquely identifiable. This enables dynamic plugin discovery and integration with the agents orchestrator. * test: add Ginkgo suite and test for plugin manager auto-registration Added a Ginkgo v2 suite bootstrap (plugins_suite_test.go) for the plugins package and a test (manager_test.go) to verify that plugins in the testdata folder are auto-registered and can be loaded as agents. The test uses a mock DataStore and asserts that the agent is registered and its AgentName matches the plugin directory. Updated go.mod and go.sum for wazero dependency required by plugin WASM support. * test(plugins): ensure test WASM plugin is always freshly built before running suite; add real-plugin Ginkgo tests. Add BeforeSuite to plugins suite to build plugins/testdata/agent/plugin.wasm using Go WASI build command, matching README instructions. Remove plugin.wasm before build to guarantee a clean build. Add full real-plugin Ginkgo/Gomega tests for wasmAgent, covering all methods and error cases. Fix manager_test.go to use pointer to Manager. This ensures plugin tests are always run against a freshly compiled WASM binary, increasing reliability and reproducibility. Signed-off-by: Deluan <[email protected]> * feat(plugins): implement persistent compilation cache for WASM agent plugins Signed-off-by: Deluan <[email protected]> * feat(plugins): implement instance pooling for wasmAgent to improve resource management Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance logging for wasmAgent and plugin manager operations Signed-off-by: Deluan <[email protected]> * feat(plugins): implement HttpService for handling HTTP requests in WASM plugins Also add a sample Wikimedia plugin Signed-off-by: Deluan <[email protected]> * feat(plugins): standardize error handling in wasmAgent and MinimalAgent Signed-off-by: Deluan <[email protected]> * refactor: clean up wikimedia plugin code Standardized error creation using 'errors.New' where formatting was not needed. Introduced a constant for HTTP request timeouts. Removed commented-out log statement. Improved code comments for clarity and accuracy. * refactor: use unified SPARQLResult struct and parser for SPARQL responses Introduced a single SPARQLResult struct to represent all possible SPARQL response fields (sitelink, wiki, comment, img). Added a parseSPARQLResult helper to unmarshal and check for empty results, simplifying all fetch functions and improving type safety and maintainability. * feat(plugins): improve error handling in HTTP request processing Signed-off-by: Deluan <[email protected]> * fix: background plugin compilation, logging, and race safety Implemented background WASM plugin compilation with concurrency limits, proper closure capture, and global compilation cache to avoid data races. Added debug and warning logs for plugin compilation results, including elapsed time. Ensured plugin registration is correct and all tests pass. * perf: implement true lazy loading for agents Changed agent instantiation to be fully lazy. The Agents struct now stores agent names in order and only instantiates each agent on first use, caching the result. This preserves agent call order, improves server startup time, and ensures thread safety. Updated all agent methods and tests to use the new pattern. No changes to agent registration or interface. All tests pass. * fix: ensure wasm plugin instances are closed via runtime.AddCleanup Introduced runtime.AddCleanup to guarantee that the Close method of WASM plugin instances is called, even if they are garbage collected from the sync.Pool. Modified the sync.Pool.New function in manager.go to register a cleanup function for each loaded instance that implements Close. Updated agent.go to handle the pooledInstance wrapper containing the instance and its cleanup handle. Ensured cleanup.Stop() is called before explicitly closing an instance (on error or agent shutdown) to prevent double closing. This fixes a potential resource leak where instances could be GC'd from the pool without proper cleanup. * refactor: break down long functions in plugin manager and agent Refactored plugins/manager.go and plugins/agent.go to improve readability and reduce function length. Extracted pool initialization logic into newPluginPool and background compilation/agent factory logic into precompilePlugin/createAgentFactory in manager.go. Extracted pool retrieval/validation and cleanup function creation into getValidPooledInstance/createPoolCleanupFunc in agent.go. Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename wasmAgent to wasmArtistAgent Signed-off-by: Deluan <[email protected]> * feat(api): add AlbumMetadataService with AlbumInfo and AlbumImages requests Signed-off-by: Deluan <[email protected]> * refactor(plugin): rename MinimalAgent for artist metadata service Signed-off-by: Deluan <[email protected]> * feat(api): implement wasmAlbumAgent for album metadata service with GetAlbumInfo and GetAlbumImages methods Signed-off-by: Deluan <[email protected]> * refactor(plugins): simplify wasmAlbumAgent and wasmArtistAgent by using wasmBasePlugin Signed-off-by: Deluan <[email protected]> * feat(plugins): add support for ArtistMetadataService and AlbumMetadataService in plugin manager Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance plugin pool creation with custom runtime and precompilation support Signed-off-by: Deluan <[email protected]> * refactor(plugins): implement generic plugin pool and agent factory for improved service handling Signed-off-by: Deluan <[email protected]> * refactor(plugins): reorganize plugin management Signed-off-by: Deluan <[email protected]> * refactor(plugins): improve function signatures for clarity and consistency Signed-off-by: Deluan <[email protected]> * feat(plugins): implement background precompilation for plugins and agent factory creation Signed-off-by: Deluan <[email protected]> * refactor(plugins): include instanceID in logging for better traceability Signed-off-by: Deluan <[email protected]> * test(plugins): add tests for plugin pre-compilation and agent factory synchronization Signed-off-by: Deluan <[email protected]> * feat(plugins): add minimal album test agent plugin for AlbumMetadataService Signed-off-by: Deluan <[email protected]> * feat(plugins): rename fake artist and album test agent plugins for metadata services Signed-off-by: Deluan <[email protected]> * feat(makefile): add Makefile for building plugin WASM binaries Signed-off-by: Deluan <[email protected]> * feat(plugins): add FakeMultiAgent plugin implementing Artist and Album metadata services Signed-off-by: Deluan <[email protected]> * refactor(plugins): remove log statements from FakeArtistAgent and FakeMultiAgent methods Signed-off-by: Deluan <[email protected]> * refactor: split AlbumInfoRetriever and AlbumImageRetriever, update all usages Split the AlbumInfoRetriever interface into two: AlbumInfoRetriever (for album metadata) and AlbumImageRetriever (for album images), to better separate concerns and simplify implementations. Updated all agents, providers, plugins, and tests to use the new interfaces and methods. Removed the now-unnecessary mockAlbumAgents in favor of the shared mockAgents. Fixed a missing images slice declaration in lastfm agent. All tests pass except for known ignored persistence tests. This change reduces code duplication, improves clarity, and keeps the codebase clean and organized. * feat(plugins): add Cover Art Archive AlbumMetadataService plugin for album cover images Signed-off-by: Deluan <[email protected]> * refactor: remove wasm module pooling it was causing issues with the GC and the Close methods Signed-off-by: Deluan <[email protected]> * refactor: rename metadata service files to adapter naming convention Signed-off-by: Deluan <[email protected]> * refactor: unify album and artist method calls by introducing callMethod function Signed-off-by: Deluan <[email protected]> * refactor: unify album and artist method calls by introducing callMethod function Signed-off-by: Deluan <[email protected]> * fix: handle nil values in data redaction process Signed-off-by: Deluan <[email protected]> * fix: add timeout for plugin compilation to prevent indefinite blocking Signed-off-by: Deluan <[email protected]> * feat: implement ScrobblerService plugin with authorization and scrobbling capabilities Signed-off-by: Deluan <[email protected]> * refactor: simplify generalization Signed-off-by: Deluan <[email protected]> * fix: tests Signed-off-by: Deluan <[email protected]> * refactor: enhance plugin management by improving scanning and loading mechanisms Signed-off-by: Deluan <[email protected]> * refactor: update plugin creation functions to return specific interfaces for better type safety Signed-off-by: Deluan <[email protected]> * refactor: enhance wasmBasePlugin to support specific plugin types for improved type safety Signed-off-by: Deluan <[email protected]> * refactor: implement MediaMetadataService with combined artist and album methods Signed-off-by: Deluan <[email protected]> * refactor: improve MediaMetadataService plugin implementation and testing structure Signed-off-by: Deluan <[email protected]> * refactor: add tests for Adapter Media Agent and improve plugin documentation Signed-off-by: Deluan <[email protected]> * docs: add README for Navidrome Plugin System with detailed architecture and usage guidelines Signed-off-by: Deluan <[email protected]> * refactor: enhance agent management with plugin loading and caching Signed-off-by: Deluan <[email protected]> * refactor: update agent discovery logic to include only local agent when no config is specified Signed-off-by: Deluan <[email protected]> * refactor: encapsulate agent caching logic in agentCache struct\n\nReplaced direct map/mutex usage for agent caching in Agents with a dedicated agentCache struct. This improves readability, maintainability, and testability by centralizing TTL and concurrency logic. Cleaned up comments and ensured all linter and test requirements are met. Signed-off-by: Deluan <[email protected]> * fix: correct file extension filter in goimports command Signed-off-by: Deluan <[email protected]> * refactor: use defer to unlock the mutex Signed-off-by: Deluan <[email protected]> * chore: move Cover Art Archive AlbumMetadataService plugins to an example folder Signed-off-by: Deluan <[email protected]> * fix: handle errors when creating media metadata and scrobbler service plugins Signed-off-by: Deluan <[email protected]> * fix: increase compilation timeout to one minute Signed-off-by: Deluan <[email protected]> * feat: add configurable plugin compilation timeout Signed-off-by: Deluan <[email protected]> * feat: implement plugin scrobbler support in PlayTracker Signed-off-by: Deluan <[email protected]> * feat: add context management and Stop method to buffered scrobbler Signed-off-by: Deluan <[email protected]> * feat: add username field to scrobbler requests and update logging Signed-off-by: Deluan <[email protected]> * fix: data race in test Signed-off-by: Deluan <[email protected]> * refactor: rename http proto files to host and update references Signed-off-by: Deluan <[email protected]> * refactor: remove unused plugin registration methods from manager Signed-off-by: Deluan <[email protected]> * feat: extend plugin manifests and implement plugin management commands Signed-off-by: Deluan <[email protected]> * Update utils/files.go Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * fix for code scanning alert no. 43: Arbitrary file access during archive extraction ("Zip Slip") Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * feat: add plugin dev workflow support Added new CLI commands to improve plugin development workflow: 'plugin dev' to create symlinks from development directories to plugins folder, 'plugin refresh' to reload plugins without restarting Navidrome, enhanced 'plugin remove' to handle symlinked development plugins correctly, and updated 'plugin list' to display development plugins with '(dev)' indicator. These changes make the plugin development workflow more efficient by allowing developers to work on plugins in their own directories, link them to Navidrome without copying files, refresh plugins after changes without restart, and clean up safely. Signed-off-by: Deluan <[email protected]> * feat(plugins): implement timer service with register and cancel functionality - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): implement timer service with register and cancel functionality - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): implement timer service with register and cancel functionality - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): implement timer service with register and cancel functionality Signed-off-by: Deluan <[email protected]> * fix: lint errors Signed-off-by: Deluan <[email protected]> * feat(README): update documentation to include TimerCallbackService and its functionality Signed-off-by: Deluan <[email protected]> * feat(plugins): add InitService with OnInit method and initialization tracking - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): add tests for InitService and plugin initialization tracking Signed-off-by: Deluan <[email protected]> * feat(plugins): expand documentation on plugin system implementation and architecture Signed-off-by: Deluan <[email protected]> * fix: panic Signed-off-by: Deluan <[email protected]> * feat(plugins): redirect plugins' stderr to logs Signed-off-by: Deluan <[email protected]> * feat(plugins): add safe accessor methods for TimerService Signed-off-by: Deluan <[email protected]> * feat(plugins): add plugin-specific configuration support in InitRequest and documentation Signed-off-by: Deluan <[email protected]> * feat(plugins): add TimerCallbackService plugin adapter and integration Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename services for consistency and clarity Signed-off-by: Deluan <[email protected]> * feat(plugins): add mutex for configuration access and clone plugin config Signed-off-by: Deluan <[email protected]> * refactor(tests): remove configtest dependency to prevent data races in integration tests Signed-off-by: Deluan <[email protected]> * refactor(plugins): remove PluginName method from WASM plugin implementations and update LoadPlugin to accept service type Signed-off-by: Deluan <[email protected]> * feat(plugins): implement instance pooling for wasmBasePlugin to improve performance - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): add wasmInstancePool for managing WASM plugin instances with TTL and max size Signed-off-by: Deluan <[email protected]> * fix(plugins): correctly pass error to done function in wasmBasePlugin Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename service types to capabilities for consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): simplify instance management in wasmBasePlugin by removing error handling in closure Signed-off-by: Deluan <[email protected]> * refactor(plugins): update wasmBasePlugin and wasmInstancePool to return errors for better error handling Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename InitService to LifecycleManagement for consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): fix instance ID logging in wasmBasePlugin Signed-off-by: Deluan <[email protected]> * refactor(plugins): extract instance ID logging to a separate function in wasmBasePlugin, to avoid vet error Signed-off-by: Deluan <[email protected]> * refactor(plugins): make timers be isolated per plugin Signed-off-by: Deluan <[email protected]> * refactor(plugins): make timers be isolated per plugin Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename HttpServiceImpl to httpServiceImpl for consistency and improve logging Signed-off-by: Deluan <[email protected]> * feat(plugins): add config service for plugin-specific configuration management Signed-off-by: Deluan <[email protected]> * Update plugins/manager.go Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * Update plugins/manager.go Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * feat(crontab): implement crontab service for scheduling and canceling jobs Signed-off-by: Deluan <[email protected]> * fix(singleton): fix deadlock issue when a constructor calls GetSingleton again Signed-off-by: Deluan <[email protected]> (+1 squashed commit) Squashed commits: [325a96ea2] fix(singleton): fix deadlock issue when a constructor calls GetSingleton again Signed-off-by: Deluan <[email protected]> * feat(scheduler): implement Scheduler for one-time and recurring job scheduling, merging CrontabService and TimerService Signed-off-by: Deluan <[email protected]> * fix(scheduler): race condition in the scheduleOneTime and scheduleRecurring methods when replacing jobs with the same ID Signed-off-by: Deluan <[email protected]> * refactor(scheduler): consolidate job scheduling logic into a single helper function Signed-off-by: Deluan <[email protected]> * refactor(plugin): rename GetInstance method to Instantiate for clarity Signed-off-by: Deluan <[email protected]> * feat(plugins): add WebSocket service for handling connections and messages Signed-off-by: Deluan <[email protected]> * feat(crypto-ticker): add WebSocket plugin for real-time cryptocurrency price tracking Signed-off-by: Deluan <[email protected]> * feat(websocket): enhance connection management and callback handling Signed-off-by: Deluan <[email protected]> * feat(manager): only create one adapter instance for each adapter/capability pair Signed-off-by: Deluan <[email protected]> * fix(websocket): ensure proper resource management by closing response body and use defer to unlocking mutexes Signed-off-by: Deluan <[email protected]> * fix: flaky test Signed-off-by: Deluan <[email protected]> * feat(plugin): refactor WebSocket service integration and improve error logging Signed-off-by: Deluan <[email protected]> * feat(plugin): add SchedulerCallback support and improve reconnection logic Signed-off-by: Deluan <[email protected]> * fix: test panic Signed-off-by: Deluan <[email protected]> * docs: add crypto-ticker plugin example to README Signed-off-by: Deluan <[email protected]> * feat(manager): add LoadAllPlugins and LoadAllMediaAgents methods with slice.Map integration Signed-off-by: Deluan <[email protected]> * feat(api): add Timestamp field to ScrobblerNowPlayingRequest and update related methods Signed-off-by: Deluan <[email protected]> * feat(websocket): add error field to response messages for better error handling Signed-off-by: Deluan <[email protected]> * feat(cache): implement CacheService with string, int, float, and byte operations Signed-off-by: Deluan <[email protected]> * feat(tests): update buffered scrobbler tests for improved scrobble verification and use RWMutex in mock repo Signed-off-by: Deluan <[email protected]> * refactor(cache): simplify cache service implementation and remove unnecessary synchronization Signed-off-by: Deluan <[email protected]> * feat(tests): add build step for test plugins in the test suite Signed-off-by: Deluan <[email protected]> * wip Signed-off-by: Deluan <[email protected]> * feat(scheduler): implement named scheduler callbacks and enhance Discord plugin integration Signed-off-by: Deluan <[email protected]> * feat(rpc): enhance activity image processing and improve error handling in Discord integration Signed-off-by: Deluan <[email protected]> * feat(discord): enhance activity state with artist list and add large text asset Signed-off-by: Deluan <[email protected]> * fix tests Signed-off-by: Deluan <[email protected]> * feat(artwork): implement ArtworkService for retrieving artwork URLs Signed-off-by: Deluan <[email protected]> * Add playback position to scrobble NowPlaying (#4089) * test(playtracker): cover playback position * address review comment Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> * fix merge Signed-off-by: Deluan <[email protected]> * refactor: remove unnecessary check for empty slice in Map function Signed-off-by: Deluan <[email protected]> * fix: update reflex.conf to include .wasm file extension Signed-off-by: Deluan <[email protected]> * fix(scanner): normalize attribute strings and add edge case tests for PID calculation Relates to https://github.com/navidrome/navidrome/issues/4183#issuecomment-2952729458 Signed-off-by: Deluan <[email protected]> * test(ui): fix warnings (#4187) * fix(ui): address test warnings * ignore lint error in test Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> * refactor(server): optimize top songs lookup (#4189) * optimize top songs lookup * Optimize title matching queries * refactor: simplify top songs matching * improve error handling and logging in track loading functions Signed-off-by: Deluan <[email protected]> * test: add cases for fallback to title matching and combined MBID/title matching Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> * fix(ui): playlist details overflow in spotify-based themes (#4184) * test: ensure playlist details width * fix(test): simplify expectation for minWidth in NDPlaylistDetails Signed-off-by: Deluan <[email protected]> * fix(test): test all themes Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> * chore(deps): update TagLib to version 2.1 (#4185) * chore: update cross-taglib * fix(taglib): add logging for TagLib version Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> * test: verify agents fallback (#4191) * build(docker): downgrade Alpine version from 3.21 to 3.19, oldest supported version. This is to reduce the image size, as we don't really need the latest. Signed-off-by: Deluan <[email protected]> * fix tests Signed-off-by: Deluan <[email protected]> * feat(runtime): implement pooled WASM runtime and module for better instance management Signed-off-by: Deluan <[email protected]> * fix(discord-plugin): adjust timer delay calculation for track completion Signed-off-by: Deluan <[email protected]> * resolve PR comments Signed-off-by: Deluan <[email protected]> * feat(plugins): implement cache cleanup by size functionality Signed-off-by: Deluan <[email protected]> * fix(manager): return error from getCompilationCache and handle it in ScanPlugins Signed-off-by: Deluan <[email protected]> * fix possible rce condition Signed-off-by: Deluan <[email protected]> * feat(docs): update README to include Cache and Artwork services Signed-off-by: Deluan <[email protected]> * feat(manager): add permissions support for host services in custom runtime - WIP Signed-off-by: Deluan <[email protected]> * feat(manifest): add permissions field to plugin manifests - WIP Signed-off-by: Deluan <[email protected]> * test(permissions): implement permission validation and testing for plugins - WIP Signed-off-by: Deluan <[email protected]> * feat(plugins): add unauthorized_plugin to test permission enforcement - WIP Signed-off-by: Deluan <[email protected]> * feat(docs): add Plugin Permission System section to README - WIP Signed-off-by: Deluan <[email protected]> * feat(manifest): add detailed reasons for permissions in plugin manifests - WIP Signed-off-by: Deluan <[email protected]> * feat(permissions): implement granular HTTP permissions for plugins - WIP Signed-off-by: Deluan <[email protected]> * feat(permissions): implement HTTP and WebSocket permissions for plugins - WIP Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * refactor: unexport all plugins package private symbols Signed-off-by: Deluan <[email protected]> * update docs Signed-off-by: Deluan <[email protected]> * refactor: rename plugin_lifecycle_manager Signed-off-by: Deluan <[email protected]> * docs: add discord-rich-presence plugin example to README Signed-off-by: Deluan <[email protected]> * feat: add support for PATCH, HEAD, and OPTIONS HTTP methods Signed-off-by: Deluan <[email protected]> * feat: use folder names as unique identifiers for plugins Signed-off-by: Deluan <[email protected]> * fix: read config just once, to avoid data race in tests Signed-off-by: Deluan <[email protected]> * refactor: rename pluginName to pluginID for consistency across services Signed-off-by: Deluan <[email protected]> * fix: use symlink name instead of folder name for plugin registration Signed-off-by: Deluan <[email protected]> * feat: update plugin output format to include ID and enhance README with symlink usage Signed-off-by: Deluan <[email protected]> * refactor: implement shared plugin discovery function to streamline plugin scanning and error handling Signed-off-by: Deluan <[email protected]> * feat: show plugin permissions in `plugin info` Signed-off-by: Deluan <[email protected]> * feat: add JSON schema for Navidrome Plugin manifest and generate corresponding Go types - WIP Signed-off-by: Deluan <[email protected]> * feat: implement typed permissions for plugins to enhance permission handling Signed-off-by: Deluan <[email protected]> * feat: refactor plugin permissions to use typed schema and improve validation - WIP Signed-off-by: Deluan <[email protected]> * feat: update HTTP permissions handling to use typed schema for allowed URLs - WIP Signed-off-by: Deluan <[email protected]> * feat: remove unused JSON schema validation for plugin manifests Signed-off-by: Deluan <[email protected]> * feat: remove unused fields from PluginPackage struct in package.go Signed-off-by: Deluan <[email protected]> * feat: update file permissions in tests and remove unused permission parsing function Signed-off-by: Deluan <[email protected]> * feat: refactor test plugin creation to use typed permissions and remove legacy helper Signed-off-by: Deluan <[email protected]> * feat: add website field to plugin manifests and update test cases Signed-off-by: Deluan <[email protected]> * refactor: permission schema to use basePermission structure for consistency Signed-off-by: Deluan <[email protected]> * feat: enhance host service management by adding permission checks for each service Signed-off-by: Deluan <[email protected]> * refactor: reorganize code files Signed-off-by: Deluan <[email protected]> * refactor: simplify custom runtime creation by removing compilation cache parameter Signed-off-by: Deluan <[email protected]> * doc: add WebSocketService and update ConfigService for plugin-specific configuration Signed-off-by: Deluan <[email protected]> * feat: implement WASM loading optimization to enhance plugin instance creation speed Signed-off-by: Deluan <[email protected]> * refactor: rename custom runtime functions and update related tests for clarity Signed-off-by: Deluan <[email protected]> * refactor: enhance plugin structure with compilation handling and error reporting Signed-off-by: Deluan <[email protected]> * refactor: improve logging and context tracing in runtime and wasm base plugin Signed-off-by: Deluan <[email protected]> * refactor: enhance runtime management with scoped runtime and caching improvements Signed-off-by: Deluan <[email protected]> * refactor: implement EnsureCompiled method for improved plugin compilation handling Signed-off-by: Deluan <[email protected]> * refactor: implement cached module management with TTL for improved performance Signed-off-by: Deluan <[email protected]> * refactor: replace map with sync.Map Signed-off-by: Deluan <[email protected]> * refactor: adjust time tolerance in scrobble buffer repository tests to avoid flakiness Signed-off-by: Deluan <[email protected]> * refactor: enhance image processing with fallback mechanism for improved error handling Signed-off-by: Deluan <[email protected]> * docs: review test plugins readme Signed-off-by: Deluan <[email protected]> * feat: set default timeout for HTTP client to 10 seconds Signed-off-by: Deluan <[email protected]> * feat: enhance wasm instance pool with concurrency limits and timeout settings Signed-off-by: Deluan <[email protected]> * feat(discordrp): implement caching for processed image URLs with configurable TTL Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> |
||
|
|
b79e84a535 |
fix(scanner): update prometheus at the end of the scan (#4163)
* fix(scannner): use prometheus instance over noop if configured properly * Real Fix: move `WriteAfterScanMetrics` outside gofunc * refactor: remove unused artwork.CacheWarmer param from CallScan function Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
58367afaea |
refactor: external_metadata -> external.Provider (#3903)
* tests for TopSongs Signed-off-by: Deluan <[email protected]> * convert to Ginkgo Signed-off-by: Deluan <[email protected]> * consolidate tests Signed-off-by: Deluan <[email protected]> * rename external metadata -wip Signed-off-by: Deluan <[email protected]> * rename external metadata to extdata.Provider Signed-off-by: Deluan <[email protected]> * refactor tests - wip Signed-off-by: Deluan <[email protected]> * refactor test helpers Signed-off-by: Deluan <[email protected]> * remove reflection Signed-off-by: Deluan <[email protected]> * use mock.Mock Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * fix Signed-off-by: Deluan <[email protected]> * receive Agents interface in Provider constructor Signed-off-by: Deluan <[email protected]> * use mock for Agents Signed-off-by: Deluan <[email protected]> * tests for SimilarSongs Signed-off-by: Deluan <[email protected]> * remove duplication Signed-off-by: Deluan <[email protected]> * ArtistImage tests Signed-off-by: Deluan <[email protected]> * AlbumImage tests Signed-off-by: Deluan <[email protected]> * fix provider error handling Signed-off-by: Deluan <[email protected]> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <[email protected]> * UpdateAlbumInfo tests - wip Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * UpdateArtistInfo tests - wip Signed-off-by: Deluan <[email protected]> * clean up Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * fix test descriptions Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * refactor: rename extdata package to external Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
8732fc7226 |
fix(server): change log level for some unimportant messages
Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
0372339e1b |
fix(server): only build core.Agents once
Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
de37e0f720 |
feat(server): rename ScanSchedule conf to Scanner.Schedule, for consistency
Signed-off-by: Deluan <[email protected]> |
||
|
|
c795bcfcf7 |
feat(bfr): Big Refactor: new scanner, lots of new fields and tags, improvements and DB schema changes (#2709)
* fix(server): more race conditions when updating artist/album from external sources Signed-off-by: Deluan <[email protected]> * feat(scanner): add .gitignore syntax to .ndignore. Resolves #1394 Signed-off-by: Deluan <[email protected]> * fix(ui): null Signed-off-by: Deluan <[email protected]> * fix(scanner): pass configfile option to child process Signed-off-by: Deluan <[email protected]> * fix(scanner): resume interrupted fullScans Signed-off-by: Deluan <[email protected]> * fix(scanner): remove old scanner code Signed-off-by: Deluan <[email protected]> * fix(scanner): rename old metadata package Signed-off-by: Deluan <[email protected]> * fix(scanner): move old metadata package Signed-off-by: Deluan <[email protected]> * fix: tests Signed-off-by: Deluan <[email protected]> * chore(deps): update Go to 1.23.4 Signed-off-by: Deluan <[email protected]> * fix: logs Signed-off-by: Deluan <[email protected]> * fix(test): Signed-off-by: Deluan <[email protected]> * fix: log level Signed-off-by: Deluan <[email protected]> * fix: remove log message Signed-off-by: Deluan <[email protected]> * feat: add config for scanner watcher Signed-off-by: Deluan <[email protected]> * refactor: children playlists Signed-off-by: Deluan <[email protected]> * refactor: replace `interface{}` with `any` Signed-off-by: Deluan <[email protected]> * fix: smart playlists with genres Signed-off-by: Deluan <[email protected]> * fix: allow any tags in smart playlists Signed-off-by: Deluan <[email protected]> * fix: artist names in playlists Signed-off-by: Deluan <[email protected]> * fix: smart playlist's sort by tags Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to AlbumID3 Signed-off-by: Deluan <[email protected]> * refactor(subsonic): use generic JSONArray for OS arrays Signed-off-by: Deluan <[email protected]> * refactor(subsonic): use https in test Signed-off-by: Deluan <[email protected]> * feat(subsonic): add releaseTypes to AlbumID3 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add recordLabels to AlbumID3 Signed-off-by: Deluan <[email protected]> * refactor(subsonic): rename JSONArray to Array Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to AlbumID3 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to Child Signed-off-by: Deluan <[email protected]> * fix(scanner): do not pre-populate smart playlists Signed-off-by: Deluan <[email protected]> * feat(subsonic): implement a simplified version of ArtistID3. See https://github.com/opensubsonic/open-subsonic-api/discussions/120 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to album child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add contributors to mediafile Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add albumArtists to mediafile Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add displayArtist and displayAlbumArtist Signed-off-by: Deluan <[email protected]> * feat(subsonic): add displayComposer to Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add roles to ArtistID3 Signed-off-by: Deluan <[email protected]> * fix(subsonic): use " • " separator for displayComposer Signed-off-by: Deluan <[email protected]> * refactor: Signed-off-by: Deluan <[email protected]> * fix(subsonic): Signed-off-by: Deluan <[email protected]> * fix(subsonic): respect `PreferSortTags` config option Signed-off-by: Deluan <[email protected]> * refactor(subsonic): Signed-off-by: Deluan <[email protected]> * refactor: optimize purging non-unused tags Signed-off-by: Deluan <[email protected]> * refactor: don't run 'refresh artist stats' concurrently with other transactions Signed-off-by: Deluan <[email protected]> * refactor: Signed-off-by: Deluan <[email protected]> * fix: log message Signed-off-by: Deluan <[email protected]> * feat: add Scanner.ScanOnStartup config option, default true Signed-off-by: Deluan <[email protected]> * feat: better json parsing error msg when importing NSPs Signed-off-by: Deluan <[email protected]> * fix: don't update album's imported_time when updating external_metadata Signed-off-by: Deluan <[email protected]> * fix: handle interrupted scans and full scans after migrations Signed-off-by: Deluan <[email protected]> * feat: run `analyze` when migration requires a full rescan Signed-off-by: Deluan <[email protected]> * feat: run `PRAGMA optimize` at the end of the scan Signed-off-by: Deluan <[email protected]> * fix: don't update artist's updated_at when updating external_metadata Signed-off-by: Deluan <[email protected]> * feat: handle multiple artists and roles in smart playlists Signed-off-by: Deluan <[email protected]> * feat(ui): dim missing tracks Signed-off-by: Deluan <[email protected]> * fix: album missing logic Signed-off-by: Deluan <[email protected]> * fix: error encoding in gob Signed-off-by: Deluan <[email protected]> * feat: separate warnings from errors Signed-off-by: Deluan <[email protected]> * fix: mark albums as missing if they were contained in a deleted folder Signed-off-by: Deluan <[email protected]> * refactor: add participant names to media_file and album tables Signed-off-by: Deluan <[email protected]> * refactor: use participations in criteria, instead of m2m relationship Signed-off-by: Deluan <[email protected]> * refactor: rename participations to participants Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to album child Signed-off-by: Deluan <[email protected]> * fix: albumartist role case Signed-off-by: Deluan <[email protected]> * feat(scanner): run scanner as an external process by default Signed-off-by: Deluan <[email protected]> * fix(ui): show albumArtist names Signed-off-by: Deluan <[email protected]> * fix(ui): dim out missing albums Signed-off-by: Deluan <[email protected]> * fix: flaky test Signed-off-by: Deluan <[email protected]> * fix(server): scrobble buffer mapping. fix #3583 Signed-off-by: Deluan <[email protected]> * refactor: more participations renaming Signed-off-by: Deluan <[email protected]> * fix: listenbrainz scrobbling Signed-off-by: Deluan <[email protected]> * feat: send release_group_mbid to listenbrainz Signed-off-by: Deluan <[email protected]> * feat(subsonic): implement OpenSubsonic explicitStatus field (#3597) * feat: implement OpenSubsonic explicitStatus field * fix(subsonic): fix failing snapshot tests * refactor: create helper for setting explicitStatus * fix: store smaller values for explicit-status on database * test: ToAlbum explicitStatus * refactor: rename explicitStatus helper function --------- Co-authored-by: Deluan Quintão <[email protected]> * fix: handle album and track tags in the DB based on the mappings.yaml file Signed-off-by: Deluan <[email protected]> * save similar artists as JSONB Signed-off-by: Deluan <[email protected]> * fix: getAlbumList byGenre Signed-off-by: Deluan <[email protected]> * detect changes in PID configuration Signed-off-by: Deluan <[email protected]> * set default album PID to legacy_pid Signed-off-by: Deluan <[email protected]> * fix tests Signed-off-by: Deluan <[email protected]> * fix SIGSEGV Signed-off-by: Deluan <[email protected]> * fix: don't lose album stars/ratings when migrating Signed-off-by: Deluan <[email protected]> * store full PID conf in properties Signed-off-by: Deluan <[email protected]> * fix: keep album annotations when changing PID.Album config Signed-off-by: Deluan <[email protected]> * fix: reassign album annotations Signed-off-by: Deluan <[email protected]> * feat: use (display) albumArtist and add links to each artist Signed-off-by: Deluan <[email protected]> * fix: not showing albums by albumartist Signed-off-by: Deluan <[email protected]> * fix: error msgs Signed-off-by: Deluan <[email protected]> * fix: hide PID from Native API Signed-off-by: Deluan <[email protected]> * fix: album cover art resolution Signed-off-by: Deluan <[email protected]> * fix: trim participant names Signed-off-by: Deluan <[email protected]> * fix: reduce watcher log spam Signed-off-by: Deluan <[email protected]> * fix: panic when initializing the watcher Signed-off-by: Deluan <[email protected]> * fix: various artists Signed-off-by: Deluan <[email protected]> * fix: don't store empty lyrics in the DB Signed-off-by: Deluan <[email protected]> * remove unused methods Signed-off-by: Deluan <[email protected]> * drop full_text indexes, as they are not being used by SQLite Signed-off-by: Deluan <[email protected]> * keep album created_at when upgrading Signed-off-by: Deluan <[email protected]> * fix(ui): null pointer Signed-off-by: Deluan <[email protected]> * fix: album artwork cache Signed-off-by: Deluan <[email protected]> * fix: don't expose missing files in Subsonic API Signed-off-by: Deluan <[email protected]> * refactor: searchable interface Signed-off-by: Deluan <[email protected]> * fix: filter out missing items from subsonic search * fix: filter out missing items from playlists * fix: filter out missing items from shares Signed-off-by: Deluan <[email protected]> * feat(ui): add filter by artist role Signed-off-by: Deluan <[email protected]> * feat(subsonic): only return albumartists in getIndexes and getArtists endpoints Signed-off-by: Deluan <[email protected]> * sort roles alphabetically Signed-off-by: Deluan <[email protected]> * fix: artist playcounts Signed-off-by: Deluan <[email protected]> * change default Album PID conf Signed-off-by: Deluan <[email protected]> * fix albumartist link when it does not match any albumartists values Signed-off-by: Deluan <[email protected]> * fix `Ignoring filter not whitelisted` (role) message Signed-off-by: Deluan <[email protected]> * fix: trim any names/titles being imported Signed-off-by: Deluan <[email protected]> * remove unused genre code Signed-off-by: Deluan <[email protected]> * serialize calls to Last.fm's getArtist Signed-off-by: Deluan <[email protected]> xxx Signed-off-by: Deluan <[email protected]> * add counters to genres Signed-off-by: Deluan <[email protected]> * nit: fix migration `notice` message Signed-off-by: Deluan <[email protected]> * optimize similar artists query Signed-off-by: Deluan <[email protected]> * fix: last.fm.getInfo when mbid does not exist Signed-off-by: Deluan <[email protected]> * ui only show missing items for admins Signed-off-by: Deluan <[email protected]> * don't allow interaction with missing items Signed-off-by: Deluan <[email protected]> * Add Missing Files view (WIP) Signed-off-by: Deluan <[email protected]> * refactor: merged tag_counts into tag table Signed-off-by: Deluan <[email protected]> * add option to completely disable automatic scanner Signed-off-by: Deluan <[email protected]> * add delete missing files functionality Signed-off-by: Deluan <[email protected]> * fix: playlists not showing for regular users Signed-off-by: Deluan <[email protected]> * reduce updateLastAccess frequency to once every minute Signed-off-by: Deluan <[email protected]> * reduce update player frequency to once every minute Signed-off-by: Deluan <[email protected]> * add timeout when updating player Signed-off-by: Deluan <[email protected]> * remove dead code Signed-off-by: Deluan <[email protected]> * fix duplicated roles in stats Signed-off-by: Deluan <[email protected]> * add `; ` to artist splitters Signed-off-by: Deluan <[email protected]> * fix stats query Signed-off-by: Deluan <[email protected]> * more logs Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * add record label filter Signed-off-by: Deluan <[email protected]> * add release type filter Signed-off-by: Deluan <[email protected]> * fix purgeUnused tags Signed-off-by: Deluan <[email protected]> * add grouping filter to albums Signed-off-by: Deluan <[email protected]> * allow any album tags to be used in as filters in the API Signed-off-by: Deluan <[email protected]> * remove empty tags from album info Signed-off-by: Deluan <[email protected]> * comments in the migration Signed-off-by: Deluan <[email protected]> * fix: Cannot read properties of undefined Signed-off-by: Deluan <[email protected]> * fix: listenbrainz scrobbling (#3640) Signed-off-by: Deluan <[email protected]> * fix: remove duplicated tag values Signed-off-by: Deluan <[email protected]> * fix: don't ignore the taglib folder! Signed-off-by: Deluan <[email protected]> * feat: show track subtitle tag Signed-off-by: Deluan <[email protected]> * fix: show artists stats based on selected role Signed-off-by: Deluan <[email protected]> * fix: inspect Signed-off-by: Deluan <[email protected]> * add media type to album info/filters Signed-off-by: Deluan <[email protected]> * fix: change format of subtitle in the UI Signed-off-by: Deluan <[email protected]> * fix: subtitle in Subsonic API and search Signed-off-by: Deluan <[email protected]> * fix: subtitle in UI's player Signed-off-by: Deluan <[email protected]> * fix: split strings should be case-insensitive Signed-off-by: Deluan <[email protected]> * disable ScanSchedule Signed-off-by: Deluan <[email protected]> * increase default sessiontimeout Signed-off-by: Deluan <[email protected]> * add sqlite command line tool to docker image Signed-off-by: Deluan <[email protected]> * fix: resources override Signed-off-by: Deluan <[email protected]> * fix: album PID conf Signed-off-by: Deluan <[email protected]> * change migration to mark current artists as albumArtists Signed-off-by: Deluan <[email protected]> * feat(ui): Allow filtering on multiple genres (#3679) * feat(ui): Allow filtering on multiple genres Signed-off-by: Henrik Nordvik <[email protected]> Signed-off-by: Deluan <[email protected]> * add multi-genre filter in Album list Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Henrik Nordvik <[email protected]> Signed-off-by: Deluan <[email protected]> Co-authored-by: Henrik Nordvik <[email protected]> * add more multi-valued tag filters to Album and Song views Signed-off-by: Deluan <[email protected]> * fix(ui): unselect missing files after removing Signed-off-by: Deluan <[email protected]> * fix(ui): song filter Signed-off-by: Deluan <[email protected]> * fix sharing tracks. fix #3687 Signed-off-by: Deluan <[email protected]> * use rowids when using search for sync (ex: Symfonium) Signed-off-by: Deluan <[email protected]> * fix "Report Real Paths" option for subsonic clients Signed-off-by: Deluan <[email protected]> * fix "Report Real Paths" option for subsonic clients for search Signed-off-by: Deluan <[email protected]> * add libraryPath to Native API /songs endpoint Signed-off-by: Deluan <[email protected]> * feat(subsonic): add album version Signed-off-by: Deluan <[email protected]> * made all tags lowercase as they are case-insensitive anyways. Signed-off-by: Deluan <[email protected]> * feat(ui): Show full paths, extended properties for album/song (#3691) * feat(ui): Show full paths, extended properties for album/song - uses library path + os separator + path - show participants (album/song) and tags (song) - make album/participant clickable in show info * add source to path * fix pathSeparator in UI Signed-off-by: Deluan <[email protected]> * fix local artist artwork (#3695) Signed-off-by: Deluan <[email protected]> * fix: parse vorbis performers Signed-off-by: Deluan <[email protected]> * refactor: clean function into smaller functions Signed-off-by: Deluan <[email protected]> * fix translations for en and pt Signed-off-by: Deluan <[email protected]> * add trace log to show annotations reassignment Signed-off-by: Deluan <[email protected]> * add trace log to show annotations reassignment Signed-off-by: Deluan <[email protected]> * fix: allow performers without instrument/subrole Signed-off-by: Deluan <[email protected]> * refactor: metadata clean function again Signed-off-by: Deluan <[email protected]> * refactor: optimize split function Signed-off-by: Deluan <[email protected]> * refactor: split function is now a method of TagConf Signed-off-by: Deluan <[email protected]> * fix: humanize Artist total size Signed-off-by: Deluan <[email protected]> * add album version to album details Signed-off-by: Deluan <[email protected]> * don't display album-level tags in SongInfo Signed-off-by: Deluan <[email protected]> * fix genre clicking in Album Page Signed-off-by: Deluan <[email protected]> * don't use mbids in Last.fm api calls. From https://discord.com/channels/671335427726114836/704303730660737113/1337574018143879248: With MBID: ``` GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&mbid=a41ac10f-0a56-4672-9161-b83f9b223559&method=artist.getInfo { artist: { name: "Bee Gees", mbid: "bf0f7e29-dfe1-416c-b5c6-f9ebc19ea810", url: "https://www.last.fm/music/Bee+Gees", } ``` Without MBID: ``` GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&method=artist.getInfo { artist: { name: "Van Morrison", mbid: "a41ac10f-0a56-4672-9161-b83f9b223559", url: "https://www.last.fm/music/Van+Morrison", } ``` Signed-off-by: Deluan <[email protected]> * better logging for when the artist folder is not found Signed-off-by: Deluan <[email protected]> * fix various issues with artist image resolution Signed-off-by: Deluan <[email protected]> * hide "Additional Tags" header if there are none. Signed-off-by: Deluan <[email protected]> * simplify tag rendering Signed-off-by: Deluan <[email protected]> * enhance logging for artist folder detection Signed-off-by: Deluan <[email protected]> * make folderID consistent for relative and absolute folderPaths Signed-off-by: Deluan <[email protected]> * handle more folder paths scenarios Signed-off-by: Deluan <[email protected]> * filter out other roles when SubsonicArtistParticipations = true Signed-off-by: Deluan <[email protected]> * fix "Cannot read properties of undefined" Signed-off-by: Deluan <[email protected]> * fix lyrics and comments being truncated (#3701) * fix lyrics and comments being truncated * specifically test for lyrics and comment length * reorder assertions Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> * fix(server): Expose library_path for playlist (#3705) Allows showing absolute path for UI, and makes "report real path" work for playlists (Subsonic) * fix BFR on Windows (#3704) * fix potential reflected cross-site scripting vulnerability Signed-off-by: Deluan <[email protected]> * hack to make it work on Windows * ignore windows executables * try fixing the pipeline Signed-off-by: Deluan <[email protected]> * allow MusicFolder in other drives * move windows local drive logic to local storage implementation --------- Signed-off-by: Deluan <[email protected]> * increase pagination sizes for missing files Signed-off-by: Deluan <[email protected]> * reduce level of "already scanning" watcher log message Signed-off-by: Deluan <[email protected]> * only count folders with audio files in it See https://github.com/navidrome/navidrome/discussions/3676#discussioncomment-11990930 Signed-off-by: Deluan <[email protected]> * add album version and catalog number to search Signed-off-by: Deluan <[email protected]> * add `organization` alias for `recordlabel` Signed-off-by: Deluan <[email protected]> * remove mbid from Last.fm agent Signed-off-by: Deluan <[email protected]> * feat: support inspect in ui (#3726) * inspect in ui * address round 1 * add catalogNum to AlbumInfo Signed-off-by: Deluan <[email protected]> * remove dependency on metadata_old (deprecated) package Signed-off-by: Deluan <[email protected]> * add `RawTags` to model Signed-off-by: Deluan <[email protected]> * support parsing MBIDs for roles (from the https://github.com/kgarner7/picard-all-mbids plugin) (#3698) * parse standard roles, vorbis/m4a work for now * fix djmixer * working roles, use DJ-mix * add performers to file * map mbids * add a few more tests * add test Signed-off-by: Deluan <[email protected]> * try to simplify the performers logic Signed-off-by: Deluan <[email protected]> * stylistic changes --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> * remove param mutation Signed-off-by: Deluan <[email protected]> * run automated SQLite optimizations Signed-off-by: Deluan <[email protected]> * fix playlists import/export on Windows * fix import playlists * fix export playlists * better handling of Windows volumes Signed-off-by: Deluan <[email protected]> * handle more album ID reassignments Signed-off-by: Deluan <[email protected]> * allow adding/overriding tags in the config file Signed-off-by: Deluan <[email protected]> * fix(ui): Fix playlist track id, handle missing tracks better (#3734) - Use `mediaFileId` instead of `id` for playlist tracks - Only fetch if the file is not missing - If extractor fails to get the file, also error (rather than panic) * optimize DB after each scan. Signed-off-by: Deluan <[email protected]> * remove sortable from AlbumSongs columns Signed-off-by: Deluan <[email protected]> * simplify query to get missing tracks Signed-off-by: Deluan <[email protected]> * mark Scanner.Extractor as deprecated Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Signed-off-by: Henrik Nordvik <[email protected]> Co-authored-by: Caio Cotts <[email protected]> Co-authored-by: Henrik Nordvik <[email protected]> Co-authored-by: Kendall Garner <[email protected]> |
||
|
|
3179966270 |
fix(metrics): write system metrics on start (#3641)
* fix(metrics): write system metrics on start * add broken basic auth test * refactor: simplify Prometheus instantiation Signed-off-by: Deluan <[email protected]> * fix: basic authentication Signed-off-by: Deluan <[email protected]> * refactor: move magic strings to constants Signed-off-by: Deluan <[email protected]> * refactor: simplify prometheus http handler Signed-off-by: Deluan <[email protected]> * add artist metadata to aggregrate sql --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Kendall GarnerandGitHub
|
d60e83176c |
feat(cli): support getting playlists via cli (#3634)
* feat(cli): support getting playlists via cli * address initial nit * use csv writer and csv instead |
||
|
|
f0302525a7 |
fix(server): use cancellable context instead of Sleep for initial insights delay (#3593)
* bugfix(server): use cancellable contet instead of sleep for initial insights delay * fix(server): initial delay time Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
0299e488b5 |
fix(server): backup and restore issues from the cli (#3579)
* fix(server): backup not working from cli Signed-off-by: Deluan <[email protected]> * fix(server): make backup-file required for restore Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
whorfinandGitHub
|
630c304080 |
fix(server): typo in backup prune message (#3582)
probably a copypasta oops |
||
|
Deluan QuintãoandGitHub
|
6c11649b06 |
fix(insights): fix issues and improve reports (#3558)
* fix(insights): show error whn reading library counts Signed-off-by: Deluan <[email protected]> * fix(insights): wait 30 mins before send first report Signed-off-by: Deluan <[email protected]> * fix(insights): send number of active players, grouped by client type Signed-off-by: Deluan <[email protected]> * fix(insights): disable reports when running in dev mode Signed-off-by: Deluan <[email protected]> * fix(insights): add Dockerfile to the docker build, to avoid `vcs.modified=true` Signed-off-by: Deluan <[email protected]> * fix(insights): add more linux fs types Signed-off-by: Deluan <[email protected]> * fix(insights): need admin permissions to retrieve library counts Signed-off-by: Deluan <[email protected]> * fix(insights): dev flag to disable player insights Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
8e2052ff95 |
feat(Insights): add anonymous usage data collection (#3543)
* feat(insights): initial code (WIP) * feat(insights): add more info * feat(insights): add fs info * feat(insights): export insights.Data Signed-off-by: Deluan <[email protected]> * feat(insights): more config info Signed-off-by: Deluan <[email protected]> * refactor(insights): move data struct to its own package Signed-off-by: Deluan <[email protected]> * refactor(insights): omit some attrs if empty Signed-off-by: Deluan <[email protected]> * feat(insights): send insights to server, add option to disable Signed-off-by: Deluan <[email protected]> * fix(insights): remove info about anonymous login Signed-off-by: Deluan <[email protected]> * chore(insights): fix lint Signed-off-by: Deluan <[email protected]> * fix(insights): disable collector if EnableExternalServices is false Signed-off-by: Deluan <[email protected]> * fix(insights): fix type casting for 32bit platforms Signed-off-by: Deluan <[email protected]> * fix(insights): remove EnableExternalServices from the collection (as it will always be false) Signed-off-by: Deluan <[email protected]> * chore(insights): fix lint Signed-off-by: Deluan <[email protected]> * refactor(insights): rename function for consistency Signed-off-by: Deluan <[email protected]> * feat(insights): log the data sent to the collector server Signed-off-by: Deluan <[email protected]> * feat(insights): add last collection timestamp to the "about" dialog. Also add opt-out info to the SignUp form Signed-off-by: Deluan <[email protected]> * feat(insights): only sends the initial data collection after an admin user is created Signed-off-by: Deluan <[email protected]> * feat(insights): remove dangling comment Signed-off-by: Deluan <[email protected]> * feat(insights): Translate insights messages Signed-off-by: Deluan <[email protected]> * fix(insights): reporting empty library Signed-off-by: Deluan <[email protected]> * refactor: move URL to consts.js Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
3982ba7258 |
revert: separation of write and read DBs
Signed-off-by: Deluan <[email protected]> |
||
|
|
154e13f7c9 |
build: add packages for deb and rpm to release (#3202)
* support packing deb/rpm/archlinux * .-. * initial test * fix postinstall, remove execstop * bash -> sh, create toml manually if it doesn't exist (thanks debian) * don't forget that newline * postrm * comments, contrib -> packaging/linux * contrib > packaging in .goreleaser * actually add toml * openrc/sysv templates * add apk. nothing else yet * wait, we have a ntive uninstall * fix: merge errors, move packaging to release * chore: remove old goreleaser conf * ci: remove `release` dependency on `docker push` * ci: fix release version * ci: upload packages * ci: try to fix json file list * ci: replace the json file list with a txt artifact * postremove -> preremove, skip install/remove error * actually do preremove * better preremove * ci: fix * ci: fix? * ci: clean-up * ci: try to change labels and filenames * ci: fix? * ci: fix? * ci: add `make package` target * ci: make labels more readable hope it doesn't break the pipeline again * build: remove alpine and archlinux packages, for now. --------- Co-authored-by: Deluan <[email protected]> |
||
|
|
9c3b456165 |
feat(build): MSI installer improvements (#3376)
* feat(build): add a make target to build a msi installer locally * Testing wrapping the executable in cmd * build(ci): build msis in parallel * feat(server): add LogFile config option * Revert "Testing wrapping the executable in cmd" This reverts commit be29592254cb903fd4904f2f50d4d1a860795d33. * Adding --log-file for service executable * feat(ini): wip * feat(ini): parse nested ini section * fix(conf): fix fatal error messages * Now navidrome supports INI, we can use the built-in msi ini system and not require the VBScript to convert it into toml * File needs to be called .ini to be parsed as an INI and correct filename needs to be passed to the service * fix(msi): build msi locally * fix(msi): pipeline * fix(msi): pipeline * fix(msi): pipeline * fix(msi): pipeline * fix(msi): pipeline * fix(msi): Makefile * fix(msi): more clean up * fix(log): convert LF to CRLF on Windows * fix(msi): config filename should be case-insensitive * fix(msi): make it a little more idiomatic * Including the latest windows release of ffmpeg into the msi as built by https://www.gyan.dev/ffmpeg/builds/ (linked to on the official ffmpeg source) * This should version independent * Need bash expansion for the * to work * This will run twice, once for x86 and once for x64, I'll make it cache the executable for now as it'll be quicker * Silencing wget * Add ffmpeg path to the config so Navidrome knows where to find it * refactor: download ffmpeg from our repository * When going back from the "Are you ready to install?" it should go back to the Settings dialogue that you just came from * fix: comments --------- Co-authored-by: Deluan <[email protected]> |
||
|
|
55730514ea |
feat(server): provide native backup/restore mechanism (#3194)
* [enhancement]: Provide native backup/restore mechanism - db.go: add Backup/Restore functions that utilize Sqlite's built-in online backup mechanism - support automatic backup with schedule, limit number of files - provide commands to manually backup/restore Navidrome Notes: `Step(-1)` results in a read-only lock being held for the entire duration of the backup. This will block out any other write operation (and may hold additional locks. An alternate implementation that doesn't block but instead retries is available at https://www.sqlite.org/backup.html#:~:text=of%20a%20Running-,database,-%2F*%0A**%20Perform%20an%20online (easily adaptable to go), but has the potential problem of continually getting restarted by background writes. Additionally, the restore should still only be called when Navidrome is offline, as the restore process does not run migrations that are missing. * remove empty line * add more granular backup schedule * do not remove files when bypass is set * move prune * refactor: small nitpicks * change commands and flags * tests, return path from backup * refactor: small nitpicks --------- Co-authored-by: Deluan <[email protected]> |
||
|
|
768160b05e |
feat: Windows MSI installer and service support (#3125)
* First version/rough layout of the required wix to build an MSI that embeds everything * Don't need revision number * produced exe from existing build process is navidrome not Navidrome * Adding Kardianos wrapper around Cobra so the callbacks are handled automatically (this is basically only for windows) * Adding pointless check to shut up lint for now * make format * Revert disabling npm tidy * Using Kardianos always will result in the application hanging so it needs only be wrapped to handle the callbacks if it's being used in the service context, otherwise use cobra directly * Copying in service installation etc from https://github.com/navidrome/navidrome/pull/2295 * Under Linux this installs a user service (I don't think this is correct, but lets get this working first). User units/services cannot depends on system units, so previously this bombed out with Exit Code 5. * Under Windows we can install both the x86 and x64 builds, they will install to different folders, but previously they would overwrite the service as they were both called Navidrome. Now, it will install 2 services. This will still be weird/broken as they will attempt to listen on the same port, however uninstalling the "wrong" arch will not cause the "right" one to be partially uninstalled anymore * Reverting changes to the context as they don't really seem necessary anyway * Need to consistently name the service * Fixing broken context * The included files should be removed when the app is uninstalled * Reverting back to the original context here, I don't think it makes any difference to running under kardianos * Let's see what we have immediately available * OK, the build takes ages so let's just try and do the whole thing in one go, maybe we'll get lucky * Need -r on directory copy, plus we'll probably need to install wixl * No sudo cmd, so I assume this runs as root * WORKSPACE! * Moving the version to be a single variable, we'll probably be able to pull it from the github tag or whatever * Might as well put the msi in the right folder, it's tidier * Writing the version number into the msi, from the output of goreleaser * Using jq to parse the goreleaser metadata, so need to install it * MSI only supports numerical version numbers, so I'll make the "snapshot" version .1 minor patch greater * -r or --raw (on newer versions) means we don't get the "" around the value * Running as a user service I think makes limited sense for this * Will now ask for configuration settings during install. MSI/WiX only supports writing out INI files, Toml is almost INI compatable, except that the INI needs to write out a section first, so we need to have a script to strip that off. We are forced to display a License.rtf file by the UI so I think the build process should probably rename the default licence file and that will suffice. Uninstalling works cleanly, howvever upgrades seem to leave the old version installed in "programs and features" currently. Adding the UI has introduced a requirement for WiX 0.103 * Updating the build to include --ext ui for the new config ui * Configuration dialog should not display for upgrades as the config file is already written * Making description consistent with the systemd service and making the build process produce the required License.rtf * Fixing " non-constant format string in call to fmt.Errorf (govet)" * Its a string, not an int; read better. * Wixl 103 is required for --ext ui, so we need 24.04 * OK this is still installing Wix 0.101, maybe it all needs to be 24.04? * Switching the builds back to ubuntu-latest (22.04 at current) as it runs on a custom container, it's actually debian anyway Moving msi build into its own job so it can run on 24.04 so we have access to wixl 0.103 for --ext ui support * Forcing build * Whitespace fix * Adding sudo I guess * Gotta checkout as well * Adding debugging for when there's soemthing wrong with the paths * Adding more ls to see if the output has worked * The msi's are in subdirs * Actually they're in the ./wix directory * Still can't find these msi's? * I think that was being treated literally previously * No idea why this isn't working, give it a relative path instead? * Making explicit on the dialogue that the configuration file will be where the installation dir is * The lint keeps failing and it's just getting in the way so I'll turn this off for now and we'll edit out this commit from the merge * Cutting more out of the build to get more stuff out of the way * Need to increase the width to fit the text in * Calling everything License.rtf, presumably one of them is correct * I am pretty sure the License.rtf loading is broken under Wixl; so let's just bypass the EULA from the UI which is a nicer experience for the users anyway * This needs to be after WelcomeDlg now the Eula isn't displayed * You're supposed to be able to use <WixVariable> to override the location that the bmp's are loaded from, I can't get this to work under wixl so I'm guessing given that the ui extension is new, it hasn't been implemented with that in mind. So we'll hack it by overwriting the files installed with the package. * We should make this less brittle so when wixl is updated it still works * Re-enabling the lint and tests etc * Improving the scaling quality and removing borders from images to tidy them up a tad * Pretty sure this isn't necessary as MY_PROPERTY will always be false * Without publishing this event, we can't continue to the next dialogue however I think we should be able to get away without the property * Refactoring out the duplication so we only have one service defined and we can run that either way * Pushing the Interactive check into the root commmand? Feels like it is probably getting closer to the right place at least * go tidy * OK this didn't work under windows, I'm guessing it's because it's lacking all the metadata about the service it needs to report back to Windows on. * We need to run service execute now so that the windows service will behave (hopefully)! * Lint * go tidy * Renaming service to "navidrome" rather than "Navidrome" as this is the filename that systemd writes and it's unusual to have capital letters in service names under Linux. Switching to use service execute for Linux to mirror Windows * Need to provide the arguments to append * Without passing the context around, the DB isn't closed gracefully so we end up with with .db-shm and .db-wal files for recovery * We should log fatal rather than outputting directly to stdout * go tidy * refactor: small nitpicks * fix: terminate service gracefully --------- Co-authored-by: Deluan Quintão <[email protected]> |
||
|
Deluan
|
5be73d404f | fix(server): allow changing local login background url | ||
|
Deluan
|
55bff343cd |
Optimize SQLite3 access. Mainly separate read access from write access.
Based on tips from https://archive.is/Xfjh6#selection-257.0-278.0 |
||
|
Deluan
|
747069b229 | Remove unused code | ||
|
Deluan
|
885cd345ab | Clean up runNavidrome function | ||
|
Deluan QuintãoandGitHub
|
6408dda948 |
Terminate all MPV instances when stopping Navidrome (#3008)
* Terminate all mpv instances when stopping Navidrome * Exit trackSwitcher goroutine when terminating * Remove potential race condition when starting the Playback device * Fix lint error * Removed unused and unneeded vars/functions * Use device short name in log * Small refactor * Small nitpick * Make start functions more uniform |
||
|
Deluan
|
677d9947f3 | Make dependency injection more consistent | ||
|
Deluan
|
7c5eec715d | Fix typo | ||
|
Deluan
|
7ab7b5df5e | Fix signaler on Windows | ||
|
Deluan
|
3d9fff36f7 | Use signal.NotifyContext | ||
|
Deluan
|
28f7ef43c1 | Remove AlbumPlayCountMode from command line options | ||
|
vvdveenandDeluan
|
8bff1ad512 |
Add AlbumPlayCountMode config option (#2803)
Closes #1032 * feat(album_repository.go): add kodi-style album playcount option - #1032 Signed-off-by: Victor van der Veen <[email protected]> * fix format issue and remove reference to kodi (now normalized) Signed-off-by: Victor van der Veen <[email protected]> * reduced complexity but added rounding Signed-off-by: Victor van der Veen <[email protected]> * Use constants for AlbumPlayCountMode values --------- Signed-off-by: Victor van der Veen <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan
|
87484fe7a9 | Bump github.com/google/wire to 0.6.0 | ||
|
|
8f03454312 |
Make server unix socket file permission configurable via flag UnixSocketPerm (#2763)
* feat(any): Add flag unixsocketperm with default 0017 - #2625 Signed-off-by: johannesengl <[email protected]> * feat(server): Update unix socket file perm based on config - #2625 Signed-off-by: johannesengl <[email protected]> * Fix default value of socket. * Refactor unix socket file creation. * Remove misplaced comment --------- Signed-off-by: johannesengl <[email protected]> Co-authored-by: Caio Cotts <[email protected]> Co-authored-by: Deluan <[email protected]> |
||
|
Deluan
|
798b03eabd | Add "inspect" command to CLI | ||
|
|
26472f46fe |
POST endpoint for importing m3u playlists - #2078 (#2273)
* wip: API endpoint for creating playlists from m3u files * wip: get user id from context * temporarily disable failing test * custom logic for playlist route to accomodate m3u content type * incorporate playlist parsing into existing logic in core * re-enable test * fix locally failing test * Address requested changes. * Improve ImportFile tests. * Remove ownerID as a parameter of ImportM3U. * Write tests for ImportM3U. * Separate ImportM3U test into two. * Test OwnerID and playlist Name. --------- Co-authored-by: Sam Watson <[email protected]> Co-authored-by: caiocotts <[email protected]> |