f03ca44a8e
feat(plugins): add lyrics provider plugin capability ( #5126 )
...
* feat(plugins): add lyrics provider plugin capability
Refactor the lyrics system from a static function to an interface-based
service that supports WASM plugin providers. Plugins listed in the
LyricsPriority config (alongside "embedded" and file extensions) are
now resolved through the plugin system.
Includes capability definition, Go/Rust PDK, adapter, Wire integration,
and tests for plugin fallback behavior.
* test(plugins): add lyrics capability integration test with test plugin
* fix(plugins): default lyrics language to 'xxx' when plugin omits it
Per the OpenSubsonic spec, the server must return 'und' or 'xxx' when
the lyrics language is unknown. The lyrics plugin adapter was passing
an empty string through when a plugin didn't provide a language value.
This defaults the language to 'xxx', consistent with all other callers
of model.ToLyrics() in the codebase.
* refactor(plugins): rename lyrics import to improve clarity
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(lyrics): update TrackInfo description for clarity
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(lyrics): enhance lyrics plugin handling and case sensitivity
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(plugins): update payload type to string with byte format for task data
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2026-03-03 15:48:39 -05:00
a704e86ac1
refactor: run Go modernize ( #5002 )
2026-02-08 09:57:30 -05:00
8d594671c4
fix(subsonic): Sort songs by presence of lyrics for getLyrics ( #4237 )
...
* fix(subsonic): Sort songs by presence of lyrics for `getLyrics`
The current implementation of `getLyrics` fetches any songs matching the artist and title.
However, this misses a case where there may be multiple matches for the same artist/song, and one has lyrics while the other doesn't.
Resolve this by adding a custom SQL dynamic column that checks for the presence of lyrics.
* add options to selectMediaFile, update test
* more robust testing of GetAllByLyrics
* fix(subsonic): refactor GetAllByLyrics to GetAll with lyrics sorting
Signed-off-by: Deluan <deluan@navidrome.org >
* use has_lyrics, and properly support multiple sort parts
* better handle complicated internal sorts
* just use a simpler filter
* add note to setSortMappings
* remove custom sort mapping, improve test with different updatedat
* refactor tests and mock
Signed-off-by: Deluan <deluan@navidrome.org >
* default order when not specified is `asc`
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
2025-06-16 12:04:41 -04:00
9249659773
fix(subsonic): getLyrics does not try to retrieve lyrics from external files ( #4232 )
2025-06-15 12:40:40 -04:00
924354eb4b
fix(subsonic): find lyrics by artist or albumartist ( #4093 )
...
* find artist by multivalued exact match, instead of 'artist' field
* check if lyrics are not empty
* refactor(filters): rename function to better reflect its purpose
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
2025-05-21 09:36:26 -04:00
ec9f9aa243
feat:(server): support reading lyrics from filesystem ( #2897 )
...
* simplified lyrics handling
* address initial feedback
* add some trace and error logging
* allow fallback lyrics
* update nit
* restore artist/title filter only
2025-04-30 08:10:19 -04:00
d6ec52b9d4
fix(subsonic): check errors before setting headers for getCoverArt
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-02-25 08:22:38 -05:00
c795bcfcf7
feat(bfr): Big Refactor: new scanner, lots of new fields and tags, improvements and DB schema changes ( #2709 )
...
* fix(server): more race conditions when updating artist/album from external sources
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(scanner): add .gitignore syntax to .ndignore. Resolves #1394
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): null
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): pass configfile option to child process
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): resume interrupted fullScans
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): remove old scanner code
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): rename old metadata package
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): move old metadata package
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: tests
Signed-off-by: Deluan <deluan@navidrome.org >
* chore(deps): update Go to 1.23.4
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: logs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(test):
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: log level
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: remove log message
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: add config for scanner watcher
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: children playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: replace `interface{}` with `any`
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: smart playlists with genres
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: allow any tags in smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: artist names in playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: smart playlist's sort by tags
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): use generic JSONArray for OS arrays
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): use https in test
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add releaseTypes to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add recordLabels to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): rename JSONArray to Array
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to Child
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): do not pre-populate smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): implement a simplified version of ArtistID3.
See https://github.com/opensubsonic/open-subsonic-api/discussions/120
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to album child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add contributors to mediafile Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add albumArtists to mediafile Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add displayArtist and displayAlbumArtist
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add displayComposer to Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add roles to ArtistID3
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): use " • " separator for displayComposer
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor:
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic):
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): respect `PreferSortTags` config option
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic):
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: optimize purging non-unused tags
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: don't run 'refresh artist stats' concurrently with other transactions
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor:
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: log message
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: add Scanner.ScanOnStartup config option, default true
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: better json parsing error msg when importing NSPs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't update album's imported_time when updating external_metadata
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: handle interrupted scans and full scans after migrations
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: run `analyze` when migration requires a full rescan
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: run `PRAGMA optimize` at the end of the scan
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't update artist's updated_at when updating external_metadata
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: handle multiple artists and roles in smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): dim missing tracks
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album missing logic
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: error encoding in gob
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: separate warnings from errors
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: mark albums as missing if they were contained in a deleted folder
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: add participant names to media_file and album tables
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: use participations in criteria, instead of m2m relationship
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: rename participations to participants
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to album child
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: albumartist role case
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(scanner): run scanner as an external process by default
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): show albumArtist names
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): dim out missing albums
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: flaky test
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(server): scrobble buffer mapping. fix #3583
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: more participations renaming
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: listenbrainz scrobbling
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: send release_group_mbid to listenbrainz
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): implement OpenSubsonic explicitStatus field (#3597 )
* feat: implement OpenSubsonic explicitStatus field
* fix(subsonic): fix failing snapshot tests
* refactor: create helper for setting explicitStatus
* fix: store smaller values for explicit-status on database
* test: ToAlbum explicitStatus
* refactor: rename explicitStatus helper function
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
* fix: handle album and track tags in the DB based on the mappings.yaml file
Signed-off-by: Deluan <deluan@navidrome.org >
* save similar artists as JSONB
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: getAlbumList byGenre
Signed-off-by: Deluan <deluan@navidrome.org >
* detect changes in PID configuration
Signed-off-by: Deluan <deluan@navidrome.org >
* set default album PID to legacy_pid
Signed-off-by: Deluan <deluan@navidrome.org >
* fix tests
Signed-off-by: Deluan <deluan@navidrome.org >
* fix SIGSEGV
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't lose album stars/ratings when migrating
Signed-off-by: Deluan <deluan@navidrome.org >
* store full PID conf in properties
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: keep album annotations when changing PID.Album config
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: reassign album annotations
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: use (display) albumArtist and add links to each artist
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: not showing albums by albumartist
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: error msgs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: hide PID from Native API
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album cover art resolution
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: trim participant names
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: reduce watcher log spam
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: panic when initializing the watcher
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: various artists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't store empty lyrics in the DB
Signed-off-by: Deluan <deluan@navidrome.org >
* remove unused methods
Signed-off-by: Deluan <deluan@navidrome.org >
* drop full_text indexes, as they are not being used by SQLite
Signed-off-by: Deluan <deluan@navidrome.org >
* keep album created_at when upgrading
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): null pointer
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album artwork cache
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't expose missing files in Subsonic API
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: searchable interface
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: filter out missing items from subsonic search
* fix: filter out missing items from playlists
* fix: filter out missing items from shares
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): add filter by artist role
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): only return albumartists in getIndexes and getArtists endpoints
Signed-off-by: Deluan <deluan@navidrome.org >
* sort roles alphabetically
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: artist playcounts
Signed-off-by: Deluan <deluan@navidrome.org >
* change default Album PID conf
Signed-off-by: Deluan <deluan@navidrome.org >
* fix albumartist link when it does not match any albumartists values
Signed-off-by: Deluan <deluan@navidrome.org >
* fix `Ignoring filter not whitelisted` (role) message
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: trim any names/titles being imported
Signed-off-by: Deluan <deluan@navidrome.org >
* remove unused genre code
Signed-off-by: Deluan <deluan@navidrome.org >
* serialize calls to Last.fm's getArtist
Signed-off-by: Deluan <deluan@navidrome.org >
xxx
Signed-off-by: Deluan <deluan@navidrome.org >
* add counters to genres
Signed-off-by: Deluan <deluan@navidrome.org >
* nit: fix migration `notice` message
Signed-off-by: Deluan <deluan@navidrome.org >
* optimize similar artists query
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: last.fm.getInfo when mbid does not exist
Signed-off-by: Deluan <deluan@navidrome.org >
* ui only show missing items for admins
Signed-off-by: Deluan <deluan@navidrome.org >
* don't allow interaction with missing items
Signed-off-by: Deluan <deluan@navidrome.org >
* Add Missing Files view (WIP)
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: merged tag_counts into tag table
Signed-off-by: Deluan <deluan@navidrome.org >
* add option to completely disable automatic scanner
Signed-off-by: Deluan <deluan@navidrome.org >
* add delete missing files functionality
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: playlists not showing for regular users
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce updateLastAccess frequency to once every minute
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce update player frequency to once every minute
Signed-off-by: Deluan <deluan@navidrome.org >
* add timeout when updating player
Signed-off-by: Deluan <deluan@navidrome.org >
* remove dead code
Signed-off-by: Deluan <deluan@navidrome.org >
* fix duplicated roles in stats
Signed-off-by: Deluan <deluan@navidrome.org >
* add `; ` to artist splitters
Signed-off-by: Deluan <deluan@navidrome.org >
* fix stats query
Signed-off-by: Deluan <deluan@navidrome.org >
* more logs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* add record label filter
Signed-off-by: Deluan <deluan@navidrome.org >
* add release type filter
Signed-off-by: Deluan <deluan@navidrome.org >
* fix purgeUnused tags
Signed-off-by: Deluan <deluan@navidrome.org >
* add grouping filter to albums
Signed-off-by: Deluan <deluan@navidrome.org >
* allow any album tags to be used in as filters in the API
Signed-off-by: Deluan <deluan@navidrome.org >
* remove empty tags from album info
Signed-off-by: Deluan <deluan@navidrome.org >
* comments in the migration
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: Cannot read properties of undefined
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: listenbrainz scrobbling (#3640 )
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: remove duplicated tag values
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't ignore the taglib folder!
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: show track subtitle tag
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: show artists stats based on selected role
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: inspect
Signed-off-by: Deluan <deluan@navidrome.org >
* add media type to album info/filters
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: change format of subtitle in the UI
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: subtitle in Subsonic API and search
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: subtitle in UI's player
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: split strings should be case-insensitive
Signed-off-by: Deluan <deluan@navidrome.org >
* disable ScanSchedule
Signed-off-by: Deluan <deluan@navidrome.org >
* increase default sessiontimeout
Signed-off-by: Deluan <deluan@navidrome.org >
* add sqlite command line tool to docker image
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: resources override
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album PID conf
Signed-off-by: Deluan <deluan@navidrome.org >
* change migration to mark current artists as albumArtists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): Allow filtering on multiple genres (#3679 )
* feat(ui): Allow filtering on multiple genres
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Signed-off-by: Deluan <deluan@navidrome.org >
* add multi-genre filter in Album list
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Henrik Nordvik <henrikno@gmail.com >
* add more multi-valued tag filters to Album and Song views
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): unselect missing files after removing
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): song filter
Signed-off-by: Deluan <deluan@navidrome.org >
* fix sharing tracks. fix #3687
Signed-off-by: Deluan <deluan@navidrome.org >
* use rowids when using search for sync (ex: Symfonium)
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Report Real Paths" option for subsonic clients
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Report Real Paths" option for subsonic clients for search
Signed-off-by: Deluan <deluan@navidrome.org >
* add libraryPath to Native API /songs endpoint
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add album version
Signed-off-by: Deluan <deluan@navidrome.org >
* made all tags lowercase as they are case-insensitive anyways.
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): Show full paths, extended properties for album/song (#3691 )
* feat(ui): Show full paths, extended properties for album/song
- uses library path + os separator + path
- show participants (album/song) and tags (song)
- make album/participant clickable in show info
* add source to path
* fix pathSeparator in UI
Signed-off-by: Deluan <deluan@navidrome.org >
* fix local artist artwork (#3695 )
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: parse vorbis performers
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: clean function into smaller functions
Signed-off-by: Deluan <deluan@navidrome.org >
* fix translations for en and pt
Signed-off-by: Deluan <deluan@navidrome.org >
* add trace log to show annotations reassignment
Signed-off-by: Deluan <deluan@navidrome.org >
* add trace log to show annotations reassignment
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: allow performers without instrument/subrole
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: metadata clean function again
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: optimize split function
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: split function is now a method of TagConf
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: humanize Artist total size
Signed-off-by: Deluan <deluan@navidrome.org >
* add album version to album details
Signed-off-by: Deluan <deluan@navidrome.org >
* don't display album-level tags in SongInfo
Signed-off-by: Deluan <deluan@navidrome.org >
* fix genre clicking in Album Page
Signed-off-by: Deluan <deluan@navidrome.org >
* don't use mbids in Last.fm api calls.
From https://discord.com/channels/671335427726114836/704303730660737113/1337574018143879248 :
With MBID:
```
GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&mbid=a41ac10f-0a56-4672-9161-b83f9b223559&method=artist.getInfo
{
artist: {
name: "Bee Gees",
mbid: "bf0f7e29-dfe1-416c-b5c6-f9ebc19ea810",
url: "https://www.last.fm/music/Bee+Gees ",
}
```
Without MBID:
```
GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&method=artist.getInfo
{
artist: {
name: "Van Morrison",
mbid: "a41ac10f-0a56-4672-9161-b83f9b223559",
url: "https://www.last.fm/music/Van+Morrison ",
}
```
Signed-off-by: Deluan <deluan@navidrome.org >
* better logging for when the artist folder is not found
Signed-off-by: Deluan <deluan@navidrome.org >
* fix various issues with artist image resolution
Signed-off-by: Deluan <deluan@navidrome.org >
* hide "Additional Tags" header if there are none.
Signed-off-by: Deluan <deluan@navidrome.org >
* simplify tag rendering
Signed-off-by: Deluan <deluan@navidrome.org >
* enhance logging for artist folder detection
Signed-off-by: Deluan <deluan@navidrome.org >
* make folderID consistent for relative and absolute folderPaths
Signed-off-by: Deluan <deluan@navidrome.org >
* handle more folder paths scenarios
Signed-off-by: Deluan <deluan@navidrome.org >
* filter out other roles when SubsonicArtistParticipations = true
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Cannot read properties of undefined"
Signed-off-by: Deluan <deluan@navidrome.org >
* fix lyrics and comments being truncated (#3701 )
* fix lyrics and comments being truncated
* specifically test for lyrics and comment length
* reorder assertions
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
* fix(server): Expose library_path for playlist (#3705 )
Allows showing absolute path for UI, and makes "report real path" work for playlists (Subsonic)
* fix BFR on Windows (#3704 )
* fix potential reflected cross-site scripting vulnerability
Signed-off-by: Deluan <deluan@navidrome.org >
* hack to make it work on Windows
* ignore windows executables
* try fixing the pipeline
Signed-off-by: Deluan <deluan@navidrome.org >
* allow MusicFolder in other drives
* move windows local drive logic to local storage implementation
---------
Signed-off-by: Deluan <deluan@navidrome.org >
* increase pagination sizes for missing files
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce level of "already scanning" watcher log message
Signed-off-by: Deluan <deluan@navidrome.org >
* only count folders with audio files in it
See https://github.com/navidrome/navidrome/discussions/3676#discussioncomment-11990930
Signed-off-by: Deluan <deluan@navidrome.org >
* add album version and catalog number to search
Signed-off-by: Deluan <deluan@navidrome.org >
* add `organization` alias for `recordlabel`
Signed-off-by: Deluan <deluan@navidrome.org >
* remove mbid from Last.fm agent
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: support inspect in ui (#3726 )
* inspect in ui
* address round 1
* add catalogNum to AlbumInfo
Signed-off-by: Deluan <deluan@navidrome.org >
* remove dependency on metadata_old (deprecated) package
Signed-off-by: Deluan <deluan@navidrome.org >
* add `RawTags` to model
Signed-off-by: Deluan <deluan@navidrome.org >
* support parsing MBIDs for roles (from the https://github.com/kgarner7/picard-all-mbids plugin) (#3698 )
* parse standard roles, vorbis/m4a work for now
* fix djmixer
* working roles, use DJ-mix
* add performers to file
* map mbids
* add a few more tests
* add test
Signed-off-by: Deluan <deluan@navidrome.org >
* try to simplify the performers logic
Signed-off-by: Deluan <deluan@navidrome.org >
* stylistic changes
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
* remove param mutation
Signed-off-by: Deluan <deluan@navidrome.org >
* run automated SQLite optimizations
Signed-off-by: Deluan <deluan@navidrome.org >
* fix playlists import/export on Windows
* fix import playlists
* fix export playlists
* better handling of Windows volumes
Signed-off-by: Deluan <deluan@navidrome.org >
* handle more album ID reassignments
Signed-off-by: Deluan <deluan@navidrome.org >
* allow adding/overriding tags in the config file
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): Fix playlist track id, handle missing tracks better (#3734 )
- Use `mediaFileId` instead of `id` for playlist tracks
- Only fetch if the file is not missing
- If extractor fails to get the file, also error (rather than panic)
* optimize DB after each scan.
Signed-off-by: Deluan <deluan@navidrome.org >
* remove sortable from AlbumSongs columns
Signed-off-by: Deluan <deluan@navidrome.org >
* simplify query to get missing tracks
Signed-off-by: Deluan <deluan@navidrome.org >
* mark Scanner.Extractor as deprecated
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Co-authored-by: Caio Cotts <caio@cotts.com.br >
Co-authored-by: Henrik Nordvik <henrikno@gmail.com >
Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com >
2025-02-19 20:35:17 -05:00
0488fb92cb
Fix image stuttering ( #3035 )
...
* Fix image stuttering.
* Fix docker publishing for PRs
* Write tests for new square parameter.
* Simplify code for createImage.
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2024-05-24 20:19:26 -04:00
814161d78d
Add OS Lyrics extension ( #2656 )
...
* draft commit
* time to fight pipeline
* round 2 changes
* remove unnecessary line
* fight taglib. again
* make taglib work again???
* add id3 tags
* taglib 1.12 vs 1.13
* use int instead for windows
* store as json now
* add migration, more tests
* support repeated line, multiline
* fix ms and support .m, .mm, .mmm
* address some concerns, make cpp a bit safer
* separate responses from model
* remove [:]
* Add trace log
* Try to unblock pipeline
* Fix merge errors
* Fix SIGSEGV error (proper handling of empty frames)
* Add fallback artist/title to structured lyrics
* Rename conflicting named vars
* Fix tests
* Do we still need ffmpeg in the pipeline?
* Revert "Do we still need ffmpeg in the pipeline?"
Yes we do.
This reverts commit 87df7f6df79bccee83f48c4b7a8118a7636a5e66.
* Does this passes now, with a newer ffmpeg version?
* Revert "Does this passes now, with a newer ffmpeg version?"
No, it does not :(
This reverts commit 372eb4b0ae05d9ffe98078e9bc4e56a9b2921f32.
* My OCD made me do it :P
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2023-12-27 20:20:29 -05:00
dfcc189cff
Replace all utils.Param* with req.Params
2023-12-21 17:41:09 -05:00
588ee94f7c
Discard request for image canceled by the client before any further processing
2023-02-02 14:55:07 -05:00
d8e794317f
Return 404 when artwork is not available in /share/img endpoint
2023-02-01 10:34:02 -05:00
918fee3ea3
Artwork reader for Artist
2023-01-13 22:18:34 -05:00
722a00cacf
Fix artwork caching
2022-12-28 15:31:56 -05:00
a087f57d2d
Handle request (context) cancellation
2022-12-28 15:31:56 -05:00
abd3274250
Handle empty cover art ID in subsonic API
2022-12-28 15:31:56 -05:00
c5f7cf97f4
Some cleanup, adding missing context handling
2022-12-06 19:57:47 -05:00
19af11efbe
Simplify Subsonic API handler implementation
2022-11-21 12:57:56 -05:00
db67c1277e
Fix error comparisons
2022-09-30 18:54:25 -04:00
028723f721
Fix loading overridden translations from ${DataFolder}/resources/i18n
2022-02-10 14:56:39 -05:00
5621551dd0
Adds Lyrics Support to Subsonic API ( #1379 )
...
* Add function 'isSynced' that identifies if lyrics are synced or not and add tests for the same
* implement 'getLyrics' which returns lyrics if they exist
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com >
* remove timestamps frorom the the lyrics if they are synced, fix filters & clean up code
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com >
* add snapshot tests for the 'Lyrics' response & add some clean up
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com >
* add tests for 'GetLyrics' function
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com >
* update the snapshot test & the test for 'GetLyrics' function
Signed-off-by: Dheeraj Lalwani <lalwanidheeraj1234@gmail.com >
2021-10-19 16:33:06 -04:00
7540881695
Small refactorings
2021-07-20 19:18:29 -04:00
91a91f7e06
GetCoverArt returns placeholder if id is missing
...
This mimics Subsonic behaviour, even if it contradicts the API documentation, which states `id` is required
Fixes #1139
2021-05-29 11:37:00 -04:00
2d528bbc87
Remove dependency of go-bindata ( #818 )
...
* Use new embed functionality for serving UI assets
* Use new embed functionality for serving resources. Remove dependency on go-bindata
* Remove Go 1.15
2021-03-12 11:06:51 -05:00
5fdd8b32d7
Move utilitarian/generic packages to utils: lastfm, spotify, gravatar, cache, and pool
2021-02-09 15:33:33 -05:00
6ee45a9ccc
Move project to Navidrome GitHub organization
2021-02-06 21:46:35 -05:00
25ae1c6cdd
Return album art as a Reader
2020-12-02 09:13:36 -05:00
b64bb706f7
Use Gravatar in GetAvatar Subsonic API
2020-11-13 14:57:49 -05:00
4777cf0aba
Simplify error responses
2020-10-27 15:33:28 -04:00
04fd72e1fa
Change avatar placeholder to new logo
2020-10-23 21:37:53 -04:00
c271aa24d1
Make all Subsonic helper functions private
2020-08-14 12:10:37 -04:00
2b59d4b87a
Rename 'Cover' to the more generic term 'Artwork'
2020-07-31 11:38:56 -04:00
9e35534dad
Fix lint errors
...
New environment, forgot to setup it properly...
2020-07-10 13:11:02 -04:00
5620c58a30
Started the big refactor to extract common logic from engine package (Subsonic only) to core package (more generic)
2020-07-10 12:53:11 -04:00
51fb1d1349
Increase cover art max-age to maximum
2020-06-04 14:45:00 -04:00
888151728f
Increase album art placeholder's resolution
2020-06-03 09:40:37 -04:00
1a9663d432
Move static to resources. Embed them at build time
2020-05-02 14:19:01 -04:00
5cd453afeb
Fix all errcheck warnings
2020-04-26 15:07:36 -04:00
d308e7ca46
Fix typo
2020-04-05 17:49:14 -04:00
8b108905a3
feat: use Navidrome's icon in getAvatar
2020-03-18 22:46:47 -04:00
3b12c92ad5
feat: add cache to the getCoverArt endpoint, avoid it being reloaded every single time in the UI
2020-02-15 14:32:11 -05:00
8673533cd4
refactor: move request param extractors to utils
2020-02-06 18:55:38 -05:00
49f59fe9f4
Embed static files used by Subsonic API
2020-01-24 21:35:19 -05:00
bee55c04c8
Rename project to Navidrome
2020-01-23 19:44:08 -05:00
f0ee41a8af
Add context to all methods in engine layer
2020-01-22 08:39:57 -05:00
8a1110044c
Better error handling when cover art cannot be loaded
2020-01-20 22:30:16 -05:00
7610b42f4b
Moved package api to subsonic under server
2020-01-19 18:23:09 -05:00
Deluan Quintão