c193bb2a09
fix(server): headless library access improvements ( #4362 )
...
* fix: enable library access for headless processes
Fixed multi-library filtering to allow headless processes (shares, external providers) to access data by skipping library restrictions when no user context is present.
Previously, the library filtering system returned empty results (WHERE 1=0) for processes without user authentication, breaking functionality like public shares and external service integrations.
Key changes:
- Modified applyLibraryFilter methods to skip filtering when user.ID == invalidUserId
- Refactored tag repository to use helper method for library filtering logic
- Fixed SQL aggregation bug in tag statistics calculation across multiple libraries
- Added comprehensive test coverage for headless process scenarios
- Updated genre repository to support proper column mappings for aggregated data
This preserves the secure "safe by default" approach for authenticated users while restoring backward compatibility for background processes that need unrestricted data access.
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: resolve SQL ambiguity errors in share queries
Fixed SQL ambiguity errors that were breaking share links after the Multi-library PR.
The Multi-library changes introduced JOINs between album and library tables,
both of which have 'id' columns, causing 'ambiguous column name: id' errors
when unqualified column references were used in WHERE clauses.
Changes made:
- Updated core/share.go to use 'album.id' instead of 'id' in contentsLabelFromAlbums
- Updated persistence/share_repository.go to use 'album.id' in album share loading
- Updated persistence/sql_participations.go to use 'artist.id' for consistency
- Added regression tests to prevent future SQL ambiguity issues
This resolves HTTP 500 errors that users experienced when accessing existing
share URLs after the Multi-library feature was merged.
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: improve headless library access handling
Added proper user context validation and reordered joins in applyLibraryFilterToArtistQuery to ensure library filtering works correctly for both authenticated and headless operations. The user_library join is now only applied when a valid user context exists, while the library_artist join is always applied to maintain proper data relationships. (+1 squashed commit)
Squashed commits:
[a28c6965b] fix: remove headless library access guard
Removed the invalidUserId guard condition in applyLibraryFilterToArtistQuery that was preventing proper library filtering for headless operations. This fix ensures that library filtering joins are always applied consistently, allowing headless library access to work correctly with the library_artist junction table filtering.
The previous guard was skipping all library filtering when no user context was present, which could cause issues with headless operations that still need to respect library boundaries through the library_artist relationship.
* fix: simplify genre selection query in genre repository
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: enhance tag library filtering tests for headless access
Signed-off-by: Deluan <deluan@navidrome.org >
* test: add comprehensive test coverage for headless library access
Added extensive test coverage for headless library access improvements including:
- Added 17 new tests across 4 test files covering headless access scenarios
- artist_repository_test.go: Added headless process tests for GetAll, Count,
Get operations and explicit library_id filtering functionality
- genre_repository_test.go: Added library filtering tests for headless processes
including GetAll, Count, ReadAll, and Read operations
- sql_base_repository_test.go: Added applyLibraryFilter method tests covering
admin users, regular users, and headless processes with/without custom table names
- share_repository_test.go: Added headless access tests and SQL ambiguity
verification for the album.id vs id fix in loadMedia function
- Cleaned up test setup by replacing log.NewContext usage with GinkgoT().Context()
and removing unnecessary configtest.SetupConfig() calls for better test isolation
These tests ensure that headless processes (background operations without user context)
can access all libraries while respecting explicit filters, and verify that the SQL
ambiguity fixes work correctly without breaking existing functionality.
* revert: remove user context handling from scrobble buffer getParticipants
Reverts commit 5b8ef74f05109ecf30ddfc936361b84314522869.
The artist repository no longer requires user context for proper library
filtering, so the workaround of temporarily injecting user context into
the scrobbleBufferRepository.Next method is no longer needed.
This simplifies the code and removes the dependency on fetching user
information during background scrobbling operations.
* fix: improve library access filtering for artists
Enhanced artist repository filtering to properly handle library access restrictions
and prevent artists with no accessible content from appearing in results.
Backend changes:
- Modified roleFilter to use direct JSON_EXTRACT instead of EXISTS subquery for better performance
- Enhanced applyLibraryFilterToArtistQuery to filter out artists with empty stats (no content)
- Changed from LEFT JOIN to INNER JOIN with library_artist table for stricter filtering
- Added condition to exclude artists where library_artist.stats = '{}' (empty content)
Frontend changes:
- Added null-checking in getCounter function to prevent TypeError when accessing undefined records
- Improved optional chaining for safer property access in role-based statistics display
These changes ensure that users only see artists that have actual accessible content
in their permitted libraries, fixing issues where artists appeared in the list
despite having no albums or songs available to the user.
* fix: update library access logic for non-admin users and enhance test coverage
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: refine library artist query and implement cleanup for empty entries
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: consolidate artist repository tests to eliminate duplication
Significantly refactored artist_repository_test.go to reduce code duplication and
improve maintainability by ~27% (930 to 680 lines). Key improvements include:
- Added test helper functions createTestArtistWithMBID() and createUserWithLibraries()
to eliminate repetitive test data creation
- Consolidated duplicate MBID search tests using DescribeTable for parameterized testing
- Removed entire 'Permission-Based Behavior Comparison' section (~150 lines) that
duplicated functionality already covered in other test contexts
- Reorganized search tests into cohesive 'MBID and Text Search' section with proper
setup/teardown and shared test infrastructure
- Streamlined missing artist tests and moved them to dedicated section
- Maintained 100% test coverage while eliminating redundant test patterns
All tests continue to pass with identical functionality and coverage.
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-07-20 15:58:21 -04:00
65961cce4b
fix(ui): replaygain for Artist Radio and Top Songs ( #4328 )
...
* Map replaygain info from getSimilarSongs2
* refactor: rename mapping function
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: Applied code review improvements
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-07-08 17:41:14 -03:00
2741b1a5c5
feat(server): expose main credit stat to reflect only album artist | artist credit ( #4268 )
...
* attempt using artist | albumartist
* add primary stats, expose to ND and Subsonic
* response to feedback (1)
* address feedback part 1
* fix docs and artist show
* fix migration order
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
2025-06-28 19:00:13 -04:00
a65140b965
feat(ui): add Play Artist's Top Songs button ( #4204 )
...
* ui: add Play button to artist toolbar
* refactor
Signed-off-by: Deluan <deluan@navidrome.org >
* test(ui): add tests for Play button functionality in ArtistActions
Signed-off-by: Deluan <deluan@navidrome.org >
* ui: update Play button label to Top Songs in ArtistActions
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-06-09 19:09:04 -04:00
aee2a1f8be
fix(ui): artist buttons in spotify-ish
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-06-09 17:56:59 -04:00
5882889a80
feat(ui): Add Artist Radio and Shuffle options ( #4186 )
...
* Add Play Similar option
* Add pt-br translation for Play Similar
* Refactor playSimilar and add helper
* Improve Play Similar feedback
* Add artist actions bar with shuffle and radio
* Add Play Similar menu and align artist actions
* Refine artist actions and revert menu option
* fix(ui): enhance layout of ArtistActions and ArtistShow components
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(i18n): revert unused changes
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): improve layout for mobile
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): improve error handling for fetching similar songs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): enhance error logging for fetching songs in shuffle
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(ui): shuffle handling to use async/await for better readability
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(ui): simplify button label handling in ArtistActions component
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-06-09 17:06:10 -04:00
85a7268192
fix(ui): update titles for radios, shares and show pages ( #4128 )
2025-05-27 09:01:52 -04:00
030710afa9
fix(ui): enhance external link display with consistent minimum heights
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-05-26 18:21:55 -04:00
d26e2e29a6
feat(ui): add smooth image transitions to album and artist artwork ( #4120 )
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-05-26 08:57:37 -04:00
c98e4d02cb
feat(ui): add missing filter for admin users in album, artist, and song lists
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-05-24 13:06:36 -04:00
9dd050c377
fix: add useResourceRefresh hook to AlbumShow, ArtistShow, MissingFilesList, and PlaylistShow components
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-05-23 00:02:42 -04:00
453630d430
feat: hide missing artists from regular users and Subsonic API ( #4092 )
...
* Handle missing artists for non-admin users
* feat(artist): enhance ArtistList with missing row styling and class management
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-05-20 21:53:02 -04:00
2b84c574ba
fix: restore old date display/sort behaviour ( #3862 )
...
* fix(server): bring back legacy date mappings
Signed-off-by: Deluan <deluan@navidrome.org >
* reuse the mapDates logic in the legacyReleaseDate function
Signed-off-by: Deluan <deluan@navidrome.org >
* fix mappings
Signed-off-by: Deluan <deluan@navidrome.org >
* show original and release dates in album grid
Signed-off-by: Deluan <deluan@navidrome.org >
* fix tests based on new year mapping
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): prefer returning original_year over (recording) year
when sorting albums
Signed-off-by: Deluan <deluan@navidrome.org >
* fix case when we don't have originalYear
Signed-off-by: Deluan <deluan@navidrome.org >
* show all dates in album's info, and remove the recording date from the album page
Signed-off-by: Deluan <deluan@navidrome.org >
* better?
Signed-off-by: Deluan <deluan@navidrome.org >
* add snapshot tests for Album Details
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): sort order for getAlbumList?type=byYear
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
2025-03-30 17:06:58 -04:00
aee19e747c
feat(ui): Improve Artist Album pagination ( #3748 )
...
* feat(ui): Improve Artist Album pagination
- use maximum of albumartist/artist credits for determining pagination
- reduce default maxPerPage considerably. This gives values of 36/72/108 at largest size
* enable pagination when over 90
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
2025-02-22 09:31:20 -05:00
70487a09f4
fix(ui): paginate albums in artist page when needed
...
Signed-off-by: Deluan <deluan@navidrome.org >
2025-02-20 19:21:01 -05:00
c795bcfcf7
feat(bfr): Big Refactor: new scanner, lots of new fields and tags, improvements and DB schema changes ( #2709 )
...
* fix(server): more race conditions when updating artist/album from external sources
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(scanner): add .gitignore syntax to .ndignore. Resolves #1394
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): null
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): pass configfile option to child process
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): resume interrupted fullScans
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): remove old scanner code
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): rename old metadata package
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): move old metadata package
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: tests
Signed-off-by: Deluan <deluan@navidrome.org >
* chore(deps): update Go to 1.23.4
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: logs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(test):
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: log level
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: remove log message
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: add config for scanner watcher
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: children playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: replace `interface{}` with `any`
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: smart playlists with genres
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: allow any tags in smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: artist names in playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: smart playlist's sort by tags
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): use generic JSONArray for OS arrays
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): use https in test
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add releaseTypes to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add recordLabels to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic): rename JSONArray to Array
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to AlbumID3
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to Child
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(scanner): do not pre-populate smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): implement a simplified version of ArtistID3.
See https://github.com/opensubsonic/open-subsonic-api/discussions/120
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add artists to album child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add contributors to mediafile Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add albumArtists to mediafile Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add displayArtist and displayAlbumArtist
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add displayComposer to Child
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add roles to ArtistID3
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): use " • " separator for displayComposer
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor:
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic):
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(subsonic): respect `PreferSortTags` config option
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor(subsonic):
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: optimize purging non-unused tags
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: don't run 'refresh artist stats' concurrently with other transactions
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor:
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: log message
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: add Scanner.ScanOnStartup config option, default true
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: better json parsing error msg when importing NSPs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't update album's imported_time when updating external_metadata
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: handle interrupted scans and full scans after migrations
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: run `analyze` when migration requires a full rescan
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: run `PRAGMA optimize` at the end of the scan
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't update artist's updated_at when updating external_metadata
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: handle multiple artists and roles in smart playlists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): dim missing tracks
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album missing logic
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: error encoding in gob
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: separate warnings from errors
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: mark albums as missing if they were contained in a deleted folder
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: add participant names to media_file and album tables
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: use participations in criteria, instead of m2m relationship
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: rename participations to participants
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add moods to album child
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: albumartist role case
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(scanner): run scanner as an external process by default
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): show albumArtist names
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): dim out missing albums
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: flaky test
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(server): scrobble buffer mapping. fix #3583
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: more participations renaming
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: listenbrainz scrobbling
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: send release_group_mbid to listenbrainz
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): implement OpenSubsonic explicitStatus field (#3597 )
* feat: implement OpenSubsonic explicitStatus field
* fix(subsonic): fix failing snapshot tests
* refactor: create helper for setting explicitStatus
* fix: store smaller values for explicit-status on database
* test: ToAlbum explicitStatus
* refactor: rename explicitStatus helper function
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org >
* fix: handle album and track tags in the DB based on the mappings.yaml file
Signed-off-by: Deluan <deluan@navidrome.org >
* save similar artists as JSONB
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: getAlbumList byGenre
Signed-off-by: Deluan <deluan@navidrome.org >
* detect changes in PID configuration
Signed-off-by: Deluan <deluan@navidrome.org >
* set default album PID to legacy_pid
Signed-off-by: Deluan <deluan@navidrome.org >
* fix tests
Signed-off-by: Deluan <deluan@navidrome.org >
* fix SIGSEGV
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't lose album stars/ratings when migrating
Signed-off-by: Deluan <deluan@navidrome.org >
* store full PID conf in properties
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: keep album annotations when changing PID.Album config
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: reassign album annotations
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: use (display) albumArtist and add links to each artist
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: not showing albums by albumartist
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: error msgs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: hide PID from Native API
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album cover art resolution
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: trim participant names
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: reduce watcher log spam
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: panic when initializing the watcher
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: various artists
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't store empty lyrics in the DB
Signed-off-by: Deluan <deluan@navidrome.org >
* remove unused methods
Signed-off-by: Deluan <deluan@navidrome.org >
* drop full_text indexes, as they are not being used by SQLite
Signed-off-by: Deluan <deluan@navidrome.org >
* keep album created_at when upgrading
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): null pointer
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album artwork cache
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't expose missing files in Subsonic API
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: searchable interface
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: filter out missing items from subsonic search
* fix: filter out missing items from playlists
* fix: filter out missing items from shares
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): add filter by artist role
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): only return albumartists in getIndexes and getArtists endpoints
Signed-off-by: Deluan <deluan@navidrome.org >
* sort roles alphabetically
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: artist playcounts
Signed-off-by: Deluan <deluan@navidrome.org >
* change default Album PID conf
Signed-off-by: Deluan <deluan@navidrome.org >
* fix albumartist link when it does not match any albumartists values
Signed-off-by: Deluan <deluan@navidrome.org >
* fix `Ignoring filter not whitelisted` (role) message
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: trim any names/titles being imported
Signed-off-by: Deluan <deluan@navidrome.org >
* remove unused genre code
Signed-off-by: Deluan <deluan@navidrome.org >
* serialize calls to Last.fm's getArtist
Signed-off-by: Deluan <deluan@navidrome.org >
xxx
Signed-off-by: Deluan <deluan@navidrome.org >
* add counters to genres
Signed-off-by: Deluan <deluan@navidrome.org >
* nit: fix migration `notice` message
Signed-off-by: Deluan <deluan@navidrome.org >
* optimize similar artists query
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: last.fm.getInfo when mbid does not exist
Signed-off-by: Deluan <deluan@navidrome.org >
* ui only show missing items for admins
Signed-off-by: Deluan <deluan@navidrome.org >
* don't allow interaction with missing items
Signed-off-by: Deluan <deluan@navidrome.org >
* Add Missing Files view (WIP)
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: merged tag_counts into tag table
Signed-off-by: Deluan <deluan@navidrome.org >
* add option to completely disable automatic scanner
Signed-off-by: Deluan <deluan@navidrome.org >
* add delete missing files functionality
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: playlists not showing for regular users
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce updateLastAccess frequency to once every minute
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce update player frequency to once every minute
Signed-off-by: Deluan <deluan@navidrome.org >
* add timeout when updating player
Signed-off-by: Deluan <deluan@navidrome.org >
* remove dead code
Signed-off-by: Deluan <deluan@navidrome.org >
* fix duplicated roles in stats
Signed-off-by: Deluan <deluan@navidrome.org >
* add `; ` to artist splitters
Signed-off-by: Deluan <deluan@navidrome.org >
* fix stats query
Signed-off-by: Deluan <deluan@navidrome.org >
* more logs
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP
Signed-off-by: Deluan <deluan@navidrome.org >
* add record label filter
Signed-off-by: Deluan <deluan@navidrome.org >
* add release type filter
Signed-off-by: Deluan <deluan@navidrome.org >
* fix purgeUnused tags
Signed-off-by: Deluan <deluan@navidrome.org >
* add grouping filter to albums
Signed-off-by: Deluan <deluan@navidrome.org >
* allow any album tags to be used in as filters in the API
Signed-off-by: Deluan <deluan@navidrome.org >
* remove empty tags from album info
Signed-off-by: Deluan <deluan@navidrome.org >
* comments in the migration
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: Cannot read properties of undefined
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: listenbrainz scrobbling (#3640 )
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: remove duplicated tag values
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: don't ignore the taglib folder!
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: show track subtitle tag
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: show artists stats based on selected role
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: inspect
Signed-off-by: Deluan <deluan@navidrome.org >
* add media type to album info/filters
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: change format of subtitle in the UI
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: subtitle in Subsonic API and search
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: subtitle in UI's player
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: split strings should be case-insensitive
Signed-off-by: Deluan <deluan@navidrome.org >
* disable ScanSchedule
Signed-off-by: Deluan <deluan@navidrome.org >
* increase default sessiontimeout
Signed-off-by: Deluan <deluan@navidrome.org >
* add sqlite command line tool to docker image
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: resources override
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: album PID conf
Signed-off-by: Deluan <deluan@navidrome.org >
* change migration to mark current artists as albumArtists
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): Allow filtering on multiple genres (#3679 )
* feat(ui): Allow filtering on multiple genres
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Signed-off-by: Deluan <deluan@navidrome.org >
* add multi-genre filter in Album list
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Henrik Nordvik <henrikno@gmail.com >
* add more multi-valued tag filters to Album and Song views
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): unselect missing files after removing
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): song filter
Signed-off-by: Deluan <deluan@navidrome.org >
* fix sharing tracks. fix #3687
Signed-off-by: Deluan <deluan@navidrome.org >
* use rowids when using search for sync (ex: Symfonium)
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Report Real Paths" option for subsonic clients
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Report Real Paths" option for subsonic clients for search
Signed-off-by: Deluan <deluan@navidrome.org >
* add libraryPath to Native API /songs endpoint
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(subsonic): add album version
Signed-off-by: Deluan <deluan@navidrome.org >
* made all tags lowercase as they are case-insensitive anyways.
Signed-off-by: Deluan <deluan@navidrome.org >
* feat(ui): Show full paths, extended properties for album/song (#3691 )
* feat(ui): Show full paths, extended properties for album/song
- uses library path + os separator + path
- show participants (album/song) and tags (song)
- make album/participant clickable in show info
* add source to path
* fix pathSeparator in UI
Signed-off-by: Deluan <deluan@navidrome.org >
* fix local artist artwork (#3695 )
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: parse vorbis performers
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: clean function into smaller functions
Signed-off-by: Deluan <deluan@navidrome.org >
* fix translations for en and pt
Signed-off-by: Deluan <deluan@navidrome.org >
* add trace log to show annotations reassignment
Signed-off-by: Deluan <deluan@navidrome.org >
* add trace log to show annotations reassignment
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: allow performers without instrument/subrole
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: metadata clean function again
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: optimize split function
Signed-off-by: Deluan <deluan@navidrome.org >
* refactor: split function is now a method of TagConf
Signed-off-by: Deluan <deluan@navidrome.org >
* fix: humanize Artist total size
Signed-off-by: Deluan <deluan@navidrome.org >
* add album version to album details
Signed-off-by: Deluan <deluan@navidrome.org >
* don't display album-level tags in SongInfo
Signed-off-by: Deluan <deluan@navidrome.org >
* fix genre clicking in Album Page
Signed-off-by: Deluan <deluan@navidrome.org >
* don't use mbids in Last.fm api calls.
From https://discord.com/channels/671335427726114836/704303730660737113/1337574018143879248 :
With MBID:
```
GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&mbid=a41ac10f-0a56-4672-9161-b83f9b223559&method=artist.getInfo
{
artist: {
name: "Bee Gees",
mbid: "bf0f7e29-dfe1-416c-b5c6-f9ebc19ea810",
url: "https://www.last.fm/music/Bee+Gees ",
}
```
Without MBID:
```
GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&method=artist.getInfo
{
artist: {
name: "Van Morrison",
mbid: "a41ac10f-0a56-4672-9161-b83f9b223559",
url: "https://www.last.fm/music/Van+Morrison ",
}
```
Signed-off-by: Deluan <deluan@navidrome.org >
* better logging for when the artist folder is not found
Signed-off-by: Deluan <deluan@navidrome.org >
* fix various issues with artist image resolution
Signed-off-by: Deluan <deluan@navidrome.org >
* hide "Additional Tags" header if there are none.
Signed-off-by: Deluan <deluan@navidrome.org >
* simplify tag rendering
Signed-off-by: Deluan <deluan@navidrome.org >
* enhance logging for artist folder detection
Signed-off-by: Deluan <deluan@navidrome.org >
* make folderID consistent for relative and absolute folderPaths
Signed-off-by: Deluan <deluan@navidrome.org >
* handle more folder paths scenarios
Signed-off-by: Deluan <deluan@navidrome.org >
* filter out other roles when SubsonicArtistParticipations = true
Signed-off-by: Deluan <deluan@navidrome.org >
* fix "Cannot read properties of undefined"
Signed-off-by: Deluan <deluan@navidrome.org >
* fix lyrics and comments being truncated (#3701 )
* fix lyrics and comments being truncated
* specifically test for lyrics and comment length
* reorder assertions
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
* fix(server): Expose library_path for playlist (#3705 )
Allows showing absolute path for UI, and makes "report real path" work for playlists (Subsonic)
* fix BFR on Windows (#3704 )
* fix potential reflected cross-site scripting vulnerability
Signed-off-by: Deluan <deluan@navidrome.org >
* hack to make it work on Windows
* ignore windows executables
* try fixing the pipeline
Signed-off-by: Deluan <deluan@navidrome.org >
* allow MusicFolder in other drives
* move windows local drive logic to local storage implementation
---------
Signed-off-by: Deluan <deluan@navidrome.org >
* increase pagination sizes for missing files
Signed-off-by: Deluan <deluan@navidrome.org >
* reduce level of "already scanning" watcher log message
Signed-off-by: Deluan <deluan@navidrome.org >
* only count folders with audio files in it
See https://github.com/navidrome/navidrome/discussions/3676#discussioncomment-11990930
Signed-off-by: Deluan <deluan@navidrome.org >
* add album version and catalog number to search
Signed-off-by: Deluan <deluan@navidrome.org >
* add `organization` alias for `recordlabel`
Signed-off-by: Deluan <deluan@navidrome.org >
* remove mbid from Last.fm agent
Signed-off-by: Deluan <deluan@navidrome.org >
* feat: support inspect in ui (#3726 )
* inspect in ui
* address round 1
* add catalogNum to AlbumInfo
Signed-off-by: Deluan <deluan@navidrome.org >
* remove dependency on metadata_old (deprecated) package
Signed-off-by: Deluan <deluan@navidrome.org >
* add `RawTags` to model
Signed-off-by: Deluan <deluan@navidrome.org >
* support parsing MBIDs for roles (from the https://github.com/kgarner7/picard-all-mbids plugin) (#3698 )
* parse standard roles, vorbis/m4a work for now
* fix djmixer
* working roles, use DJ-mix
* add performers to file
* map mbids
* add a few more tests
* add test
Signed-off-by: Deluan <deluan@navidrome.org >
* try to simplify the performers logic
Signed-off-by: Deluan <deluan@navidrome.org >
* stylistic changes
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Co-authored-by: Deluan <deluan@navidrome.org >
* remove param mutation
Signed-off-by: Deluan <deluan@navidrome.org >
* run automated SQLite optimizations
Signed-off-by: Deluan <deluan@navidrome.org >
* fix playlists import/export on Windows
* fix import playlists
* fix export playlists
* better handling of Windows volumes
Signed-off-by: Deluan <deluan@navidrome.org >
* handle more album ID reassignments
Signed-off-by: Deluan <deluan@navidrome.org >
* allow adding/overriding tags in the config file
Signed-off-by: Deluan <deluan@navidrome.org >
* fix(ui): Fix playlist track id, handle missing tracks better (#3734 )
- Use `mediaFileId` instead of `id` for playlist tracks
- Only fetch if the file is not missing
- If extractor fails to get the file, also error (rather than panic)
* optimize DB after each scan.
Signed-off-by: Deluan <deluan@navidrome.org >
* remove sortable from AlbumSongs columns
Signed-off-by: Deluan <deluan@navidrome.org >
* simplify query to get missing tracks
Signed-off-by: Deluan <deluan@navidrome.org >
* mark Scanner.Extractor as deprecated
Signed-off-by: Deluan <deluan@navidrome.org >
---------
Signed-off-by: Deluan <deluan@navidrome.org >
Signed-off-by: Henrik Nordvik <henrikno@gmail.com >
Co-authored-by: Caio Cotts <caio@cotts.com.br >
Co-authored-by: Henrik Nordvik <henrikno@gmail.com >
Co-authored-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com >
2025-02-19 20:35:17 -05:00
fcdd30ba8f
build(ui): migrate from CRA/Jest to Vite/Vitest ( #3311 )
...
* feat: create vite project
* feat: it's alive!
* feat: `make dev` working!
* feat: replace custom serviceWorker with vite plugin
* test: replace Jest with Vitest
* fix: run prettier
* fix: skip eslint for now.
* chore: remove ui.old folder
* refactor: replace lodash.pick with simple destructuring
* fix: eslint errors (wip)
* fix: eslint errors (wip)
* fix: display-name eslint errors (wip)
* fix: no-console eslint errors (wip)
* fix: react-refresh/only-export-components eslint errors (wip)
* fix: react-refresh/only-export-components eslint errors (wip)
* fix: react-refresh/only-export-components eslint errors (wip)
* fix: react-refresh/only-export-components eslint errors (wip)
* fix: build
* fix: pwa manifest
* refactor: pwa manifest
* refactor: simplify PORT configuration
* refactor: rename simple JS files
* test: cover playlistUtils
* fix: react-image-lightbox
* feat(ui): add sourcemaps to help debug issues
2024-09-28 11:54:36 -04:00
3107170afd
Improve SQL sanitization
2024-09-14 18:53:34 -04:00
33717f26d4
Fix album sorting in Artist page
2024-07-04 17:21:31 -04:00
86757663d6
Reformat code with Prettier's new rules.
2023-12-18 15:12:24 -05:00
7a858a2db3
Fix external link for artist page if LastFM is missinb but Musicbrainz is not ( #2533 )
...
* fix mbz link if lastfm does not exist
* use lastfmUrl field
* fix artist info undefined
2023-11-16 19:07:52 -05:00
52b77e4194
Support for Original Date, Release Date & splitting/grouping of album editions ( #2162 )
...
* Update AlbumGridView.js
* Update AlbumDetails.js
* Update AlbumDetails.js
* Create DoubleRangeField.js
* Update and rename DoubleRangeField.js to RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update AlbumGridView.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update index.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update en.json
* Update en.json
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update AlbumGridView.js
* Update AlbumDetails.js
* Update AlbumSongs.js
* Update ContextMenus.js
* Update SongDatagrid.js
* Update AlbumSongs.js
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update AlbumSongs.js
* Update SongList.js
* Update playlist_track_repository.go
* Update 20230113000000_release_year.go
* Update PlayButton.js
* Update mediafile_repository.go
* Update album.go
* Update playlist_track_repository.go
* Update playlist_track_repository.go
* Update SongDatagrid.js
* Update 20230113000000_release_year.go
* Update SongDatagrid.js
* Update AlbumSongs.js
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update AlbumDetails.js
* Update AlbumSongs.js
* Update AlbumSongs.js
* Update RangeFieldDouble.js
* Update SongDatagrid.js
* Update 20230113000000_release_year.go
* Update 20230113000000_release_year.go
* Update 20230113000000_release_year.go
* Update 20230113000000_release_year.go
* Update AlbumSongs.js
* Update AlbumSongs.js
* Update mapping.go
* Update RangeFieldDouble.js
* Update AlbumGridView.js
* Update AlbumSongs.js
* Update en.json
* Update SongDatagrid.js
* Update SongDatagrid.js
* Update metadata.go
* Update mapping.go
* Update AlbumDetails.js
* Update AlbumGridView.js
* Update RangeFieldDouble.js
* Update mapping.go
* Update metadata.go
* Update mapping.go
* Update AlbumDetails.js
* Update 20230113000000_release_year.go
* Update AlbumDetails.js
* Update en.json
* Update configuration.go
* Update mapping.go
* Update configuration.go
* Update mediafile.go
* Update metadata.go
* Update RangeFieldDouble.js
* Update 20230113000000_release_year.go
* Update configuration.go
* Update mapping.go
* Update mediafile.go
* Update mapping.go
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update RangeFieldDouble.js
* Update 20230113000000_release_year.go
* Update AlbumDetails.js
* Update RangeFieldDouble.js
* Update mapping.go
* Update metadata.go
* Update album.go
* Update mediafile.go
* Update mediafile.go
* Update album.go
* Update fields.go
* Update mediafile_repository.go
* Update playlist_track_repository.go
* Update AlbumSongs.js
* Update SongDatagrid.js
* Update PlayButton.js
* Update SongList.js
* Update ContextMenus.js
* Update SongDatagrid.js
* Update metadata.go
* Update ArtistShow.js
* Update mapping.go
* Update configuration.go
* Update mapping.go
* Update metadata.go
* Update metadata.go
* Update mapping.go
* Update metadata.go
* Update metadata.go
* Update mapping.go
* Update 20230113000000_release_year.go
* Update 20230113000000_release_year.go
* Update mapping.go
* Update metadata.go
* Update metadata.go
* Update album.go
* Update mediafile.go
* Update AlbumDetails.js
* Update AlbumSongs.js
* Update album.go
* Update mediafile.go
* Update metadata.go
* Update mediafile.go
* Update 20230113000000_release_year.go
* Update 20230113000000_release_year.go
* Update album.go
* Update mediafile.go
* Update RangeFieldDouble.js
* Update AlbumDetails.js
* Update AlbumGridView.js
* Update en.json
* Update AlbumGridView.js
* Update RangeFieldDouble.js
* Update and rename 20230113000000_release_year.go to 20230113000000_release_date.go
* Update album.go
* Update mediafile.go
* Update fields.go
* Update playlist_track_repository.go
* Update mediafile_repository.go
* Update mapping.go
* Update metadata.go
* Update mapping.go
* Update SongDatagrid.js
* Update RangeFieldDouble.js
* Update index.js
* Update ContextMenus.js
* Update PlayButton.js
* Create FormatDate.js
* Update SongList.js
* Update AlbumDetails.js
* Update AlbumSongs.js
* Update AlbumSongs.js
* Update en.json
* Update AlbumDetails.js
* Update album.go
fixed conflict I think?
* Update mediafile.go
fixed conflict
* Format with goimports
* Update SongDatagrid.js
only show Cat # in desktop view
* Update metadata_internal_test.go
* Update metadata_test.go
* Delete test.mp3
* Add files via upload
mp3 test file with Date, Original Date and Release Date
* Update metadata_test.go
* Update metadata_test.go
* Update metadata_test.go
* Update metadata_test.go
* Update taglib_test.go
* Delete test.mp3
* Add files via upload
file with replaygain & dates
* Update AlbumGridView.js
* Update AlbumDetails.js
* Update AlbumSongs.js
* Update ContextMenus.js
* Update FormatDate.js
* Update PlayButton.js
* Update RangeFieldDouble.js
* Update SongDatagrid.js
* Update AlbumSongs.js
* Update SongDatagrid.js
* Update AlbumSongs.js
* Fix formatting
* Update mapping.go
* Update AlbumSongs.js
* Update SongDatagrid.js
* Update SongDatagrid.js
prettier
* Create RangeDoubleField.js
rename of RangeFieldDouble.js
* Update AlbumGridView.js
RangeFieldDouble -> RangeDoubleField
* Update mediafile.go
AllOrNothing() -> allOrNothing()
* Update metadata_internal_test.go
getYear -> getDate
* Update AlbumDetails.js
wrote suggested changes
* Update en.json
Editions -> Releases & fixed the field name
* Update configuration.go
Rename Editions -> Releases
* Update 20230113000000_release_date.go
Editions -> Releases
* Update album.go
Editions -> Releases
* Update mediafile.go
Editions -> Releases
* Update AlbumDetails.js
Editions -> Releases
* Update AlbumSongs.js
Editions -> Releases
* Update RangeDoubleField.js
Editions -> Releases
* Update SongDatagrid.js
Editions -> Releases
* Update index.js
FormatFullDate and RangeDoubleField
* Rename FormatDate.js to FormatFullDate.js
* Delete RangeFieldDouble.js
* Update mediafile.go
AllOrNothing -> allOrNothing
* Update mapping.go
Editions -> Releases
* Update AlbumDetails.js
prettier
* Update SongDatagrid.js
showReleaseRow -> showReleaseDivider
* Update AlbumSongs.js
showReleaseRow -> showReleaseDivider for clarity
* Update and rename 20230113000000_release_date.go to 20230515184510_add_release_date.go
- rename the migration file
- fixed the import to goose/v3
- additional db fields for original date & year
* Update 20230515184510_add_release_date.go
* Update fields.go
* Update album.go
* Update mediafile.go
* Update mapping.go
* Update AlbumDetails.js
* Update en.json
* Update AlbumDetails.js
* Update AlbumDetails.js
now hopefully prettier
* Update mapping.go
---------
Co-authored-by: Deluan <deluan@navidrome.org >
2023-05-19 15:27:47 -04:00
1950c07b1d
Disable external links when EnableExternalServices is false. Fix #2022
2023-01-25 10:28:03 -05:00
16850a9be0
Revert "Replace the LoveButton with ArtistContextMenu in the artist page - #1979 "
...
see https://github.com/navidrome/navidrome/issues/1979#issuecomment-1402904870
2023-01-24 20:14:51 -05:00
17d9573f4d
Refactor dialogs, make it simple to add a new dialog to all views
2023-01-24 18:36:47 -05:00
33f033beba
Fix artist image not caching on browser
2023-01-20 21:28:44 -05:00
b9934799ec
Increase size of artist image
2023-01-20 20:55:17 -05:00
7682fddec0
Add Size column to Artist and Album views
2023-01-16 15:00:50 -05:00
12dd219e16
Don't refresh artistInfo when setting artist's love/rating
2023-01-14 10:52:03 -05:00
1d6b04e3ad
Replace the LoveButton with ArtistContextMenu in the artist page - #1979
2023-01-14 10:52:03 -05:00
291455f0b7
Fix Download Dialog not showing in Artist page
2023-01-13 19:40:43 -05:00
b8c171d3d4
Hide LastFM icons if config.lastFMEnabled is false ( #1935 )
...
Hide LastFM icons if `config.lastFMEnabled` is false
2022-12-30 17:15:14 -05:00
54395e7e6a
Enable transcoding of downlods ( #1667 )
...
* feat(download): Enable transcoding of downlods - #573
Signed-off-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com >
* feat(download): Make automatic transcoding of downloads optional
Signed-off-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com >
* Fix spelling
* address changes
* prettier
* fix config
* use previous name
Signed-off-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com >
2022-12-18 12:12:37 -05:00
fcb891e704
Add an id attribute to Search boxes. Should fix #1998
2022-11-21 13:44:16 -05:00
12b4a48842
Fix get info dialog in artist page. Closes #1909
2022-10-04 12:30:04 -04:00
66818b25ec
Allow ExternalLink icons to be styled ( #1503 )
...
* Allow ArtistExternalLink icons to be styled
* Allow AlbumExternalLink icons to be styled
* Standardize external links' classes to kebab-case
Co-authored-by: Deluan <deluan@navidrome.org >
2022-09-30 13:33:35 -04:00
50a4ce6ba2
Fix add playlist dialog ( #1758 )
2022-09-28 22:15:39 -04:00
d4447e373f
Fix sorting albums by year (should use name as secondary sort field).
...
Relates to https://github.com/navidrome/navidrome/issues/961#issuecomment-967624681
2021-11-17 21:47:14 -05:00
84bbcdbfc2
Add artist image lightbox
2021-10-30 20:05:01 -04:00
31c598de07
Fix drag-n-drop from a playlist, also fix useDrag memoization
2021-10-23 20:25:28 -04:00
2a756eab88
Show external links on all resolutions but mobile
2021-10-21 10:30:53 -04:00
104679ca6e
Guard against record being undefined. Fix error Cannot read properties of undefined (reading 'id')
2021-10-19 20:22:56 -04:00
1d742cf8c7
Artist page improvements ( #1391 )
...
* Seperate mobile desktop components
* Fix err
* Rename classes and fix some styles
* Add lastFM button and remove console log
* Add Mbiz Icon
* render bio as dangerouslySetInnerHTML and remove unused css classes
* Add Fav and Stars
* Remove unstandardised class selector
* Remove ext link from m view
* Fix naming and simplify rounded styling
* Refactor ArtistShow:
- Extracted DesktopArtistDetails to its own file
- Removed album count as it was incorrect, it is not considering compilations
- Show bio and image from Native API, if it is available, before calling `getArtistInfo`
Co-authored-by: Deluan <deluan@navidrome.org >
2021-10-15 21:02:11 -04:00
a6311259fd
Fix layout error in ArtistShow ( #1387 )
2021-10-04 17:14:38 -04:00
9c29ee3651
Check permissions before adding songs to playlists
2021-10-02 13:23:17 -04:00
6c3e45de41
Add songs to playlists with drag and drop
2021-10-02 13:14:33 -04:00
24872e6c2a
Fix biography word wrapping and requests for undefined resource
2021-09-27 09:47:16 -04:00
482c2dec0c
Artist Detail Page (first cut) ( #1287 )
...
* Configure fetching from API and route
* pretty
* Remove errors
* Remove errors
* Remove errors
* Complete page for Desktop view
* Fix error
* Add xs Artist page
* Remove unused import
* Add styles for theme
* Change route path
* Remove artId useEffect array
* Remove array
* Fix cover load err
* Add redirect on err
* Remove route
* What's in a name? consistency :)
* Fix err
* Fix UI changes
* Fetch album from resource
* Renaming done
* Review changes
* Some touch-up
* Small refactor, to make naming and structure more consistent with AlbumShow
* Make artist's album list similar to original implementation
* Reuse AlbumGridView, to avoid duplication
* Add feature flag to enable new Artist Page, default false
* Better biography styling. Small refactorings,
* Don't encode quotes and other symbols
* Moved AlbumShow to correct folder
Co-authored-by: Deluan <deluan@navidrome.org >
2021-09-26 15:32:40 -04:00
7bd506accc
Retrieve all options for Genre filters
2021-07-24 16:00:27 -04:00
20b7e5c49b
Add Genre filters to UI
2021-07-20 17:45:08 -04:00
Deluan Quintão