c280dd67a4f4e2141f49f3bfec6d5d52de85b4f0
49
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 MaximilianandGitHub
|
a704e86ac1 | refactor: run Go modernize (#5002) | ||
|
Deluan QuintãoGitHubgemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> |
f1e75c40dc |
feat(plugins): add JSONForms-based plugin configuration UI (#4911)
* feat(plugins): add JSONForms schema for plugin configuration Signed-off-by: Deluan <[email protected]> * feat: enhance error handling by formatting validation errors with field names Signed-off-by: Deluan <[email protected]> * feat: enforce required fields in config validation and improve error handling Signed-off-by: Deluan <[email protected]> * format JS code Signed-off-by: Deluan <[email protected]> * feat: add config schema validation and enhance manifest structure Signed-off-by: Deluan <[email protected]> * feat: refactor plugin config parsing and add unit tests Signed-off-by: Deluan <[email protected]> * feat: add config validation error message in Portuguese * feat: enhance AlwaysExpandedArrayLayout with description support and improve array control testing Signed-off-by: Deluan <[email protected]> * feat: update Discord Rust plugin configuration to use JSONForm for user tokens and enhance schema validation Signed-off-by: Deluan <[email protected]> * fix: resolve React Hooks linting issues in plugin UI components * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * format code Signed-off-by: Deluan <[email protected]> * feat: migrate schema validation to use santhosh-tekuri/jsonschema and improve error formatting Signed-off-by: Deluan <[email protected]> * address PR comments Signed-off-by: Deluan <[email protected]> * fix flaky test Signed-off-by: Deluan <[email protected]> * feat: enhance array layout and configuration handling with AJV defaults Signed-off-by: Deluan <[email protected]> * feat: implement custom tester to exclude enum arrays from AlwaysExpandedArrayLayout Signed-off-by: Deluan <[email protected]> * feat: add error boundary for schema rendering and improve error messages Signed-off-by: Deluan <[email protected]> * feat: refine non-enum array control logic by utilizing JSONForms schema resolution Signed-off-by: Deluan <[email protected]> * feat: add error styling to ToggleEnabledSwitch for disabled state Signed-off-by: Deluan <[email protected]> * feat: adjust label positioning and styling in SchemaConfigEditor for improved layout Signed-off-by: Deluan <[email protected]> * feat: implement outlined input controls renderers to replace custom fragile CSS Signed-off-by: Deluan <[email protected]> * feat: remove margin from last form control inside array items for better spacing Signed-off-by: Deluan <[email protected]> * feat: enhance AJV error handling to transform required errors for field-level validation Signed-off-by: Deluan <[email protected]> * feat: set default value for User Tokens in manifest.json to improve user experience Signed-off-by: Deluan <[email protected]> * format Signed-off-by: Deluan <[email protected]> * feat: add margin to outlined input controls for improved spacing Signed-off-by: Deluan <[email protected]> * feat: remove redundant margin rule for last form control in array items Signed-off-by: Deluan <[email protected]> * feat: adjust font size of label elements in SchemaConfigEditor for improved readability Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> |
||
|
Deluan QuintãoandGitHub
|
03a45753e9 |
feat(plugins): New Plugin System with multi-language PDK support (#4833)
* chore(plugins): remove the old plugins system implementation Signed-off-by: Deluan <[email protected]> * feat(plugins): implement new plugin system with using Extism Signed-off-by: Deluan <[email protected]> * feat(plugins): add capability detection for plugins based on exported functions Signed-off-by: Deluan <[email protected]> * feat(plugins): add auto-reload functionality for plugins with file watcher support Signed-off-by: Deluan <[email protected]> * feat(plugins): add auto-reload functionality for plugins with file watcher support Signed-off-by: Deluan <[email protected]> * refactor(plugins): standardize variable names and remove superfluous wrapper functions Signed-off-by: Deluan <[email protected]> * fix(plugins): improve error handling and logging in plugin manager Signed-off-by: Deluan <[email protected]> * refactor(plugins): implement plugin function call helper and refactor MetadataAgent methods Signed-off-by: Deluan <[email protected]> * fix(plugins): race condition in plugin manager * tests(plugins): change BeforeEach to BeforeAll in MetadataAgent tests Signed-off-by: Deluan <[email protected]> * tests(plugins): optimize tests Signed-off-by: Deluan <[email protected]> * tests(plugins): more optimizations Signed-off-by: Deluan <[email protected]> * test(plugins): ignore goroutine leaks from notify library in tests Signed-off-by: Deluan <[email protected]> * feat(plugins): add Wikimedia plugin for Navidrome to fetch artist metadata Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance plugin logging and set User-Agent header Signed-off-by: Deluan <[email protected]> * feat(plugins): implement scrobbler plugin with authorization and scrobbling capabilities Signed-off-by: Deluan <[email protected]> * feat(plugins): integrate logs Signed-off-by: Deluan <[email protected]> * refactor(plugins): clean up manifest struct and improve plugin loading logic Signed-off-by: Deluan <[email protected]> * feat(plugins): add metadata agent and scrobbler schemas for bootstrapping plugins Signed-off-by: Deluan <[email protected]> * feat(hostgen): add hostgen tool for generating Extism host function wrappers - Implemented hostgen tool to generate wrappers from annotated Go interfaces. - Added command-line flags for input/output directories and package name. - Introduced parsing and code generation logic for host services. - Created test data for various service interfaces and expected generated code. - Added documentation for host services and annotations for code generation. - Implemented SubsonicAPI service with corresponding generated code. * feat(subsonicapi): update Call method to return JSON string response Signed-off-by: Deluan <[email protected]> * feat(plugins): implement SubsonicAPI host function integration with permissions Signed-off-by: Deluan <[email protected]> * fix(generator): error-only methods in response handling Signed-off-by: Deluan <[email protected]> * feat(plugins): generate client wrappers for host functions Signed-off-by: Deluan <[email protected]> * refactor(generator): remove error handling for response.Error in client templates Signed-off-by: Deluan <[email protected]> * feat(scheduler): add Scheduler service interface with host function wrappers for scheduling tasks * feat(plugins): add WASI build constraints to client wrapper templates, to avoid lint errors Signed-off-by: Deluan <[email protected]> * feat(scheduler): implement Scheduler service with one-time and recurring scheduling capabilities Signed-off-by: Deluan <[email protected]> * refactor(manifest): remove unused ConfigPermission from permissions schema Signed-off-by: Deluan <[email protected]> * feat(scheduler): add scheduler callback schema and implementation for plugins Signed-off-by: Deluan <[email protected]> * refactor(scheduler): streamline scheduling logic and remove unused callback tracking Signed-off-by: Deluan <[email protected]> * refactor(scheduler): add Close method for resource cleanup on plugin unload Signed-off-by: Deluan <[email protected]> * docs(scheduler): clarify SchedulerCallback requirement for scheduling functions Signed-off-by: Deluan <[email protected]> * fix: update wasm build rule to include all Go files in the directory Signed-off-by: Deluan <[email protected]> * feat: rewrite the wikimedia plugin using the XTP CLI Signed-off-by: Deluan <[email protected]> * refactor(scheduler): replace uuid with id.NewRandom for schedule ID generation Signed-off-by: Deluan <[email protected]> * refactor: capabilities registration Signed-off-by: Deluan <[email protected]> * test: add scheduler service isolation test for plugin instances Signed-off-by: Deluan <[email protected]> * refactor: update plugin manager initialization and encapsulate logic Signed-off-by: Deluan <[email protected]> * feat: add WebSocket service definitions for plugin communication Signed-off-by: Deluan <[email protected]> * feat: implement WebSocket service for plugin integration and connection management Signed-off-by: Deluan <[email protected]> * feat: add Crypto Ticker example plugin for real-time cryptocurrency price updates via Coinbase WebSocket API Also add the lifecycle capability Signed-off-by: Deluan <[email protected]> * fix: use context.Background() in invokeCallback for scheduled tasks Signed-off-by: Deluan <[email protected]> * refactor: rename plugin.create() to plugin.instance() Signed-off-by: Deluan <[email protected]> * refactor: rename pluginInstance to plugin for consistency across the codebase Signed-off-by: Deluan <[email protected]> * refactor: simplify schedule cloning in Close method and enhance plugin cleanup error handling Signed-off-by: Deluan <[email protected]> * feat: implement Artwork service for generating artwork URLs in Navidrome plugins - WIP Signed-off-by: Deluan <[email protected]> * refactor: moved public URL builders to avoid import cycles Signed-off-by: Deluan <[email protected]> * feat: add Cache service for in-memory TTL-based caching in plugins Signed-off-by: Deluan <[email protected]> * feat: add Discord Rich Presence example plugin for Navidrome integration Signed-off-by: Deluan <[email protected]> * refactor: host function wrappers to use structured request and response types - Updated the host function signatures in `nd_host_artwork.go`, `nd_host_scheduler.go`, `nd_host_subsonicapi.go`, and `nd_host_websocket.go` to accept a single parameter for JSON requests. - Introduced structured request and response types for various cache operations in `nd_host_cache.go`. - Modified cache functions to marshal requests to JSON and unmarshal responses, improving error handling and code clarity. - Removed redundant memory allocation for string parameters in favor of JSON marshaling. - Enhanced error handling in WebSocket and cache operations to return structured error responses. * refactor: error handling in various plugins to convert response.Error to Go errors - Updated error handling in `nd_host_scheduler.go`, `nd_host_websocket.go`, `nd_host_artwork.go`, `nd_host_cache.go`, and `nd_host_subsonicapi.go` to convert string errors from responses into Go errors. - Removed redundant error checks in test data plugins for cleaner code. - Ensured consistent error handling across all plugins to improve reliability and maintainability. * refactor: rename fake plugins to test plugins for clarity in integration tests Signed-off-by: Deluan <[email protected]> * feat: add help target to Makefile for plugin usage instructions Signed-off-by: Deluan <[email protected]> * feat: add Cover Art Archive plugin as an example of Python plugin Signed-off-by: Deluan <[email protected]> * feat: update Makefile and README to clarify Go plugin usage Signed-off-by: Deluan <[email protected]> * feat: include plugin capabilities in loading log message Signed-off-by: Deluan <[email protected]> * feat: add trace logging for plugin availability and error handling in agents Signed-off-by: Deluan <[email protected]> * feat: add Now Playing Logger plugin to showcase calling host functions from Python plugins Signed-off-by: Deluan <[email protected]> * feat: generate Python client wrappers for various host services Signed-off-by: Deluan <[email protected]> * feat: add generated host function wrappers for Scheduler and SubsonicAPI services Signed-off-by: Deluan <[email protected]> * feat: update Python plugin documentation and usage instructions for host function wrappers Signed-off-by: Deluan <[email protected]> * feat: add Webhook Scrobbler plugin in Rust to send HTTP notifications on scrobble events Signed-off-by: Deluan <[email protected]> * feat: enable parallel loading of plugins during startup Signed-off-by: Deluan <[email protected]> * docs: update README to include WebSocket callback schema in plugin documentation Signed-off-by: Deluan <[email protected]> * feat: extend plugin watcher with improved logging and debounce duration adjustment Signed-off-by: Deluan <[email protected]> * add trace message for plugin recompiles Signed-off-by: Deluan <[email protected]> * feat: implement plugin cache purging functionality Signed-off-by: Deluan <[email protected]> * test: move purgeCacheBySize unit tests Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add plugin repository and database support Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add plugin management routes and middleware Signed-off-by: Deluan <[email protected]> * feat(plugins UI): implement plugin synchronization with database for add, update, and remove actions Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add PluginList and PluginShow components with plugin management functionality Signed-off-by: Deluan <[email protected]> * feat(plugins): optimize plugin change detection Signed-off-by: Deluan <[email protected]> * refactor(plugins UI): improve PluginList structure Signed-off-by: Deluan <[email protected]> * feat(plugins UI): enhance PluginShow with author, website, and permissions display Signed-off-by: Deluan <[email protected]> * feat(plugins UI): refactor to use MUI and RA components Signed-off-by: Deluan <[email protected]> * feat(plugins UI): add error handling for plugin enable/disable actions Signed-off-by: Deluan <[email protected]> * refactor(plugins): inject PluginManager into native API Signed-off-by: Deluan <[email protected]> * refactor(plugins): update GetManager to accept DataStore parameter Signed-off-by: Deluan <[email protected]> * feat(plugins): add subsonicRouter to Manager and refactor host service registration Signed-off-by: Deluan <[email protected]> * refactor(plugins): enhance debug logging for plugin actions and recompile logic Signed-off-by: Deluan <[email protected]> * refactor(plugins): break manager.go into smaller, focused files Signed-off-by: Deluan <[email protected]> * refactor(plugins): streamline error handling and improve plugin retrieval logic Signed-off-by: Deluan <[email protected]> * refactor(plugins): update newWebSocketService to use WebSocketPermission for allowed hosts Signed-off-by: Deluan <[email protected]> * refactor(plugins): introduce ToggleEnabledSwitch for managing plugin enable/disable state Signed-off-by: Deluan <[email protected]> * docs: update READMEs Signed-off-by: Deluan <[email protected]> * feat(library): add Library service for metadata access and filesystem integration Signed-off-by: Deluan <[email protected]> * feat(plugins): add Library Inspector plugin for periodic library inspection and file size logging Signed-off-by: Deluan <[email protected]> * docs: update README to reflect JSON configuration format for plugins Signed-off-by: Deluan <[email protected]> * fix(build): update target to wasm32-wasip1 for improved WASI support Signed-off-by: Deluan <[email protected]> * feat(plugins): implement configuration management UI with key-value pairs support Signed-off-by: Deluan <[email protected]> * feat(ui): adjust grid layout in InfoRow component for improved responsiveness Signed-off-by: Deluan <[email protected]> * feat(plugins): rename ErrorIndicator to EnabledOrErrorField and enhance error handling logic Signed-off-by: Deluan <[email protected]> * feat(i18n): add Portuguese translations for plugin management and notifications Signed-off-by: Deluan <[email protected]> * feat(plugins): add support for .ndp plugin packages and update build process Signed-off-by: Deluan <[email protected]> * docs: update README for .ndp plugin packaging and installation instructions Signed-off-by: Deluan <[email protected]> * feat(plugins): implement KVStore service for persistent key-value storage Signed-off-by: Deluan <[email protected]> * docs: enhance README with Extism plugin development resources and recommendations Signed-off-by: Deluan <[email protected]> * feat(plugins): integrate event broker into plugin manager Signed-off-by: Deluan <[email protected]> * feat(plugins): update config handling in PluginShow to track last record state Signed-off-by: Deluan <[email protected]> * feat(plugins): add Rust host function library and example implementation of Discord Rich Presence plugin in Rust Signed-off-by: Deluan <[email protected]> * feat(plugins): generate Rust lib.rs file to expose host function wrappers Signed-off-by: Deluan <[email protected]> * refactor(plugins): update JSON field names to camelCase for consistency Signed-off-by: Deluan <[email protected]> * refactor: reduce cyclomatic complexity by refactoring main function Signed-off-by: Deluan <[email protected]> * feat(plugins): enhance Rust code generation with typed struct support and improved type handling Signed-off-by: Deluan <[email protected]> * feat(plugins): add Go client library with host function wrappers and documentation Signed-off-by: Deluan <[email protected]> * feat(plugins): generate Go client stubs for non-WASM platforms Signed-off-by: Deluan <[email protected]> * feat(plugins): update client template file names for consistency Signed-off-by: Deluan <[email protected]> * feat(plugins): add initial implementation of the Navidrome Plugin Development Kit code generator - Pahse 1 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 2 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 2 (2) Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 3 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 4 Signed-off-by: Deluan <[email protected]> * feat(plugins): implementation of the Navidrome Plugin Development Kit with generated client wrappers and service interfaces - Phase 5 Signed-off-by: Deluan <[email protected]> * refactor(plugins): consistent naming/types across PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): streamline plugin function signatures and error handling Signed-off-by: Deluan <[email protected]> * refactor(plugins): update scrobbler interface to return errors directly instead of response structs Signed-off-by: Deluan <[email protected]> * test: make all test plugins use the PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): reorganize and sort type definitions for consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): update error handling for methods to return errors directly Signed-off-by: Deluan <[email protected]> * refactor(plugins): update function signatures to return values directly instead of response structs Signed-off-by: Deluan <[email protected]> * refactor(plugins): update request/response types to use private naming conventions Signed-off-by: Deluan <[email protected]> * build: mark .wasm files as intermediate for cleanup after building .ndp Signed-off-by: Deluan <[email protected]> * refactor(plugins): consolidate PDK module path and update Go version to 1.25 Signed-off-by: Deluan <[email protected]> * feat: implement Rust PDK Signed-off-by: Deluan <[email protected]> * refactor(plugins): reorganize Rust output structure to follow standard conventions Signed-off-by: Deluan <[email protected]> * refactor(plugins): update Discord Rich Presence and Library Inspector plugins to use nd-pdk for service calls and implement lifecycle management Signed-off-by: Deluan <[email protected]> * refactor(plugins): update macro names for websocket and metadata registration to improve clarity and consistency Signed-off-by: Deluan <[email protected]> * refactor(plugins): rename scheduler callback methods for consistency and clarity Signed-off-by: Deluan <[email protected]> * refactor(plugins): update export wrappers to use `//go:wasmexport` for WebAssembly compatibility Signed-off-by: Deluan <[email protected]> * docs: update plugin registration docs Signed-off-by: Deluan <[email protected]> * fix(plugins): generate host wrappers Signed-off-by: Deluan <[email protected]> * test(plugins): conditionally run goleak checks based on CI environment Signed-off-by: Deluan <[email protected]> * docs: update README to reflect changes in plugin import paths Signed-off-by: Deluan <[email protected]> * refactor(plugins): update plugin instance creation to accept context for cancellation support Signed-off-by: Deluan <[email protected]> * fix(plugins): update return types in metadata interfaces to use pointers Signed-off-by: Deluan <[email protected]> * fix(plugins): enhance type handling for Rust and XTP output in capability generation Signed-off-by: Deluan <[email protected]> * fix(plugins): update IsAuthorized method to return boolean instead of response object Signed-off-by: Deluan <[email protected]> * test(plugins): add unit tests for rustOutputType and isPrimitiveRustType functions Signed-off-by: Deluan <[email protected]> * feat(plugins): implement XTP JSONSchema validation for generated schemas Signed-off-by: Deluan <[email protected]> * fix(plugins): update response types in testMetadataAgent methods to use pointers Signed-off-by: Deluan <[email protected]> * docs: update Go and Rust plugin developer sections for clarity Signed-off-by: Deluan <[email protected]> * docs: correct example link for library inspector in README Signed-off-by: Deluan <[email protected]> * docs: clarify artwork URL generation capabilities in service descriptions Signed-off-by: Deluan <[email protected]> * docs: update README to include Rust PDK crate information for plugin developers Signed-off-by: Deluan <[email protected]> * fix: handle URL parsing errors and use atomic upsert in plugin repository Added proper error handling for url.Parse calls in PublicURL and AbsoluteURL functions. When parsing fails, PublicURL now falls back to AbsoluteURL, and AbsoluteURL logs the error and returns an empty string, preventing malformed URLs from being generated. Replaced the non-atomic UPDATE-then-INSERT pattern in plugin repository Put method with a single atomic INSERT ... ON CONFLICT statement. This eliminates potential race conditions and improves consistency with the upsert pattern already used in host_kvstore.go. * feat: implement mock service instances for non-WASM builds using testify/mock Signed-off-by: Deluan <[email protected]> * refactor: Discord RPC struct to encapsulate WebSocket logic Signed-off-by: Deluan <[email protected]> * feat: add support for experimental WebAssembly threads Signed-off-by: Deluan <[email protected]> * feat: add PDK abstraction layer with mock support for non-WASM builds Signed-off-by: Deluan <[email protected]> * feat: add unit tests for Discord plugin and RPC functionality Signed-off-by: Deluan <[email protected]> * fix: update return types in minimalPlugin and wikimediaPlugin methods to use pointers Signed-off-by: Deluan <[email protected]> * fix: context cancellation and implement WebSocket callback timeout for improved error handling Signed-off-by: Deluan <[email protected]> * feat: conditionally include error handling in generated client code templates Signed-off-by: Deluan <[email protected]> * feat: implement ConfigService for plugin configuration management Signed-off-by: Deluan <[email protected]> * feat: enhance plugin manager to support metrics recording Signed-off-by: Deluan <[email protected]> * refactor: make MockPDK private Signed-off-by: Deluan <[email protected]> * refactor: update interface types to use 'any' in plugin repository methods Signed-off-by: Deluan <[email protected]> * refactor: rename List method to Keys for clarity in configuration management Signed-off-by: Deluan <[email protected]> * test: add ndpgen plugin tests in the pipeline and update Makefile Signed-off-by: Deluan <[email protected]> * feat: add users permission management to plugin system Signed-off-by: Deluan <[email protected]> * refactor: streamline users integration tests and enhance plugin user management Signed-off-by: Deluan <[email protected]> * refactor: remove UserID from scrobbler request structure Signed-off-by: Deluan <[email protected]> * test: add integration tests for UsersService enable gate behavior Signed-off-by: Deluan <[email protected]> * feat: implement user permissions for SubsonicAPI and scrobbler plugins Signed-off-by: Deluan <[email protected]> * fix: show proper error in the UI when enabling a plugin fails Signed-off-by: Deluan <[email protected]> * feat: add library permission management to plugin system Signed-off-by: Deluan <[email protected]> * feat: add user permission for processing scrobbles in Discord Rich Presence plugin Signed-off-by: Deluan <[email protected]> * fix: implement dynamic loading for buffered scrobbler plugins Signed-off-by: Deluan <[email protected]> * feat: add GetAdmins method to retrieve admin users from the plugin Signed-off-by: Deluan <[email protected]> * feat: update Portuguese translations for user and library permissions Signed-off-by: Deluan <[email protected]> * reorder migrations Signed-off-by: Deluan <[email protected]> * fix: remove unnecessary bulkActionButtons prop from PluginList component * feat: add manual plugin rescan functionality and corresponding UI action Signed-off-by: Deluan <[email protected]> * feat: implement user/library and plugin management integration with cleanup on deletion Signed-off-by: Deluan <[email protected]> * feat: replace core mock services with test-specific implementations to avoid import cycles * feat: add ID fields to Artist and Song structs and enhance track loading logic by prioritizing ID matches Signed-off-by: Deluan <[email protected]> * feat: update plugin permissions from allowedHosts to requiredHosts for better clarity and consistency * feat: refactor plugin host permissions to use RequiredHosts directly for improved clarity * fix: don't record metrics for plugin calls that aren't implemented at all Signed-off-by: Deluan <[email protected]> * fix: enhance connection management with improved error handling and cleanup logic Signed-off-by: Deluan <[email protected]> * feat: introduce ArtistRef struct for better artist representation and update track metadata handling Signed-off-by: Deluan <[email protected]> * feat: update user configuration handling to use user key prefix for improved clarity Signed-off-by: Deluan <[email protected]> * feat: enhance ConfigCard input fields with multiline support and vertical resizing Signed-off-by: Deluan <[email protected]> * fix: rust plugin compilation error Signed-off-by: Deluan <[email protected]> * feat: implement IsOptionPattern method for better return type handling in Rust PDK generation Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
5ce6e16d96 |
fix: album statistics not updating after deleting missing files (#4668)
* feat: add album refresh functionality after deleting missing files Implemented RefreshAlbums method in AlbumRepository to recalculate album attributes (size, duration, song count) from their constituent media files. This method processes albums in batches to maintain efficiency with large datasets. Added integration in deleteMissingFiles to automatically refresh affected albums in the background after deleting missing media files, ensuring album statistics remain accurate. Includes comprehensive test coverage for various scenarios including single/multiple albums, empty batches, and large batch processing. Signed-off-by: Deluan <[email protected]> * refactor: extract missing files deletion into reusable service layer Extracted inline deletion logic from server/nativeapi/missing.go into a new core.MissingFiles service interface and implementation. This provides better separation of concerns and testability. The MissingFiles service handles: - Deletion of specific or all missing files via transaction - Garbage collection after deletion - Extraction of affected album IDs from missing files - Background refresh of artist and album statistics The deleteMissingFiles HTTP handler now simply delegates to the service, removing 70+ lines of inline logic. All deletion, transaction, and stat refresh logic is now centralized in core/missing_files.go. Updated dependency injection to provide MissingFiles service to the native API router. Renamed receiver variable from 'n' to 'api' throughout native_api.go for consistency. * refactor: consolidate maintenance operations into unified service Consolidate MissingFiles and RefreshAlbums functionality into a new Maintenance service. This refactoring: - Creates core.Maintenance interface combining DeleteMissingFiles, DeleteAllMissingFiles, and RefreshAlbums methods - Moves RefreshAlbums logic from AlbumRepository persistence layer to core Maintenance service - Removes MissingFiles interface and moves its implementation to maintenanceService - Updates all references in wire providers, native API router, and handlers - Removes RefreshAlbums interface method from AlbumRepository model - Improves separation of concerns by centralizing maintenance operations in the core domain This change provides a cleaner API and better organization of maintenance-related database operations. * refactor: remove MissingFiles interface and update references Remove obsolete MissingFiles interface and its references: - Delete core/missing_files.go and core/missing_files_test.go - Remove RefreshAlbums method from AlbumRepository interface and implementation - Remove RefreshAlbums tests from AlbumRepository test suite - Update wire providers to use NewMaintenance instead of NewMissingFiles - Update native API router to use Maintenance service - Update missing.go handler to use Maintenance interface All functionality is now consolidated in the core.Maintenance service. Signed-off-by: Deluan <[email protected]> * refactor: rename RefreshAlbums to refreshAlbums and update related calls Signed-off-by: Deluan <[email protected]> * refactor: optimize album refresh logic and improve test coverage Signed-off-by: Deluan <[email protected]> * refactor: simplify logging setup in tests with reusable LogHook function Signed-off-by: Deluan <[email protected]> * refactor: add synchronization to logger and maintenance service for thread safety Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
00c83af170 |
feat: Multi-library support (#4181)
* feat(database): add user_library table and library access methods Signed-off-by: Deluan <[email protected]> # Conflicts: # tests/mock_library_repo.go * feat(database): enhance user retrieval with library associations Signed-off-by: Deluan <[email protected]> * feat(api): implement library management and user-library association endpoints Signed-off-by: Deluan <[email protected]> * feat(api): restrict access to library and config endpoints to admin users Signed-off-by: Deluan <[email protected]> * refactor(library): implement library management service and update API routes Signed-off-by: Deluan <[email protected]> * feat(database): add library filtering to album, folder, and media file queries Signed-off-by: Deluan <[email protected]> * refactor library service to use REST repository pattern and remove CRUD operations Signed-off-by: Deluan <[email protected]> * add total_duration column to library and update user_library table Signed-off-by: Deluan <[email protected]> * fix migration file name Signed-off-by: Deluan <[email protected]> * feat(library): add library management features including create, edit, delete, and list functionalities - WIP Signed-off-by: Deluan <[email protected]> * feat(library): enhance library validation and management with path checks and normalization - WIP Signed-off-by: Deluan <[email protected]> * feat(library): improve library path validation and error handling - WIP Signed-off-by: Deluan <[email protected]> * use utils/formatBytes Signed-off-by: Deluan <[email protected]> * simplify DeleteLibraryButton.jsx Signed-off-by: Deluan <[email protected]> * feat(library): enhance validation messages and error handling for library paths Signed-off-by: Deluan <[email protected]> * lint Signed-off-by: Deluan <[email protected]> * test(scanner): add tests for multi-library scanning and validation Signed-off-by: Deluan <[email protected]> * test(scanner): improve handling of filesystem errors and ensure warnings are returned Signed-off-by: Deluan <[email protected]> * feat(controller): add function to retrieve the most recent scan time across all libraries Signed-off-by: Deluan <[email protected]> * feat(library): add additional fields and restructure LibraryEdit component for enhanced statistics display Signed-off-by: Deluan <[email protected]> * feat(library): enhance LibraryCreate and LibraryEdit components with additional props and styling Signed-off-by: Deluan <[email protected]> * feat(mediafile): add LibraryName field and update queries to include library name Signed-off-by: Deluan <[email protected]> * feat(missingfiles): add library filter and display in MissingFilesList component Signed-off-by: Deluan <[email protected]> * feat(library): implement scanner interface for triggering library scans on create/update Signed-off-by: Deluan <[email protected]> # Conflicts: # cmd/wire_gen.go # cmd/wire_injectors.go # Conflicts: # cmd/wire_gen.go # Conflicts: # cmd/wire_gen.go # cmd/wire_injectors.go * feat(library): trigger scan after successful library deletion to clean up orphaned data Signed-off-by: Deluan <[email protected]> * rename migration file for user library table to maintain versioning order Signed-off-by: Deluan <[email protected]> * refactor: move scan triggering logic into a helper method for clarity Signed-off-by: Deluan <[email protected]> * feat(library): add library path and name fields to album and mediafile models Signed-off-by: Deluan <[email protected]> * feat(library): add/remove watchers on demand, not only when server starts Signed-off-by: Deluan <[email protected]> * refactor(scanner): streamline library handling by using state-libraries for consistency Signed-off-by: Deluan <[email protected]> * fix: track processed libraries by updating state with scan timestamps Signed-off-by: Deluan <[email protected]> * prepend libraryID for track and album PIDs Signed-off-by: Deluan <[email protected]> * feat(repository): apply library filtering in CountAll methods for albums, folders, and media files Signed-off-by: Deluan <[email protected]> * feat(user): add library selection for user creation and editing Signed-off-by: Deluan <[email protected]> * feat(library): implement library selection functionality with reducer and UI component Signed-off-by: Deluan <[email protected]> # Conflicts: # .github/copilot-instructions.md # Conflicts: # .gitignore * feat(library): add tests for LibrarySelector and library selection hooks Signed-off-by: Deluan <[email protected]> * test: add unit tests for file utility functions Signed-off-by: Deluan <[email protected]> * feat(library): add library ID filtering for album resources Signed-off-by: Deluan <[email protected]> * feat(library): streamline library ID filtering in repositories and update resource filtering logic Signed-off-by: Deluan <[email protected]> * fix(repository): add table name handling in filter functions for SQL queries Signed-off-by: Deluan <[email protected]> * feat(library): add refresh functionality on LibrarySelector close Signed-off-by: Deluan <[email protected]> * feat(artist): add library ID filtering for artists in repository and update resource filtering logic Signed-off-by: Deluan <[email protected]> # Conflicts: # persistence/artist_repository.go * Add library_id field support for smart playlists - Add library_id field to smart playlist criteria system - Supports Is and IsNot operators for filtering by library ID - Includes comprehensive test coverage for single values and lists - Enables creation of library-specific smart playlists * feat(subsonic): implement user-specific library access in GetMusicFolders Signed-off-by: Deluan <[email protected]> * feat(library): enhance LibrarySelectionField to extract library IDs from record Signed-off-by: Deluan <[email protected]> * feat(subsonic): update GetIndexes and GetArtists method to support library ID filtering Signed-off-by: Deluan <[email protected]> * fix: ensure LibrarySelector dropdown refreshes on button close Added refresh() call when closing the dropdown via button click to maintain consistency with the ClickAwayListener behavior. This ensures the UI updates properly regardless of how the dropdown is closed, fixing an inconsistent refresh behavior between different closing methods. The fix tracks the previous open state and calls refresh() only when the dropdown was open and is being closed by the button click. * refactor: simplify getUserAccessibleLibraries function and update related tests Signed-off-by: Deluan <[email protected]> * feat: enhance selectedMusicFolderIds function to handle valid music folder IDs and improve fallback logic Signed-off-by: Deluan <[email protected]> * refactor: change ArtistRepository.GetIndex to accept multiple library IDs Updated the GetIndex method signature to accept a slice of library IDs instead of a single ID, enabling support for filtering artists across multiple libraries simultaneously. Changes include: - Modified ArtistRepository interface in model/artist.go - Updated implementation in persistence/artist_repository.go with improved library filtering logic - Refactored Subsonic API browsing.go to use new selectedMusicFolderIds helper - Added comprehensive test coverage for multiple library scenarios - Updated mock repository implementation for testing This change improves flexibility for multi-library operations while maintaining backward compatibility through the selectedMusicFolderIds helper function. * feat: add library access validation to selectedMusicFolderIds Enhanced the selectedMusicFolderIds function to validate musicFolderId parameters against the user's accessible libraries. Invalid library IDs (those the user doesn't have access to) are now silently filtered out, improving security by preventing users from accessing libraries they don't have permission for. Changes include: - Added validation logic to check musicFolderId parameters against user's accessible libraries - Added slices package import for efficient validation - Enhanced function documentation to clarify validation behavior - Added comprehensive test cases covering validation scenarios - Maintains backward compatibility with existing behavior * feat: implement multi-library support for GetAlbumList and GetAlbumList2 endpoints - Enhanced selectedMusicFolderIds helper to validate and filter library IDs - Added ApplyLibraryFilter function in filter/filters.go for library filtering - Updated getAlbumList to support musicFolderId parameter filtering - Added comprehensive tests for multi-library functionality - Supports single and multiple musicFolderId values - Falls back to all accessible libraries when no musicFolderId provided - Validates library access permissions for user security * feat: implement multi-library support for GetRandomSongs, GetSongsByGenre, GetStarred, and GetStarred2 - Added multi-library filtering to GetRandomSongs endpoint using musicFolderId parameter - Added multi-library filtering to GetSongsByGenre endpoint using musicFolderId parameter - Enhanced GetStarred and GetStarred2 to filter artists, albums, and songs by library - Added Options field to MockMediaFileRepo and MockArtistRepo for test compatibility - Added comprehensive Ginkgo/Gomega tests for all new multi-library functionality - All tests verify proper SQL filter generation and library access validation - Supports single/multiple musicFolderId values with fallback to all accessible libraries * refactor: optimize starred items queries with parallel execution and fix test isolation Refactored starred items functionality by extracting common logic into getStarredItems() method that executes artist, album, and media file queries in parallel for better performance. This eliminates code duplication between GetStarred and GetStarred2 methods while improving response times through concurrent database queries using run.Parallel(). Also fixed test isolation issues by adding missing auth.Init(ds) call in album lists test setup. This resolves nil pointer dereference errors in GetStarred and GetStarred2 tests when run independently. * fix: add ApplyArtistLibraryFilter to filter artists by associated music folders Signed-off-by: Deluan <[email protected]> * feat: add library access methods to User model Signed-off-by: Deluan <[email protected]> * feat: implement library access filtering for artist queries based on user permissions Signed-off-by: Deluan <[email protected]> * feat: enhance artist library filtering based on user permissions and optimize library ID retrieval Signed-off-by: Deluan <[email protected]> * fix: return error when any musicFolderId is invalid or inaccessible Changed behavior from silently filtering invalid library IDs to returning ErrorDataNotFound (code 70) when any provided musicFolderId parameter is invalid or the user doesn't have access to it. The error message includes the specific library number for better debugging. This affects album/song list endpoints (getAlbumList, getRandomSongs, getSongsByGenre, getStarred) to provide consistent error handling across all Subsonic API endpoints. Updated corresponding tests to expect errors instead of silent filtering. * feat: add musicFolderId parameter support to Search2 and Search3 endpoints Implemented musicFolderId parameter support for Subsonic API Search2 and Search3 endpoints, completing multi-library functionality across all Subsonic endpoints. Key changes: - Added musicFolderId parameter handling to Search2 and Search3 endpoints - Updated search logic to filter results by specified library or all accessible libraries when parameter not provided - Added proper error handling for invalid/inaccessible musicFolderId values - Refactored SearchableRepository interface to support library filtering with variadic QueryOptions - Updated repository implementations (Album, Artist, MediaFile) to handle library filtering in search operations - Added comprehensive test coverage with robust assertions verifying library filtering works correctly - Enhanced mock repositories to capture QueryOptions for test validation Signed-off-by: Deluan <[email protected]> * feat: refresh LibraryList on scan end Signed-off-by: Deluan <[email protected]> * fix: allow editing name of main library Signed-off-by: Deluan <[email protected]> * refactor: implement SendBroadcastMessage method for event broadcasting Signed-off-by: Deluan <[email protected]> * feat: add event broadcasting for library creation, update, and deletion Signed-off-by: Deluan <[email protected]> * feat: add useRefreshOnEvents hook for custom refresh logic on event changes Signed-off-by: Deluan <[email protected]> * feat: enhance library management with refresh event broadcasting Signed-off-by: Deluan <[email protected]> * feat: replace AddUserLibrary and RemoveUserLibrary with SetUserLibraries for better library management Signed-off-by: Deluan <[email protected]> * chore: remove commented-out genre repository code from persistence tests * feat: enhance library selection with master checkbox functionality Added a master checkbox to the SelectLibraryInput component, allowing users to select or deselect all libraries at once. This improves user experience by simplifying the selection process when multiple libraries are available. Additionally, updated translations in the en.json file to include a new message for selecting all libraries, ensuring consistency in user interface messaging. Signed-off-by: Deluan <[email protected]> * feat: add default library assignment for new users Introduced a new column `default_new_users` in the library table to facilitate automatic assignment of default libraries to new regular users. When a new user is created, they will now be assigned to libraries marked as default, enhancing user experience by ensuring they have immediate access to essential resources. Additionally, updated the user repository logic to handle this new functionality and modified the user creation validation to reflect that library selection is optional for non-admin users. Signed-off-by: Deluan <[email protected]> * fix: correct updated_at assignment in library repository Signed-off-by: Deluan <[email protected]> * fix: improve cache buffering logic Refactored the cache buffering logic to ensure thread safety when checking the buffer length Signed-off-by: Deluan <[email protected]> * fix formating Signed-off-by: Deluan <[email protected]> * feat: implement per-library artist statistics with automatic aggregation Implemented comprehensive multi-library support for artist statistics that automatically aggregates stats from user-accessible libraries. This fundamental change moves artist statistics from global scope to per-library granularity while maintaining backward compatibility and transparent operation. Key changes include: - Migrated artist statistics from global artist.stats to per-library library_artist.stats - Added automatic library filtering and aggregation in existing Get/GetAll methods - Updated role-based filtering to work with per-library statistics storage - Enhanced statistics calculation to process and store stats per library - Implemented user permission-aware aggregation that respects library access control - Added comprehensive test coverage for library filtering and restricted user access - Created helper functions to ensure proper library associations in tests This enables users to see statistics that accurately reflect only the content from libraries they have access to, providing proper multi-tenant behavior while maintaining the existing API surface and UI functionality. Signed-off-by: Deluan <[email protected]> * feat: add multi-library support with per-library tag statistics - WIP Signed-off-by: Deluan <[email protected]> * refactor: genre and tag repositories. add comprehensive tests Signed-off-by: Deluan <[email protected]> * feat: add multi-library support to tag repository system Implemented comprehensive library filtering for tag repositories to support the multi-library feature. This change ensures that users only see tags from libraries they have access to, while admin users can see all tags. Key changes: - Enhanced TagRepository.Add() method to accept libraryID parameter for proper library association - Updated baseTagRepository to implement library-aware queries with proper joins - Added library_tag table integration for per-library tag statistics - Implemented user permission-based filtering through user_library associations - Added comprehensive test coverage for library filtering scenarios - Updated UI data provider to include tag filtering by selected libraries - Modified scanner to pass library ID when adding tags during folder processing The implementation maintains backward compatibility while providing proper isolation between libraries for tag-based operations like genres and other metadata tags. * refactor: simplify artist repository library filtering Removed conditional admin logic from applyLibraryFilterToArtistQuery method and unified the library filtering approach to match the tag repository pattern. The method now always uses the same SQL join structure regardless of user role, with admin access handled automatically through user_library associations. Added artistLibraryIdFilter function to properly qualify library_id column references and prevent SQL ambiguity errors when multiple tables contain library_id columns. This ensures the filter targets library_artist.library_id specifically rather than causing ambiguous column name conflicts. * fix: resolve LibrarySelectionField validation error for non-admin users Fixed validation error 'At least one library must be selected for non-admin users' that appeared even when libraries were selected. The issue was caused by a data format mismatch between backend and frontend. The backend sends user data with libraries as an array of objects, but the LibrarySelectionField component expects libraryIds as an array of IDs. Added data transformation in the data provider's getOne method to automatically convert libraries array to libraryIds format when fetching user records. Also extracted validation logic into a separate userValidation module for better code organization and added comprehensive test coverage to prevent similar issues. * refactor: remove unused library access functions and related tests Signed-off-by: Deluan <[email protected]> * refactor: rename search_test.go to searching_test.go for consistency Signed-off-by: Deluan <[email protected]> * fix: add user context to scrobble buffer getParticipants call Added user context handling to scrobbleBufferRepository.Next method to resolve SQL error 'no such column: library_artist.library_id' when processing scrobble entries in multi-library environments. The artist repository now requires user context for proper library filtering, so we fetch the user and temporarily inject it into the context before calling getParticipants. This ensures background scrobbling operations work correctly with multi-library support. * feat: add cross-library move detection for scanner Implemented cross-library move detection for the scanner phase 2 to properly handle files moved between libraries. This prevents users from losing play counts, ratings, and other metadata when moving files across library boundaries. Changes include: - Added MediaFileRepository methods for two-tier matching: FindRecentFilesByMBZTrackID (primary) and FindRecentFilesByProperties (fallback) - Extended scanner phase 2 pipeline with processCrossLibraryMoves stage that processes files unmatched within their library - Implemented findCrossLibraryMatch with MusicBrainz Release Track ID priority and intrinsic properties fallback - Updated producer logic to handle missing tracks without matches, ensuring cross-library processing - Updated tests to reflect new producer behavior and cross-library functionality The implementation uses existing moveMatched function for unified move operations, automatically preserving all user data through database foreign key relationships. Cross-library moves are detected using the same Equals() and IsEquivalent() matching logic as within-library moves for consistency. Signed-off-by: Deluan <[email protected]> * feat: add album annotation reassignment for cross-library moves Implemented album annotation reassignment functionality for the scanner's missing tracks phase. When tracks move between libraries and change album IDs, the system now properly reassigns album annotations (starred status, ratings) from the old album to the new album. This prevents loss of user annotations when tracks are moved across library boundaries. The implementation includes: - Thread-safe annotation reassignment using mutex protection - Duplicate reassignment prevention through processed album tracking - Graceful error handling that doesn't fail the entire move operation - Comprehensive test coverage for various scenarios including error conditions This enhancement ensures data integrity and user experience continuity during cross-library media file movements. * fix: address PR review comments for multi-library support Fixed several issues identified in PR review: - Removed unnecessary artist stats initialization check since the map is already initialized in PostScan() - Improved code clarity in user repository by extracting isNewUser variable to avoid checking count == 0 twice - Fixed library selection logic to properly handle initial library state and prevent overriding user selections These changes address code quality and logic issues identified during the multi-library support PR review. * feat: add automatic playlist statistics refreshing Implemented automatic playlist statistics (duration, size, song count) refreshing when tracks are modified. Added new refreshStats() method to recalculate statistics from playlist tracks, and SetTracks() method to update tracks and refresh statistics atomically. Modified all track manipulation methods (RemoveTracks, AddTracks, AddMediaFiles) to automatically refresh statistics. Updated playlist repository to use the new SetTracks method for consistent statistics handling. * refactor: rename AddTracks to AddMediaFilesByID for clarity Renamed the AddTracks method to AddMediaFilesByID throughout the codebase to better reflect its purpose of adding media files to a playlist by their IDs. This change improves code readability and makes the method name more descriptive of its actual functionality. Updated all references in playlist model, tests, core playlist logic, and Subsonic API handlers to use the new method name. * refactor: consolidate user context access in persistence layer Removed duplicate helper functions userId() and isAdmin() from sql_base_repository.go and consolidated all user context access to use loggedUser(r.ctx).ID and loggedUser(r.ctx).IsAdmin consistently across the persistence layer. This change eliminates code duplication and provides a single, consistent pattern for accessing user context information in repository methods. All functionality remains unchanged - this is purely a code cleanup refactoring. * refactor: eliminate MockLibraryService duplication using embedded struct - Replace 235-line MockLibraryService with 40-line embedded struct pattern - Enhance MockLibraryRepo with service-layer methods (192→310 lines) - Maintain full compatibility with existing tests - All 72 nativeapi specs pass with proper error handling Signed-off-by: Deluan <[email protected]> * refactor: cleanup Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
b63630fa6e |
fix(scanner) artist stats not refreshing during quick scan and after missing file deletion (#4269)
* Fix artist not being marked as touched during quick scans When a new album is added during quick scans, artists were not being marked as 'touched' due to media files having older modification times than the scan completion time. Changes: - Add 'updated_at' to artist Put() columns in scanner to ensure timestamp is set when artists are processed - Simplify RefreshStats query to check artist.updated_at directly instead of complex media file joins - Artists from new albums now properly get refreshed in later phases This fixes the issue where newly added albums would have incomplete artist information after quick scans. * fix(missing): refresh artist stats in background after deleting missing files Signed-off-by: Deluan <[email protected]> * fix(request): add InternalAuth to user context Signed-off-by: Deluan <[email protected]> * Add comprehensive test for artist stats update during quick scans - Add test that verifies artist statistics are correctly updated when new files are added during incremental scans - Test ensures both overall stats (AlbumCount, SongCount) and role-specific stats are properly refreshed - Validates fix for artist stats not being refreshed during quick scans when new albums are added - Uses real artist repository instead of mock to verify actual stats calculation behavior --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
410e457e5a |
feat(server): add update and clear play queue endpoints to native API (#4215)
* Refactor queue payload handling * Refine queue update validation * refactor(queue): avoid loading tracks for validation * refactor/rename repository methods Signed-off-by: Deluan <[email protected]> * more tests Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
8fcd8ba61a |
feat(server): add index-based play queue endpoints to native API (#4210)
* Add migration converting playqueue current to index * refactor Signed-off-by: Deluan <[email protected]> * fix(queue): ensure valid current index and improve test coverage Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
4172d2332a |
feat(ui): add song Love and Rating functionality to playlist view (#4134)
* feat(ui): add playlist track love button Signed-off-by: Deluan <[email protected]> * feat(ui): add star rating feature for playlist tracks Signed-off-by: Deluan <[email protected]> * fix(ui): handle loading state and error logging in toggle love and rating components Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
9c4af3c6d0 |
fix(server): don't override /song routes
Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
36ed2f2f58 |
refactor: simplify configuration endpoint with JSON serialization (#4159)
* refactor(config): reorganize configuration handling Signed-off-by: Deluan <[email protected]> * refactor(aboutUtils): improve array formatting and handling in TOML conversion Signed-off-by: Deluan <[email protected]> * refactor(aboutUtils): add escapeTomlKey function to handle special characters in TOML keys Signed-off-by: Deluan <[email protected]> * fix(test): remove unused getNestedValue function * fix(ui): apply prettier formatting --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
ded8cf236e |
feat(ui): add 'Show in Playlist' context menu (#4139)
* Update song playlist menu and endpoint * feat(ui): show submenu on click, not on hover Signed-off-by: Deluan <[email protected]> * feat(ui): integrate dataProvider for fetching playlists in song context menu Signed-off-by: Deluan <[email protected]> * feat(ui): update song context menu to use dataProvider for fetching playlists and inspecting songs Signed-off-by: Deluan <[email protected]> * feat(ui): stop event propagation when closing playlist submenu Signed-off-by: Deluan <[email protected]> * feat(ui): add 'show in playlist' option to options object Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
6dd98e0bed |
feat(ui): add configuration tab in About dialog (#4142)
* Flatten config endpoint and improve About dialog * add config resource Signed-off-by: Deluan <[email protected]> * fix(ui): replace `==` with `===` Signed-off-by: Deluan <[email protected]> * feat(ui): add environment variables Signed-off-by: Deluan <[email protected]> * feat(ui): add sensitive value redaction Signed-off-by: Deluan <[email protected]> * feat(ui): more translations Signed-off-by: Deluan <[email protected]> * address PR comments Signed-off-by: Deluan <[email protected]> * feat(ui): add configuration export feature in About dialog Signed-off-by: Deluan <[email protected]> * feat(ui): translate development flags section header Signed-off-by: Deluan <[email protected]> * refactor Signed-off-by: Deluan <[email protected]> * feat(api): refactor routes for keepalive and insights endpoints Signed-off-by: Deluan <[email protected]> * lint Signed-off-by: Deluan <[email protected]> * fix(ui): enhance string escaping in formatTomlValue function Updated the formatTomlValue function to properly escape backslashes in addition to quotes. Added new test cases to ensure correct handling of strings containing both backslashes and quotes. Signed-off-by: Deluan <[email protected]> * feat(ui): adjust dialog size Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
3ccc02f375 |
feat(ui): add remove all missing files functionality (#4108)
* Add remove all missing files feature * test: update mediafile_repository tests for missing files deletion Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
|
1468a56808 |
fix(server): reduce SQLite "database busy" errors (#3760)
* fix(scanner): remove transactions where they are not strictly needed Signed-off-by: Deluan <[email protected]> * fix(server): force setStar transaction to start as IMMEDIATE Signed-off-by: Deluan <[email protected]> * fix(server): encapsulated way to upgrade tx to write mode Signed-off-by: Deluan <[email protected]> * fix(server): use tx immediate for some playlist endpoints Signed-off-by: Deluan <[email protected]> * make more transactions immediate (#3759) --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Kendall Garner <[email protected]> |
||
|
|
c795bcfcf7 |
feat(bfr): Big Refactor: new scanner, lots of new fields and tags, improvements and DB schema changes (#2709)
* fix(server): more race conditions when updating artist/album from external sources Signed-off-by: Deluan <[email protected]> * feat(scanner): add .gitignore syntax to .ndignore. Resolves #1394 Signed-off-by: Deluan <[email protected]> * fix(ui): null Signed-off-by: Deluan <[email protected]> * fix(scanner): pass configfile option to child process Signed-off-by: Deluan <[email protected]> * fix(scanner): resume interrupted fullScans Signed-off-by: Deluan <[email protected]> * fix(scanner): remove old scanner code Signed-off-by: Deluan <[email protected]> * fix(scanner): rename old metadata package Signed-off-by: Deluan <[email protected]> * fix(scanner): move old metadata package Signed-off-by: Deluan <[email protected]> * fix: tests Signed-off-by: Deluan <[email protected]> * chore(deps): update Go to 1.23.4 Signed-off-by: Deluan <[email protected]> * fix: logs Signed-off-by: Deluan <[email protected]> * fix(test): Signed-off-by: Deluan <[email protected]> * fix: log level Signed-off-by: Deluan <[email protected]> * fix: remove log message Signed-off-by: Deluan <[email protected]> * feat: add config for scanner watcher Signed-off-by: Deluan <[email protected]> * refactor: children playlists Signed-off-by: Deluan <[email protected]> * refactor: replace `interface{}` with `any` Signed-off-by: Deluan <[email protected]> * fix: smart playlists with genres Signed-off-by: Deluan <[email protected]> * fix: allow any tags in smart playlists Signed-off-by: Deluan <[email protected]> * fix: artist names in playlists Signed-off-by: Deluan <[email protected]> * fix: smart playlist's sort by tags Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to AlbumID3 Signed-off-by: Deluan <[email protected]> * refactor(subsonic): use generic JSONArray for OS arrays Signed-off-by: Deluan <[email protected]> * refactor(subsonic): use https in test Signed-off-by: Deluan <[email protected]> * feat(subsonic): add releaseTypes to AlbumID3 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add recordLabels to AlbumID3 Signed-off-by: Deluan <[email protected]> * refactor(subsonic): rename JSONArray to Array Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to AlbumID3 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to Child Signed-off-by: Deluan <[email protected]> * fix(scanner): do not pre-populate smart playlists Signed-off-by: Deluan <[email protected]> * feat(subsonic): implement a simplified version of ArtistID3. See https://github.com/opensubsonic/open-subsonic-api/discussions/120 Signed-off-by: Deluan <[email protected]> * feat(subsonic): add artists to album child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add contributors to mediafile Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add albumArtists to mediafile Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add displayArtist and displayAlbumArtist Signed-off-by: Deluan <[email protected]> * feat(subsonic): add displayComposer to Child Signed-off-by: Deluan <[email protected]> * feat(subsonic): add roles to ArtistID3 Signed-off-by: Deluan <[email protected]> * fix(subsonic): use " • " separator for displayComposer Signed-off-by: Deluan <[email protected]> * refactor: Signed-off-by: Deluan <[email protected]> * fix(subsonic): Signed-off-by: Deluan <[email protected]> * fix(subsonic): respect `PreferSortTags` config option Signed-off-by: Deluan <[email protected]> * refactor(subsonic): Signed-off-by: Deluan <[email protected]> * refactor: optimize purging non-unused tags Signed-off-by: Deluan <[email protected]> * refactor: don't run 'refresh artist stats' concurrently with other transactions Signed-off-by: Deluan <[email protected]> * refactor: Signed-off-by: Deluan <[email protected]> * fix: log message Signed-off-by: Deluan <[email protected]> * feat: add Scanner.ScanOnStartup config option, default true Signed-off-by: Deluan <[email protected]> * feat: better json parsing error msg when importing NSPs Signed-off-by: Deluan <[email protected]> * fix: don't update album's imported_time when updating external_metadata Signed-off-by: Deluan <[email protected]> * fix: handle interrupted scans and full scans after migrations Signed-off-by: Deluan <[email protected]> * feat: run `analyze` when migration requires a full rescan Signed-off-by: Deluan <[email protected]> * feat: run `PRAGMA optimize` at the end of the scan Signed-off-by: Deluan <[email protected]> * fix: don't update artist's updated_at when updating external_metadata Signed-off-by: Deluan <[email protected]> * feat: handle multiple artists and roles in smart playlists Signed-off-by: Deluan <[email protected]> * feat(ui): dim missing tracks Signed-off-by: Deluan <[email protected]> * fix: album missing logic Signed-off-by: Deluan <[email protected]> * fix: error encoding in gob Signed-off-by: Deluan <[email protected]> * feat: separate warnings from errors Signed-off-by: Deluan <[email protected]> * fix: mark albums as missing if they were contained in a deleted folder Signed-off-by: Deluan <[email protected]> * refactor: add participant names to media_file and album tables Signed-off-by: Deluan <[email protected]> * refactor: use participations in criteria, instead of m2m relationship Signed-off-by: Deluan <[email protected]> * refactor: rename participations to participants Signed-off-by: Deluan <[email protected]> * feat(subsonic): add moods to album child Signed-off-by: Deluan <[email protected]> * fix: albumartist role case Signed-off-by: Deluan <[email protected]> * feat(scanner): run scanner as an external process by default Signed-off-by: Deluan <[email protected]> * fix(ui): show albumArtist names Signed-off-by: Deluan <[email protected]> * fix(ui): dim out missing albums Signed-off-by: Deluan <[email protected]> * fix: flaky test Signed-off-by: Deluan <[email protected]> * fix(server): scrobble buffer mapping. fix #3583 Signed-off-by: Deluan <[email protected]> * refactor: more participations renaming Signed-off-by: Deluan <[email protected]> * fix: listenbrainz scrobbling Signed-off-by: Deluan <[email protected]> * feat: send release_group_mbid to listenbrainz Signed-off-by: Deluan <[email protected]> * feat(subsonic): implement OpenSubsonic explicitStatus field (#3597) * feat: implement OpenSubsonic explicitStatus field * fix(subsonic): fix failing snapshot tests * refactor: create helper for setting explicitStatus * fix: store smaller values for explicit-status on database * test: ToAlbum explicitStatus * refactor: rename explicitStatus helper function --------- Co-authored-by: Deluan Quintão <[email protected]> * fix: handle album and track tags in the DB based on the mappings.yaml file Signed-off-by: Deluan <[email protected]> * save similar artists as JSONB Signed-off-by: Deluan <[email protected]> * fix: getAlbumList byGenre Signed-off-by: Deluan <[email protected]> * detect changes in PID configuration Signed-off-by: Deluan <[email protected]> * set default album PID to legacy_pid Signed-off-by: Deluan <[email protected]> * fix tests Signed-off-by: Deluan <[email protected]> * fix SIGSEGV Signed-off-by: Deluan <[email protected]> * fix: don't lose album stars/ratings when migrating Signed-off-by: Deluan <[email protected]> * store full PID conf in properties Signed-off-by: Deluan <[email protected]> * fix: keep album annotations when changing PID.Album config Signed-off-by: Deluan <[email protected]> * fix: reassign album annotations Signed-off-by: Deluan <[email protected]> * feat: use (display) albumArtist and add links to each artist Signed-off-by: Deluan <[email protected]> * fix: not showing albums by albumartist Signed-off-by: Deluan <[email protected]> * fix: error msgs Signed-off-by: Deluan <[email protected]> * fix: hide PID from Native API Signed-off-by: Deluan <[email protected]> * fix: album cover art resolution Signed-off-by: Deluan <[email protected]> * fix: trim participant names Signed-off-by: Deluan <[email protected]> * fix: reduce watcher log spam Signed-off-by: Deluan <[email protected]> * fix: panic when initializing the watcher Signed-off-by: Deluan <[email protected]> * fix: various artists Signed-off-by: Deluan <[email protected]> * fix: don't store empty lyrics in the DB Signed-off-by: Deluan <[email protected]> * remove unused methods Signed-off-by: Deluan <[email protected]> * drop full_text indexes, as they are not being used by SQLite Signed-off-by: Deluan <[email protected]> * keep album created_at when upgrading Signed-off-by: Deluan <[email protected]> * fix(ui): null pointer Signed-off-by: Deluan <[email protected]> * fix: album artwork cache Signed-off-by: Deluan <[email protected]> * fix: don't expose missing files in Subsonic API Signed-off-by: Deluan <[email protected]> * refactor: searchable interface Signed-off-by: Deluan <[email protected]> * fix: filter out missing items from subsonic search * fix: filter out missing items from playlists * fix: filter out missing items from shares Signed-off-by: Deluan <[email protected]> * feat(ui): add filter by artist role Signed-off-by: Deluan <[email protected]> * feat(subsonic): only return albumartists in getIndexes and getArtists endpoints Signed-off-by: Deluan <[email protected]> * sort roles alphabetically Signed-off-by: Deluan <[email protected]> * fix: artist playcounts Signed-off-by: Deluan <[email protected]> * change default Album PID conf Signed-off-by: Deluan <[email protected]> * fix albumartist link when it does not match any albumartists values Signed-off-by: Deluan <[email protected]> * fix `Ignoring filter not whitelisted` (role) message Signed-off-by: Deluan <[email protected]> * fix: trim any names/titles being imported Signed-off-by: Deluan <[email protected]> * remove unused genre code Signed-off-by: Deluan <[email protected]> * serialize calls to Last.fm's getArtist Signed-off-by: Deluan <[email protected]> xxx Signed-off-by: Deluan <[email protected]> * add counters to genres Signed-off-by: Deluan <[email protected]> * nit: fix migration `notice` message Signed-off-by: Deluan <[email protected]> * optimize similar artists query Signed-off-by: Deluan <[email protected]> * fix: last.fm.getInfo when mbid does not exist Signed-off-by: Deluan <[email protected]> * ui only show missing items for admins Signed-off-by: Deluan <[email protected]> * don't allow interaction with missing items Signed-off-by: Deluan <[email protected]> * Add Missing Files view (WIP) Signed-off-by: Deluan <[email protected]> * refactor: merged tag_counts into tag table Signed-off-by: Deluan <[email protected]> * add option to completely disable automatic scanner Signed-off-by: Deluan <[email protected]> * add delete missing files functionality Signed-off-by: Deluan <[email protected]> * fix: playlists not showing for regular users Signed-off-by: Deluan <[email protected]> * reduce updateLastAccess frequency to once every minute Signed-off-by: Deluan <[email protected]> * reduce update player frequency to once every minute Signed-off-by: Deluan <[email protected]> * add timeout when updating player Signed-off-by: Deluan <[email protected]> * remove dead code Signed-off-by: Deluan <[email protected]> * fix duplicated roles in stats Signed-off-by: Deluan <[email protected]> * add `; ` to artist splitters Signed-off-by: Deluan <[email protected]> * fix stats query Signed-off-by: Deluan <[email protected]> * more logs Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * fix: support legacy clients (DSub) by removing OpenSubsonic extra fields - WIP Signed-off-by: Deluan <[email protected]> * add record label filter Signed-off-by: Deluan <[email protected]> * add release type filter Signed-off-by: Deluan <[email protected]> * fix purgeUnused tags Signed-off-by: Deluan <[email protected]> * add grouping filter to albums Signed-off-by: Deluan <[email protected]> * allow any album tags to be used in as filters in the API Signed-off-by: Deluan <[email protected]> * remove empty tags from album info Signed-off-by: Deluan <[email protected]> * comments in the migration Signed-off-by: Deluan <[email protected]> * fix: Cannot read properties of undefined Signed-off-by: Deluan <[email protected]> * fix: listenbrainz scrobbling (#3640) Signed-off-by: Deluan <[email protected]> * fix: remove duplicated tag values Signed-off-by: Deluan <[email protected]> * fix: don't ignore the taglib folder! Signed-off-by: Deluan <[email protected]> * feat: show track subtitle tag Signed-off-by: Deluan <[email protected]> * fix: show artists stats based on selected role Signed-off-by: Deluan <[email protected]> * fix: inspect Signed-off-by: Deluan <[email protected]> * add media type to album info/filters Signed-off-by: Deluan <[email protected]> * fix: change format of subtitle in the UI Signed-off-by: Deluan <[email protected]> * fix: subtitle in Subsonic API and search Signed-off-by: Deluan <[email protected]> * fix: subtitle in UI's player Signed-off-by: Deluan <[email protected]> * fix: split strings should be case-insensitive Signed-off-by: Deluan <[email protected]> * disable ScanSchedule Signed-off-by: Deluan <[email protected]> * increase default sessiontimeout Signed-off-by: Deluan <[email protected]> * add sqlite command line tool to docker image Signed-off-by: Deluan <[email protected]> * fix: resources override Signed-off-by: Deluan <[email protected]> * fix: album PID conf Signed-off-by: Deluan <[email protected]> * change migration to mark current artists as albumArtists Signed-off-by: Deluan <[email protected]> * feat(ui): Allow filtering on multiple genres (#3679) * feat(ui): Allow filtering on multiple genres Signed-off-by: Henrik Nordvik <[email protected]> Signed-off-by: Deluan <[email protected]> * add multi-genre filter in Album list Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Henrik Nordvik <[email protected]> Signed-off-by: Deluan <[email protected]> Co-authored-by: Henrik Nordvik <[email protected]> * add more multi-valued tag filters to Album and Song views Signed-off-by: Deluan <[email protected]> * fix(ui): unselect missing files after removing Signed-off-by: Deluan <[email protected]> * fix(ui): song filter Signed-off-by: Deluan <[email protected]> * fix sharing tracks. fix #3687 Signed-off-by: Deluan <[email protected]> * use rowids when using search for sync (ex: Symfonium) Signed-off-by: Deluan <[email protected]> * fix "Report Real Paths" option for subsonic clients Signed-off-by: Deluan <[email protected]> * fix "Report Real Paths" option for subsonic clients for search Signed-off-by: Deluan <[email protected]> * add libraryPath to Native API /songs endpoint Signed-off-by: Deluan <[email protected]> * feat(subsonic): add album version Signed-off-by: Deluan <[email protected]> * made all tags lowercase as they are case-insensitive anyways. Signed-off-by: Deluan <[email protected]> * feat(ui): Show full paths, extended properties for album/song (#3691) * feat(ui): Show full paths, extended properties for album/song - uses library path + os separator + path - show participants (album/song) and tags (song) - make album/participant clickable in show info * add source to path * fix pathSeparator in UI Signed-off-by: Deluan <[email protected]> * fix local artist artwork (#3695) Signed-off-by: Deluan <[email protected]> * fix: parse vorbis performers Signed-off-by: Deluan <[email protected]> * refactor: clean function into smaller functions Signed-off-by: Deluan <[email protected]> * fix translations for en and pt Signed-off-by: Deluan <[email protected]> * add trace log to show annotations reassignment Signed-off-by: Deluan <[email protected]> * add trace log to show annotations reassignment Signed-off-by: Deluan <[email protected]> * fix: allow performers without instrument/subrole Signed-off-by: Deluan <[email protected]> * refactor: metadata clean function again Signed-off-by: Deluan <[email protected]> * refactor: optimize split function Signed-off-by: Deluan <[email protected]> * refactor: split function is now a method of TagConf Signed-off-by: Deluan <[email protected]> * fix: humanize Artist total size Signed-off-by: Deluan <[email protected]> * add album version to album details Signed-off-by: Deluan <[email protected]> * don't display album-level tags in SongInfo Signed-off-by: Deluan <[email protected]> * fix genre clicking in Album Page Signed-off-by: Deluan <[email protected]> * don't use mbids in Last.fm api calls. From https://discord.com/channels/671335427726114836/704303730660737113/1337574018143879248: With MBID: ``` GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&mbid=a41ac10f-0a56-4672-9161-b83f9b223559&method=artist.getInfo { artist: { name: "Bee Gees", mbid: "bf0f7e29-dfe1-416c-b5c6-f9ebc19ea810", url: "https://www.last.fm/music/Bee+Gees", } ``` Without MBID: ``` GET https://ws.audioscrobbler.com/2.0/?api_key=XXXX&artist=Van+Morrison&format=json&lang=en&method=artist.getInfo { artist: { name: "Van Morrison", mbid: "a41ac10f-0a56-4672-9161-b83f9b223559", url: "https://www.last.fm/music/Van+Morrison", } ``` Signed-off-by: Deluan <[email protected]> * better logging for when the artist folder is not found Signed-off-by: Deluan <[email protected]> * fix various issues with artist image resolution Signed-off-by: Deluan <[email protected]> * hide "Additional Tags" header if there are none. Signed-off-by: Deluan <[email protected]> * simplify tag rendering Signed-off-by: Deluan <[email protected]> * enhance logging for artist folder detection Signed-off-by: Deluan <[email protected]> * make folderID consistent for relative and absolute folderPaths Signed-off-by: Deluan <[email protected]> * handle more folder paths scenarios Signed-off-by: Deluan <[email protected]> * filter out other roles when SubsonicArtistParticipations = true Signed-off-by: Deluan <[email protected]> * fix "Cannot read properties of undefined" Signed-off-by: Deluan <[email protected]> * fix lyrics and comments being truncated (#3701) * fix lyrics and comments being truncated * specifically test for lyrics and comment length * reorder assertions Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> * fix(server): Expose library_path for playlist (#3705) Allows showing absolute path for UI, and makes "report real path" work for playlists (Subsonic) * fix BFR on Windows (#3704) * fix potential reflected cross-site scripting vulnerability Signed-off-by: Deluan <[email protected]> * hack to make it work on Windows * ignore windows executables * try fixing the pipeline Signed-off-by: Deluan <[email protected]> * allow MusicFolder in other drives * move windows local drive logic to local storage implementation --------- Signed-off-by: Deluan <[email protected]> * increase pagination sizes for missing files Signed-off-by: Deluan <[email protected]> * reduce level of "already scanning" watcher log message Signed-off-by: Deluan <[email protected]> * only count folders with audio files in it See https://github.com/navidrome/navidrome/discussions/3676#discussioncomment-11990930 Signed-off-by: Deluan <[email protected]> * add album version and catalog number to search Signed-off-by: Deluan <[email protected]> * add `organization` alias for `recordlabel` Signed-off-by: Deluan <[email protected]> * remove mbid from Last.fm agent Signed-off-by: Deluan <[email protected]> * feat: support inspect in ui (#3726) * inspect in ui * address round 1 * add catalogNum to AlbumInfo Signed-off-by: Deluan <[email protected]> * remove dependency on metadata_old (deprecated) package Signed-off-by: Deluan <[email protected]> * add `RawTags` to model Signed-off-by: Deluan <[email protected]> * support parsing MBIDs for roles (from the https://github.com/kgarner7/picard-all-mbids plugin) (#3698) * parse standard roles, vorbis/m4a work for now * fix djmixer * working roles, use DJ-mix * add performers to file * map mbids * add a few more tests * add test Signed-off-by: Deluan <[email protected]> * try to simplify the performers logic Signed-off-by: Deluan <[email protected]> * stylistic changes --------- Signed-off-by: Deluan <[email protected]> Co-authored-by: Deluan <[email protected]> * remove param mutation Signed-off-by: Deluan <[email protected]> * run automated SQLite optimizations Signed-off-by: Deluan <[email protected]> * fix playlists import/export on Windows * fix import playlists * fix export playlists * better handling of Windows volumes Signed-off-by: Deluan <[email protected]> * handle more album ID reassignments Signed-off-by: Deluan <[email protected]> * allow adding/overriding tags in the config file Signed-off-by: Deluan <[email protected]> * fix(ui): Fix playlist track id, handle missing tracks better (#3734) - Use `mediaFileId` instead of `id` for playlist tracks - Only fetch if the file is not missing - If extractor fails to get the file, also error (rather than panic) * optimize DB after each scan. Signed-off-by: Deluan <[email protected]> * remove sortable from AlbumSongs columns Signed-off-by: Deluan <[email protected]> * simplify query to get missing tracks Signed-off-by: Deluan <[email protected]> * mark Scanner.Extractor as deprecated Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> Signed-off-by: Henrik Nordvik <[email protected]> Co-authored-by: Caio Cotts <[email protected]> Co-authored-by: Henrik Nordvik <[email protected]> Co-authored-by: Kendall Garner <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
8e2052ff95 |
feat(Insights): add anonymous usage data collection (#3543)
* feat(insights): initial code (WIP) * feat(insights): add more info * feat(insights): add fs info * feat(insights): export insights.Data Signed-off-by: Deluan <[email protected]> * feat(insights): more config info Signed-off-by: Deluan <[email protected]> * refactor(insights): move data struct to its own package Signed-off-by: Deluan <[email protected]> * refactor(insights): omit some attrs if empty Signed-off-by: Deluan <[email protected]> * feat(insights): send insights to server, add option to disable Signed-off-by: Deluan <[email protected]> * fix(insights): remove info about anonymous login Signed-off-by: Deluan <[email protected]> * chore(insights): fix lint Signed-off-by: Deluan <[email protected]> * fix(insights): disable collector if EnableExternalServices is false Signed-off-by: Deluan <[email protected]> * fix(insights): fix type casting for 32bit platforms Signed-off-by: Deluan <[email protected]> * fix(insights): remove EnableExternalServices from the collection (as it will always be false) Signed-off-by: Deluan <[email protected]> * chore(insights): fix lint Signed-off-by: Deluan <[email protected]> * refactor(insights): rename function for consistency Signed-off-by: Deluan <[email protected]> * feat(insights): log the data sent to the collector server Signed-off-by: Deluan <[email protected]> * feat(insights): add last collection timestamp to the "about" dialog. Also add opt-out info to the SignUp form Signed-off-by: Deluan <[email protected]> * feat(insights): only sends the initial data collection after an admin user is created Signed-off-by: Deluan <[email protected]> * feat(insights): remove dangling comment Signed-off-by: Deluan <[email protected]> * feat(insights): Translate insights messages Signed-off-by: Deluan <[email protected]> * fix(insights): reporting empty library Signed-off-by: Deluan <[email protected]> * refactor: move URL to consts.js Signed-off-by: Deluan <[email protected]> --------- Signed-off-by: Deluan <[email protected]> |
||
|
Deluan
|
c1adf407a1 |
refactor: load translations with sync.OnceValues
Signed-off-by: Deluan <[email protected]> |
||
|
Deluan QuintãoandGitHub
|
a9334b7787 |
feat(ui): show user's lastAccess (#3342)
* feat(server): update user's lastAccess * feat(ui): show user's lastAccess |
||
|
Kendall GarnerandGitHub
|
9f1794b97e |
Only refresh smart playlist when fetching first track (#3244)
* Only refresh smart playlist when fetching first track * res -> w |
||
|
Deluan
|
dfcc189cff |
Replace all utils.Param* with req.Params
|
||
|
|
26472f46fe |
POST endpoint for importing m3u playlists - #2078 (#2273)
* wip: API endpoint for creating playlists from m3u files * wip: get user id from context * temporarily disable failing test * custom logic for playlist route to accomodate m3u content type * incorporate playlist parsing into existing logic in core * re-enable test * fix locally failing test * Address requested changes. * Improve ImportFile tests. * Remove ownerID as a parameter of ImportM3U. * Write tests for ImportM3U. * Separate ImportM3U test into two. * Test OwnerID and playlist Name. --------- Co-authored-by: Sam Watson <[email protected]> Co-authored-by: caiocotts <[email protected]> |
||
|
Deluan
|
1c7fb74a1d |
Fix writeEvents race condition.
This required removing the compress middleware from the /events route. |
||
|
Deluan
|
68e6115789 |
Rename DevEnableShare to EnableSharing
|
||
|
Deluan
|
e2ea5eba8c |
Disable creation of shares when feature is disabled.
Fix https://github.com/navidrome/navidrome/pull/2106#issuecomment-1404731388 |
||
|
|
8877b1695a |
Add Internet Radio support (#2063)
* add internet radio support * Add dynamic sidebar icon to Radios * Fix typos * Make URL suffix consistent * Fix typo * address feedback * Don't need to preload when playing Internet Radios * Reorder migration, or else it won't be applied * Make Radio list view responsive Also added filter by name, removed RadioActions and RadioContextMenu, and added a default radio icon, in case of favicon is not available. * Simplify StreamField usage * fix button, hide progress on mobile * use js styles over index.css Co-authored-by: Deluan <[email protected]> |
||
|
DeluanandDeluan Quintão
|
16c869ec86 | Optimize playlist cover generation | ||
|
DeluanandDeluan Quintão
|
387acc5f63 | Add public endpoint to expose images | ||
|
Deluan
|
df0f140f9f | Don't refresh smart playlists when generating covers | ||
|
Deluan
|
5943e8f953 | Rename log.LevelCritical to log.LevelFatal | ||
|
Deluan
|
28389fb05e | Add command line M3U exporter. Closes #1914 | ||
|
Deluan
|
9c433b5d68 | Add missing context to logger calls | ||
|
Deluan
|
db67c1277e | Fix error comparisons | ||
|
Deluan
|
cb3ba23fce | New config DefaultLanguage. Closes #1561 | ||
|
Deluan
|
31882abf6f | Upgrade Ginkgo to V2 | ||
|
Deluan
|
028723f721 | Fix loading overridden translations from ${DataFolder}/resources/i18n | ||
|
Deluan
|
12818fb590 | Make song/album/artist endpoints read-only | ||
|
Deluan
|
fa3471f527 |
Simplify resources code, enabling any resource to be overridden (not just translations)
|
||
|
Deluan
|
9072412812 | Fix translations on Windows | ||
|
Deluan
|
5dce499d6d | Fix/Optimized Playlist tracks deletion | ||
|
DeluanandDeluan Quintão
|
2e2a647e67 | Make SmartPlaylists read-only | ||
|
DeluanandDeluan Quintão
|
d200933b68 |
Reduce number of queries for some playlists operations.
Also allow admins to update/delete playlists from other users in the Subsonic API. Closes #1366 |
||
|
Deluan
|
6c3e45de41 | Add songs to playlists with drag and drop | ||
|
Deluan
|
8afa2cd833 |
Remove dependency of deprecated ioutil package
|
||
|
Deluan
|
774ad65155 | Use fs.FS in MergeFS implementation | ||
|
Deluan
|
7540881695 | Small refactorings | ||
|
DeluanandDeluan Quintão
|
20b7e5c49b | Add Genre filters to UI | ||
|
Deluan
|
197d430d15 | Fix lint error | ||
|
Deluan
|
d54129ecd2 |
Rename app package to nativeapi
|