b59eb32961
* fix(subsonic): optimize search3 for high-cardinality FTS queries Use a two-phase query strategy for FTS5 searches to avoid the performance penalty of expensive LEFT JOINs (annotation, bookmark, library) on high-cardinality results like "the". Phase 1 runs a lightweight query (main table + FTS index only) to get sorted, paginated rowids. Phase 2 hydrates only those few rowids with the full JOINs, making them nearly free. For queries with complex ORDER BY expressions that reference joined tables (e.g. artist search sorted by play count), the optimization is skipped and the original single-query approach is used. * fix(search): update order by clauses to include 'rank' for FTS queries Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): reintroduce 'rank' in Phase 2 ORDER BY for FTS queries Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): remove 'rank' from ORDER BY in non-FTS queries and adjust two-phase query handling Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): update FTS ranking to use bm25 weights and simplify ORDER BY qualification Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refine FTS query handling and improve comments for clarity Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refactor full-text search handling to streamline query strategy selection and improve LIKE fallback logic. Increase e2e coverage for search3 Signed-off-by: Deluan <deluan@navidrome.org> * refactor: enhance FTS column definitions and relevance weights Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refactor Search method signatures to remove offset and size parameters, streamline query handling Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): allow single-character queries in search strategies and update related tests Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): make FTS Phase 1 treat Max=0 as no limit, reorganize tests FTS Phase 1 unconditionally called Limit(uint64(options.Max)), which produced LIMIT 0 when Max was zero. This diverged from applyOptions where Max=0 means no limit. Now Phase 1 mirrors applyOptions: only add LIMIT/OFFSET when the value is positive. Also moved legacy backend integration tests from sql_search_fts_test.go to sql_search_like_test.go and added regression tests for the Max=0 behavior on both backends. * refactor: simplify callSearch function by removing variadic options and directly using QueryOptions Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): implement ftsQueryDegraded function to detect significant content loss in FTS queries Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
304 lines
7.3 KiB
Go
304 lines
7.3 KiB
Go
package tests
|
|
|
|
import (
|
|
"cmp"
|
|
"errors"
|
|
"maps"
|
|
"slices"
|
|
"time"
|
|
|
|
"github.com/deluan/rest"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/id"
|
|
"github.com/navidrome/navidrome/utils/slice"
|
|
)
|
|
|
|
func CreateMockMediaFileRepo() *MockMediaFileRepo {
|
|
return &MockMediaFileRepo{
|
|
Data: make(map[string]*model.MediaFile),
|
|
}
|
|
}
|
|
|
|
type MockMediaFileRepo struct {
|
|
model.MediaFileRepository
|
|
Data map[string]*model.MediaFile
|
|
Err bool
|
|
// Add fields and methods for controlling CountAll and DeleteAllMissing in tests
|
|
CountAllValue int64
|
|
CountAllOptions model.QueryOptions
|
|
DeleteAllMissingValue int64
|
|
Options model.QueryOptions
|
|
// Add fields for cross-library move detection tests
|
|
FindRecentFilesByMBZTrackIDFunc func(missing model.MediaFile, since time.Time) (model.MediaFiles, error)
|
|
FindRecentFilesByPropertiesFunc func(missing model.MediaFile, since time.Time) (model.MediaFiles, error)
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) SetError(err bool) {
|
|
m.Err = err
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) SetData(mfs model.MediaFiles) {
|
|
m.Data = make(map[string]*model.MediaFile)
|
|
for i, mf := range mfs {
|
|
m.Data[mf.ID] = &mfs[i]
|
|
}
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Exists(id string) (bool, error) {
|
|
if m.Err {
|
|
return false, errors.New("error")
|
|
}
|
|
_, found := m.Data[id]
|
|
return found, nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Get(id string) (*model.MediaFile, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
if d, ok := m.Data[id]; ok {
|
|
// Intentionally clone the file and remove participants. This should
|
|
// catch any caller that actually means to call GetWithParticipants
|
|
res := *d
|
|
res.Participants = model.Participants{}
|
|
return &res, nil
|
|
}
|
|
return nil, model.ErrNotFound
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) GetWithParticipants(id string) (*model.MediaFile, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
if d, ok := m.Data[id]; ok {
|
|
return d, nil
|
|
}
|
|
return nil, model.ErrNotFound
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) GetAllByTags(_ model.TagName, _ []string, options ...model.QueryOptions) (model.MediaFiles, error) {
|
|
return m.GetAll(options...)
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) GetAll(qo ...model.QueryOptions) (model.MediaFiles, error) {
|
|
if len(qo) > 0 {
|
|
m.Options = qo[0]
|
|
}
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
values := slices.Collect(maps.Values(m.Data))
|
|
result := slice.Map(values, func(p *model.MediaFile) model.MediaFile {
|
|
return *p
|
|
})
|
|
// Sort by ID to ensure deterministic ordering for tests
|
|
slices.SortFunc(result, func(a, b model.MediaFile) int {
|
|
return cmp.Compare(a.ID, b.ID)
|
|
})
|
|
return result, nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Put(mf *model.MediaFile) error {
|
|
if m.Err {
|
|
return errors.New("error")
|
|
}
|
|
if mf.ID == "" {
|
|
mf.ID = id.NewRandom()
|
|
}
|
|
m.Data[mf.ID] = mf
|
|
return nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Delete(id string) error {
|
|
if m.Err {
|
|
return errors.New("error")
|
|
}
|
|
if _, ok := m.Data[id]; !ok {
|
|
return model.ErrNotFound
|
|
}
|
|
delete(m.Data, id)
|
|
return nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) IncPlayCount(id string, timestamp time.Time) error {
|
|
if m.Err {
|
|
return errors.New("error")
|
|
}
|
|
if d, ok := m.Data[id]; ok {
|
|
d.PlayCount++
|
|
d.PlayDate = ×tamp
|
|
return nil
|
|
}
|
|
return model.ErrNotFound
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) FindByAlbum(artistId string) (model.MediaFiles, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
var res = make(model.MediaFiles, len(m.Data))
|
|
i := 0
|
|
for _, a := range m.Data {
|
|
if a.AlbumID == artistId {
|
|
res[i] = *a
|
|
i++
|
|
}
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) GetMissingAndMatching(libId int) (model.MediaFileCursor, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
var res model.MediaFiles
|
|
for _, a := range m.Data {
|
|
if a.LibraryID == libId && a.Missing {
|
|
res = append(res, *a)
|
|
}
|
|
}
|
|
|
|
for _, a := range m.Data {
|
|
if a.LibraryID == libId && !(*a).Missing && slices.IndexFunc(res, func(mediaFile model.MediaFile) bool {
|
|
return mediaFile.PID == a.PID
|
|
}) != -1 {
|
|
res = append(res, *a)
|
|
}
|
|
}
|
|
slices.SortFunc(res, func(i, j model.MediaFile) int {
|
|
return cmp.Or(
|
|
cmp.Compare(i.PID, j.PID),
|
|
cmp.Compare(i.ID, j.ID),
|
|
)
|
|
})
|
|
|
|
return func(yield func(model.MediaFile, error) bool) {
|
|
for _, a := range res {
|
|
if !yield(a, nil) {
|
|
break
|
|
}
|
|
}
|
|
}, nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) CountAll(opts ...model.QueryOptions) (int64, error) {
|
|
if m.Err {
|
|
return 0, errors.New("error")
|
|
}
|
|
if m.CountAllValue != 0 {
|
|
if len(opts) > 0 {
|
|
m.CountAllOptions = opts[0]
|
|
}
|
|
return m.CountAllValue, nil
|
|
}
|
|
return int64(len(m.Data)), nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) DeleteAllMissing() (int64, error) {
|
|
if m.Err {
|
|
return 0, errors.New("error")
|
|
}
|
|
if m.DeleteAllMissingValue != 0 {
|
|
return m.DeleteAllMissingValue, nil
|
|
}
|
|
// Remove all missing files from Data
|
|
var count int64
|
|
for id, mf := range m.Data {
|
|
if mf.Missing {
|
|
delete(m.Data, id)
|
|
count++
|
|
}
|
|
}
|
|
return count, nil
|
|
}
|
|
|
|
// ResourceRepository methods
|
|
func (m *MockMediaFileRepo) Count(...rest.QueryOptions) (int64, error) {
|
|
return m.CountAll()
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Read(id string) (any, error) {
|
|
mf, err := m.Get(id)
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return nil, rest.ErrNotFound
|
|
}
|
|
return mf, err
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) ReadAll(...rest.QueryOptions) (any, error) {
|
|
return m.GetAll()
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) EntityName() string {
|
|
return "mediafile"
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) NewInstance() any {
|
|
return &model.MediaFile{}
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) Search(q string, options ...model.QueryOptions) (model.MediaFiles, error) {
|
|
if len(options) > 0 {
|
|
m.Options = options[0]
|
|
}
|
|
if m.Err {
|
|
return nil, errors.New("unexpected error")
|
|
}
|
|
// Simple mock implementation - just return all media files for testing
|
|
allFiles, err := m.GetAll()
|
|
return allFiles, err
|
|
}
|
|
|
|
// Cross-library move detection mock methods
|
|
func (m *MockMediaFileRepo) FindRecentFilesByMBZTrackID(missing model.MediaFile, since time.Time) (model.MediaFiles, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
if m.FindRecentFilesByMBZTrackIDFunc != nil {
|
|
return m.FindRecentFilesByMBZTrackIDFunc(missing, since)
|
|
}
|
|
// Default implementation: find files with same MBZ Track ID in other libraries
|
|
var result model.MediaFiles
|
|
for _, mf := range m.Data {
|
|
if mf.LibraryID != missing.LibraryID &&
|
|
mf.MbzReleaseTrackID == missing.MbzReleaseTrackID &&
|
|
mf.MbzReleaseTrackID != "" &&
|
|
mf.Suffix == missing.Suffix &&
|
|
mf.CreatedAt.After(since) &&
|
|
!mf.Missing {
|
|
result = append(result, *mf)
|
|
}
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
func (m *MockMediaFileRepo) FindRecentFilesByProperties(missing model.MediaFile, since time.Time) (model.MediaFiles, error) {
|
|
if m.Err {
|
|
return nil, errors.New("error")
|
|
}
|
|
if m.FindRecentFilesByPropertiesFunc != nil {
|
|
return m.FindRecentFilesByPropertiesFunc(missing, since)
|
|
}
|
|
// Default implementation: find files with same properties in other libraries
|
|
var result model.MediaFiles
|
|
for _, mf := range m.Data {
|
|
if mf.LibraryID != missing.LibraryID &&
|
|
mf.Title == missing.Title &&
|
|
mf.Size == missing.Size &&
|
|
mf.Suffix == missing.Suffix &&
|
|
mf.DiscNumber == missing.DiscNumber &&
|
|
mf.TrackNumber == missing.TrackNumber &&
|
|
mf.Album == missing.Album &&
|
|
mf.MbzReleaseTrackID == "" && // Exclude files with MBZ Track ID
|
|
mf.CreatedAt.After(since) &&
|
|
!mf.Missing {
|
|
result = append(result, *mf)
|
|
}
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
var _ model.MediaFileRepository = (*MockMediaFileRepo)(nil)
|
|
var _ model.ResourceRepository = (*MockMediaFileRepo)(nil)
|