c193bb2a09
* fix: enable library access for headless processes Fixed multi-library filtering to allow headless processes (shares, external providers) to access data by skipping library restrictions when no user context is present. Previously, the library filtering system returned empty results (WHERE 1=0) for processes without user authentication, breaking functionality like public shares and external service integrations. Key changes: - Modified applyLibraryFilter methods to skip filtering when user.ID == invalidUserId - Refactored tag repository to use helper method for library filtering logic - Fixed SQL aggregation bug in tag statistics calculation across multiple libraries - Added comprehensive test coverage for headless process scenarios - Updated genre repository to support proper column mappings for aggregated data This preserves the secure "safe by default" approach for authenticated users while restoring backward compatibility for background processes that need unrestricted data access. Signed-off-by: Deluan <deluan@navidrome.org> * fix: resolve SQL ambiguity errors in share queries Fixed SQL ambiguity errors that were breaking share links after the Multi-library PR. The Multi-library changes introduced JOINs between album and library tables, both of which have 'id' columns, causing 'ambiguous column name: id' errors when unqualified column references were used in WHERE clauses. Changes made: - Updated core/share.go to use 'album.id' instead of 'id' in contentsLabelFromAlbums - Updated persistence/share_repository.go to use 'album.id' in album share loading - Updated persistence/sql_participations.go to use 'artist.id' for consistency - Added regression tests to prevent future SQL ambiguity issues This resolves HTTP 500 errors that users experienced when accessing existing share URLs after the Multi-library feature was merged. Signed-off-by: Deluan <deluan@navidrome.org> * fix: improve headless library access handling Added proper user context validation and reordered joins in applyLibraryFilterToArtistQuery to ensure library filtering works correctly for both authenticated and headless operations. The user_library join is now only applied when a valid user context exists, while the library_artist join is always applied to maintain proper data relationships. (+1 squashed commit) Squashed commits: [a28c6965b] fix: remove headless library access guard Removed the invalidUserId guard condition in applyLibraryFilterToArtistQuery that was preventing proper library filtering for headless operations. This fix ensures that library filtering joins are always applied consistently, allowing headless library access to work correctly with the library_artist junction table filtering. The previous guard was skipping all library filtering when no user context was present, which could cause issues with headless operations that still need to respect library boundaries through the library_artist relationship. * fix: simplify genre selection query in genre repository Signed-off-by: Deluan <deluan@navidrome.org> * fix: enhance tag library filtering tests for headless access Signed-off-by: Deluan <deluan@navidrome.org> * test: add comprehensive test coverage for headless library access Added extensive test coverage for headless library access improvements including: - Added 17 new tests across 4 test files covering headless access scenarios - artist_repository_test.go: Added headless process tests for GetAll, Count, Get operations and explicit library_id filtering functionality - genre_repository_test.go: Added library filtering tests for headless processes including GetAll, Count, ReadAll, and Read operations - sql_base_repository_test.go: Added applyLibraryFilter method tests covering admin users, regular users, and headless processes with/without custom table names - share_repository_test.go: Added headless access tests and SQL ambiguity verification for the album.id vs id fix in loadMedia function - Cleaned up test setup by replacing log.NewContext usage with GinkgoT().Context() and removing unnecessary configtest.SetupConfig() calls for better test isolation These tests ensure that headless processes (background operations without user context) can access all libraries while respecting explicit filters, and verify that the SQL ambiguity fixes work correctly without breaking existing functionality. * revert: remove user context handling from scrobble buffer getParticipants Reverts commit 5b8ef74f05109ecf30ddfc936361b84314522869. The artist repository no longer requires user context for proper library filtering, so the workaround of temporarily injecting user context into the scrobbleBufferRepository.Next method is no longer needed. This simplifies the code and removes the dependency on fetching user information during background scrobbling operations. * fix: improve library access filtering for artists Enhanced artist repository filtering to properly handle library access restrictions and prevent artists with no accessible content from appearing in results. Backend changes: - Modified roleFilter to use direct JSON_EXTRACT instead of EXISTS subquery for better performance - Enhanced applyLibraryFilterToArtistQuery to filter out artists with empty stats (no content) - Changed from LEFT JOIN to INNER JOIN with library_artist table for stricter filtering - Added condition to exclude artists where library_artist.stats = '{}' (empty content) Frontend changes: - Added null-checking in getCounter function to prevent TypeError when accessing undefined records - Improved optional chaining for safer property access in role-based statistics display These changes ensure that users only see artists that have actual accessible content in their permitted libraries, fixing issues where artists appeared in the list despite having no albums or songs available to the user. * fix: update library access logic for non-admin users and enhance test coverage Signed-off-by: Deluan <deluan@navidrome.org> * fix: refine library artist query and implement cleanup for empty entries Signed-off-by: Deluan <deluan@navidrome.org> * refactor: consolidate artist repository tests to eliminate duplication Significantly refactored artist_repository_test.go to reduce code duplication and improve maintainability by ~27% (930 to 680 lines). Key improvements include: - Added test helper functions createTestArtistWithMBID() and createUserWithLibraries() to eliminate repetitive test data creation - Consolidated duplicate MBID search tests using DescribeTable for parameterized testing - Removed entire 'Permission-Based Behavior Comparison' section (~150 lines) that duplicated functionality already covered in other test contexts - Reorganized search tests into cohesive 'MBID and Text Search' section with proper setup/teardown and shared test infrastructure - Streamlined missing artist tests and moved them to dedicated section - Maintained 100% test coverage while eliminating redundant test patterns All tests continue to pass with identical functionality and coverage. --------- Signed-off-by: Deluan <deluan@navidrome.org>
569 lines
20 KiB
Go
569 lines
20 KiB
Go
package persistence
|
|
|
|
import (
|
|
"cmp"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"slices"
|
|
"strings"
|
|
"time"
|
|
|
|
. "github.com/Masterminds/squirrel"
|
|
"github.com/deluan/rest"
|
|
"github.com/google/uuid"
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/utils"
|
|
. "github.com/navidrome/navidrome/utils/gg"
|
|
"github.com/navidrome/navidrome/utils/slice"
|
|
"github.com/pocketbase/dbx"
|
|
)
|
|
|
|
type artistRepository struct {
|
|
sqlRepository
|
|
indexGroups utils.IndexGroups
|
|
}
|
|
|
|
type dbArtist struct {
|
|
*model.Artist `structs:",flatten"`
|
|
SimilarArtists string `structs:"-" json:"-"`
|
|
LibraryStatsJSON string `structs:"-" json:"-"`
|
|
}
|
|
|
|
type dbSimilarArtist struct {
|
|
ID string `json:"id,omitempty"`
|
|
Name string `json:"name,omitempty"`
|
|
}
|
|
|
|
func (a *dbArtist) PostScan() error {
|
|
a.Artist.Stats = make(map[model.Role]model.ArtistStats)
|
|
|
|
if a.LibraryStatsJSON != "" {
|
|
var rawLibStats map[string]map[string]map[string]int64
|
|
if err := json.Unmarshal([]byte(a.LibraryStatsJSON), &rawLibStats); err != nil {
|
|
return fmt.Errorf("parsing artist stats from db: %w", err)
|
|
}
|
|
|
|
for _, stats := range rawLibStats {
|
|
// Sum all libraries roles stats
|
|
for key, stat := range stats {
|
|
// Aggregate stats into the main Artist.Stats map
|
|
artistStats := model.ArtistStats{
|
|
SongCount: int(stat["m"]),
|
|
AlbumCount: int(stat["a"]),
|
|
Size: stat["s"],
|
|
}
|
|
|
|
// Store total stats into the main attributes
|
|
if key == "total" {
|
|
a.Artist.Size += artistStats.Size
|
|
a.Artist.SongCount += artistStats.SongCount
|
|
a.Artist.AlbumCount += artistStats.AlbumCount
|
|
}
|
|
|
|
role := model.RoleFromString(key)
|
|
if role == model.RoleInvalid {
|
|
continue
|
|
}
|
|
|
|
current := a.Artist.Stats[role]
|
|
current.Size += artistStats.Size
|
|
current.SongCount += artistStats.SongCount
|
|
current.AlbumCount += artistStats.AlbumCount
|
|
a.Artist.Stats[role] = current
|
|
}
|
|
}
|
|
}
|
|
|
|
a.Artist.SimilarArtists = nil
|
|
if a.SimilarArtists == "" {
|
|
return nil
|
|
}
|
|
var sa []dbSimilarArtist
|
|
if err := json.Unmarshal([]byte(a.SimilarArtists), &sa); err != nil {
|
|
return fmt.Errorf("parsing similar artists from db: %w", err)
|
|
}
|
|
for _, s := range sa {
|
|
a.Artist.SimilarArtists = append(a.Artist.SimilarArtists, model.Artist{
|
|
ID: s.ID,
|
|
Name: s.Name,
|
|
})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (a *dbArtist) PostMapArgs(m map[string]any) error {
|
|
sa := make([]dbSimilarArtist, 0)
|
|
for _, s := range a.Artist.SimilarArtists {
|
|
sa = append(sa, dbSimilarArtist{ID: s.ID, Name: s.Name})
|
|
}
|
|
similarArtists, _ := json.Marshal(sa)
|
|
m["similar_artists"] = string(similarArtists)
|
|
m["full_text"] = formatFullText(a.Name, a.SortArtistName)
|
|
|
|
// Do not override the sort_artist_name and mbz_artist_id fields if they are empty
|
|
// TODO: Better way to handle this?
|
|
if v, ok := m["sort_artist_name"]; !ok || v.(string) == "" {
|
|
delete(m, "sort_artist_name")
|
|
}
|
|
if v, ok := m["mbz_artist_id"]; !ok || v.(string) == "" {
|
|
delete(m, "mbz_artist_id")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
type dbArtists []dbArtist
|
|
|
|
func (dba dbArtists) toModels() model.Artists {
|
|
res := make(model.Artists, len(dba))
|
|
for i := range dba {
|
|
res[i] = *dba[i].Artist
|
|
}
|
|
return res
|
|
}
|
|
|
|
func NewArtistRepository(ctx context.Context, db dbx.Builder) model.ArtistRepository {
|
|
r := &artistRepository{}
|
|
r.ctx = ctx
|
|
r.db = db
|
|
r.indexGroups = utils.ParseIndexGroups(conf.Server.IndexGroups)
|
|
r.tableName = "artist" // To be used by the idFilter below
|
|
r.registerModel(&model.Artist{}, map[string]filterFunc{
|
|
"id": idFilter(r.tableName),
|
|
"name": fullTextFilter(r.tableName, "mbz_artist_id"),
|
|
"starred": booleanFilter,
|
|
"role": roleFilter,
|
|
"missing": booleanFilter,
|
|
"library_id": artistLibraryIdFilter,
|
|
})
|
|
r.setSortMappings(map[string]string{
|
|
"name": "order_artist_name",
|
|
"starred_at": "starred, starred_at",
|
|
"song_count": "stats->>'total'->>'m'",
|
|
"album_count": "stats->>'total'->>'a'",
|
|
"size": "stats->>'total'->>'s'",
|
|
|
|
// Stats by credits that are currently available
|
|
"maincredit_song_count": "sum(stats->>'maincredit'->>'m')",
|
|
"maincredit_album_count": "sum(stats->>'maincredit'->>'a')",
|
|
"maincredit_size": "sum(stats->>'maincredit'->>'s')",
|
|
})
|
|
return r
|
|
}
|
|
|
|
func roleFilter(_ string, role any) Sqlizer {
|
|
if role, ok := role.(string); ok {
|
|
if _, ok := model.AllRoles[role]; ok {
|
|
return Expr("JSON_EXTRACT(library_artist.stats, '$." + role + ".m') IS NOT NULL")
|
|
}
|
|
}
|
|
return Eq{"1": 2}
|
|
}
|
|
|
|
// artistLibraryIdFilter filters artists based on library access through the library_artist table
|
|
func artistLibraryIdFilter(_ string, value interface{}) Sqlizer {
|
|
return Eq{"library_artist.library_id": value}
|
|
}
|
|
|
|
// applyLibraryFilterToArtistQuery applies library filtering to artist queries through the library_artist junction table
|
|
func (r *artistRepository) applyLibraryFilterToArtistQuery(query SelectBuilder) SelectBuilder {
|
|
user := loggedUser(r.ctx)
|
|
// Join with library_artist first to ensure only artists with content in libraries are included
|
|
// Exclude artists with empty stats (no actual content in the library)
|
|
query = query.Join("library_artist on library_artist.artist_id = artist.id")
|
|
//query = query.Join("library_artist on library_artist.artist_id = artist.id AND library_artist.stats != '{}'")
|
|
|
|
// Admin users see all artists from all libraries, no additional filtering needed
|
|
if user.ID != invalidUserId && !user.IsAdmin {
|
|
// Apply library filtering only for non-admin users by joining with their accessible libraries
|
|
query = query.Join("user_library on user_library.library_id = library_artist.library_id AND user_library.user_id = ?", user.ID)
|
|
}
|
|
|
|
return query
|
|
}
|
|
|
|
func (r *artistRepository) selectArtist(options ...model.QueryOptions) SelectBuilder {
|
|
// Stats Format: {"1": {"albumartist": {"songCount": 10, "albumCount": 5, "size": 1024}, "artist": {...}}, "2": {...}}
|
|
query := r.newSelect(options...).Columns("artist.*",
|
|
"JSON_GROUP_OBJECT(library_artist.library_id, JSONB(library_artist.stats)) as library_stats_json")
|
|
|
|
query = r.applyLibraryFilterToArtistQuery(query)
|
|
query = query.GroupBy("artist.id")
|
|
return r.withAnnotation(query, "artist.id")
|
|
}
|
|
|
|
func (r *artistRepository) CountAll(options ...model.QueryOptions) (int64, error) {
|
|
query := r.newSelect()
|
|
query = r.applyLibraryFilterToArtistQuery(query)
|
|
query = r.withAnnotation(query, "artist.id")
|
|
return r.count(query, options...)
|
|
}
|
|
|
|
// Exists checks if an artist with the given ID exists in the database and is accessible by the current user.
|
|
func (r *artistRepository) Exists(id string) (bool, error) {
|
|
// Create a query using the same library filtering logic as selectArtist()
|
|
query := r.newSelect().Columns("count(distinct artist.id) as exist").Where(Eq{"artist.id": id})
|
|
query = r.applyLibraryFilterToArtistQuery(query)
|
|
|
|
var res struct{ Exist int64 }
|
|
err := r.queryOne(query, &res)
|
|
return res.Exist > 0, err
|
|
}
|
|
|
|
func (r *artistRepository) Put(a *model.Artist, colsToUpdate ...string) error {
|
|
dba := &dbArtist{Artist: a}
|
|
dba.CreatedAt = P(time.Now())
|
|
dba.UpdatedAt = dba.CreatedAt
|
|
_, err := r.put(dba.ID, dba, colsToUpdate...)
|
|
return err
|
|
}
|
|
|
|
func (r *artistRepository) UpdateExternalInfo(a *model.Artist) error {
|
|
dba := &dbArtist{Artist: a}
|
|
_, err := r.put(a.ID, dba,
|
|
"biography", "small_image_url", "medium_image_url", "large_image_url",
|
|
"similar_artists", "external_url", "external_info_updated_at")
|
|
return err
|
|
}
|
|
|
|
func (r *artistRepository) Get(id string) (*model.Artist, error) {
|
|
sel := r.selectArtist().Where(Eq{"artist.id": id})
|
|
var dba dbArtists
|
|
if err := r.queryAll(sel, &dba); err != nil {
|
|
return nil, err
|
|
}
|
|
if len(dba) == 0 {
|
|
return nil, model.ErrNotFound
|
|
}
|
|
res := dba.toModels()
|
|
return &res[0], nil
|
|
}
|
|
|
|
func (r *artistRepository) GetAll(options ...model.QueryOptions) (model.Artists, error) {
|
|
sel := r.selectArtist(options...)
|
|
var dba dbArtists
|
|
err := r.queryAll(sel, &dba)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
res := dba.toModels()
|
|
return res, err
|
|
}
|
|
|
|
func (r *artistRepository) getIndexKey(a model.Artist) string {
|
|
source := a.OrderArtistName
|
|
if conf.Server.PreferSortTags {
|
|
source = cmp.Or(a.SortArtistName, a.OrderArtistName)
|
|
}
|
|
name := strings.ToLower(source)
|
|
for k, v := range r.indexGroups {
|
|
if strings.HasPrefix(name, strings.ToLower(k)) {
|
|
return v
|
|
}
|
|
}
|
|
return "#"
|
|
}
|
|
|
|
// GetIndex returns a list of artists grouped by the first letter of their name, or by the index group if configured.
|
|
// It can filter by roles and libraries, and optionally include artists that are missing (i.e., have no albums).
|
|
// TODO Cache the index (recalculate at scan time)
|
|
func (r *artistRepository) GetIndex(includeMissing bool, libraryIds []int, roles ...model.Role) (model.ArtistIndexes, error) {
|
|
// Validate library IDs. If no library IDs are provided, return an empty index.
|
|
if len(libraryIds) == 0 {
|
|
return nil, nil
|
|
}
|
|
|
|
options := model.QueryOptions{Sort: "name"}
|
|
if len(roles) > 0 {
|
|
roleFilters := slice.Map(roles, func(r model.Role) Sqlizer {
|
|
return roleFilter("role", r.String())
|
|
})
|
|
options.Filters = Or(roleFilters)
|
|
}
|
|
if !includeMissing {
|
|
if options.Filters == nil {
|
|
options.Filters = Eq{"artist.missing": false}
|
|
} else {
|
|
options.Filters = And{options.Filters, Eq{"artist.missing": false}}
|
|
}
|
|
}
|
|
|
|
libFilter := artistLibraryIdFilter("library_id", libraryIds)
|
|
if options.Filters == nil {
|
|
options.Filters = libFilter
|
|
} else {
|
|
options.Filters = And{options.Filters, libFilter}
|
|
}
|
|
|
|
artists, err := r.GetAll(options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var result model.ArtistIndexes
|
|
for k, v := range slice.Group(artists, r.getIndexKey) {
|
|
result = append(result, model.ArtistIndex{ID: k, Artists: v})
|
|
}
|
|
slices.SortFunc(result, func(a, b model.ArtistIndex) int {
|
|
return cmp.Compare(a.ID, b.ID)
|
|
})
|
|
return result, nil
|
|
}
|
|
|
|
func (r *artistRepository) purgeEmpty() error {
|
|
del := Delete(r.tableName).Where("id not in (select artist_id from album_artists)")
|
|
c, err := r.executeSQL(del)
|
|
if err != nil {
|
|
return fmt.Errorf("purging empty artists: %w", err)
|
|
}
|
|
if c > 0 {
|
|
log.Debug(r.ctx, "Purged empty artists", "totalDeleted", c)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// markMissing marks artists as missing if all their albums are missing.
|
|
func (r *artistRepository) markMissing() error {
|
|
q := Expr(`
|
|
with artists_with_non_missing_albums as (
|
|
select distinct aa.artist_id
|
|
from album_artists aa
|
|
join album a on aa.album_id = a.id
|
|
where a.missing = false
|
|
)
|
|
update artist
|
|
set missing = (artist.id not in (select artist_id from artists_with_non_missing_albums));
|
|
`)
|
|
_, err := r.executeSQL(q)
|
|
if err != nil {
|
|
return fmt.Errorf("marking missing artists: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// RefreshPlayCounts updates the play count and last play date annotations for all artists, based
|
|
// on the media files associated with them.
|
|
func (r *artistRepository) RefreshPlayCounts() (int64, error) {
|
|
query := Expr(`
|
|
with play_counts as (
|
|
select user_id, atom as artist_id, sum(play_count) as total_play_count, max(play_date) as last_play_date
|
|
from media_file
|
|
join annotation on item_id = media_file.id
|
|
left join json_tree(participants, '$.artist') as jt
|
|
where atom is not null and key = 'id'
|
|
group by user_id, atom
|
|
)
|
|
insert into annotation (user_id, item_id, item_type, play_count, play_date)
|
|
select user_id, artist_id, 'artist', total_play_count, last_play_date
|
|
from play_counts
|
|
where total_play_count > 0
|
|
on conflict (user_id, item_id, item_type) do update
|
|
set play_count = excluded.play_count,
|
|
play_date = excluded.play_date;
|
|
`)
|
|
return r.executeSQL(query)
|
|
}
|
|
|
|
// RefreshStats updates the stats field for artists whose associated media files were updated after the oldest recorded library scan time.
|
|
// When allArtists is true, it refreshes stats for all artists. It processes artists in batches to handle potentially large updates.
|
|
// This method now calculates per-library statistics and stores them in the library_artist junction table.
|
|
func (r *artistRepository) RefreshStats(allArtists bool) (int64, error) {
|
|
var allTouchedArtistIDs []string
|
|
if allArtists {
|
|
// Refresh stats for all artists
|
|
allArtistsQuerySQL := `SELECT DISTINCT id FROM artist WHERE id <> ''`
|
|
if err := r.db.NewQuery(allArtistsQuerySQL).Column(&allTouchedArtistIDs); err != nil {
|
|
return 0, fmt.Errorf("fetching all artist IDs: %w", err)
|
|
}
|
|
log.Debug(r.ctx, "RefreshStats: Refreshing all artists.", "count", len(allTouchedArtistIDs))
|
|
} else {
|
|
// Only refresh artists with updated timestamps
|
|
touchedArtistsQuerySQL := `
|
|
SELECT DISTINCT id
|
|
FROM artist
|
|
WHERE updated_at > (SELECT last_scan_at FROM library ORDER BY last_scan_at ASC LIMIT 1)
|
|
`
|
|
if err := r.db.NewQuery(touchedArtistsQuerySQL).Column(&allTouchedArtistIDs); err != nil {
|
|
return 0, fmt.Errorf("fetching touched artist IDs: %w", err)
|
|
}
|
|
log.Debug(r.ctx, "RefreshStats: Refreshing touched artists.", "count", len(allTouchedArtistIDs))
|
|
}
|
|
|
|
if len(allTouchedArtistIDs) == 0 {
|
|
log.Debug(r.ctx, "RefreshStats: No artists to update.")
|
|
return 0, nil
|
|
}
|
|
|
|
// Template for the batch update with placeholder markers that we'll replace
|
|
// This now calculates per-library statistics and stores them in library_artist.stats
|
|
batchUpdateStatsSQL := `
|
|
WITH artist_role_counters AS (
|
|
SELECT jt.atom AS artist_id,
|
|
mf.library_id,
|
|
substr(
|
|
replace(jt.path, '$.', ''),
|
|
1,
|
|
CASE WHEN instr(replace(jt.path, '$.', ''), '[') > 0
|
|
THEN instr(replace(jt.path, '$.', ''), '[') - 1
|
|
ELSE length(replace(jt.path, '$.', ''))
|
|
END
|
|
) AS role,
|
|
count(DISTINCT mf.album_id) AS album_count,
|
|
count(mf.id) AS count,
|
|
sum(mf.size) AS size
|
|
FROM media_file mf
|
|
JOIN json_tree(mf.participants) jt ON jt.key = 'id' AND jt.atom IS NOT NULL
|
|
WHERE jt.atom IN (ROLE_IDS_PLACEHOLDER) -- Will replace with actual placeholders
|
|
GROUP BY jt.atom, mf.library_id, role
|
|
),
|
|
artist_total_counters AS (
|
|
SELECT mfa.artist_id,
|
|
mf.library_id,
|
|
'total' AS role,
|
|
count(DISTINCT mf.album_id) AS album_count,
|
|
count(DISTINCT mf.id) AS count,
|
|
sum(mf.size) AS size
|
|
FROM media_file_artists mfa
|
|
JOIN media_file mf ON mfa.media_file_id = mf.id
|
|
WHERE mfa.artist_id IN (ROLE_IDS_PLACEHOLDER) -- Will replace with actual placeholders
|
|
GROUP BY mfa.artist_id, mf.library_id
|
|
),
|
|
artist_participant_counter AS (
|
|
SELECT mfa.artist_id,
|
|
mf.library_id,
|
|
'maincredit' AS role,
|
|
count(DISTINCT mf.album_id) AS album_count,
|
|
count(DISTINCT mf.id) AS count,
|
|
sum(mf.size) AS size
|
|
FROM media_file_artists mfa
|
|
JOIN media_file mf ON mfa.media_file_id = mf.id
|
|
WHERE mfa.artist_id IN (ROLE_IDS_PLACEHOLDER) -- Will replace with actual placeholders
|
|
AND mfa.role IN ('albumartist', 'artist')
|
|
GROUP BY mfa.artist_id, mf.library_id
|
|
),
|
|
combined_counters AS (
|
|
SELECT artist_id, library_id, role, album_count, count, size FROM artist_role_counters
|
|
UNION
|
|
SELECT artist_id, library_id, role, album_count, count, size FROM artist_total_counters
|
|
UNION
|
|
SELECT artist_id, library_id, role, album_count, count, size FROM artist_participant_counter
|
|
),
|
|
library_artist_counters AS (
|
|
SELECT artist_id,
|
|
library_id,
|
|
json_group_object(
|
|
replace(role, '"', ''),
|
|
json_object('a', album_count, 'm', count, 's', size)
|
|
) AS counters
|
|
FROM combined_counters
|
|
GROUP BY artist_id, library_id
|
|
)
|
|
UPDATE library_artist
|
|
SET stats = coalesce((SELECT counters FROM library_artist_counters lac
|
|
WHERE lac.artist_id = library_artist.artist_id
|
|
AND lac.library_id = library_artist.library_id), '{}')
|
|
WHERE library_artist.artist_id IN (ROLE_IDS_PLACEHOLDER);` // Will replace with actual placeholders
|
|
|
|
var totalRowsAffected int64 = 0
|
|
const batchSize = 1000
|
|
|
|
batchCounter := 0
|
|
for artistIDBatch := range slice.CollectChunks(slices.Values(allTouchedArtistIDs), batchSize) {
|
|
batchCounter++
|
|
log.Trace(r.ctx, "RefreshStats: Processing batch", "batchNum", batchCounter, "batchSize", len(artistIDBatch))
|
|
|
|
// Create placeholders for each ID in the IN clauses
|
|
placeholders := make([]string, len(artistIDBatch))
|
|
for i := range artistIDBatch {
|
|
placeholders[i] = "?"
|
|
}
|
|
// Don't add extra parentheses, the IN clause already expects them in SQL syntax
|
|
inClause := strings.Join(placeholders, ",")
|
|
|
|
// Replace the placeholder markers with actual SQL placeholders
|
|
batchSQL := strings.Replace(batchUpdateStatsSQL, "ROLE_IDS_PLACEHOLDER", inClause, 4)
|
|
|
|
// Create a single parameter array with all IDs (repeated 4 times for each IN clause)
|
|
// We need to repeat each ID 4 times (once for each IN clause)
|
|
args := make([]any, 4*len(artistIDBatch))
|
|
for idx, id := range artistIDBatch {
|
|
for i := range 4 {
|
|
startIdx := i * len(artistIDBatch)
|
|
args[startIdx+idx] = id
|
|
}
|
|
}
|
|
|
|
// Now use Expr with the expanded SQL and all parameters
|
|
sqlizer := Expr(batchSQL, args...)
|
|
|
|
rowsAffected, err := r.executeSQL(sqlizer)
|
|
if err != nil {
|
|
return totalRowsAffected, fmt.Errorf("executing batch update for artist stats (batch %d): %w", batchCounter, err)
|
|
}
|
|
totalRowsAffected += rowsAffected
|
|
}
|
|
|
|
// // Remove library_artist entries for artists that no longer have any content in any library
|
|
cleanupSQL := Delete("library_artist").Where("stats = '{}'")
|
|
cleanupRows, err := r.executeSQL(cleanupSQL)
|
|
if err != nil {
|
|
log.Warn(r.ctx, "Failed to cleanup empty library_artist entries", "error", err)
|
|
} else if cleanupRows > 0 {
|
|
log.Debug(r.ctx, "Cleaned up empty library_artist entries", "rowsDeleted", cleanupRows)
|
|
}
|
|
|
|
log.Debug(r.ctx, "RefreshStats: Successfully updated stats.", "totalArtistsProcessed", len(allTouchedArtistIDs), "totalDBRowsAffected", totalRowsAffected)
|
|
return totalRowsAffected, nil
|
|
}
|
|
|
|
func (r *artistRepository) Search(q string, offset int, size int, includeMissing bool, options ...model.QueryOptions) (model.Artists, error) {
|
|
var res dbArtists
|
|
if uuid.Validate(q) == nil {
|
|
err := r.searchByMBID(r.selectArtist(options...), q, []string{"mbz_artist_id"}, includeMissing, &res)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("searching artist by MBID %q: %w", q, err)
|
|
}
|
|
} else {
|
|
err := r.doSearch(r.selectArtist(options...), q, offset, size, includeMissing, &res,
|
|
"sum(json_extract(stats, '$.total.m')) desc", "name")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("searching artist by query %q: %w", q, err)
|
|
}
|
|
}
|
|
return res.toModels(), nil
|
|
}
|
|
|
|
func (r *artistRepository) Count(options ...rest.QueryOptions) (int64, error) {
|
|
return r.CountAll(r.parseRestOptions(r.ctx, options...))
|
|
}
|
|
|
|
func (r *artistRepository) Read(id string) (interface{}, error) {
|
|
return r.Get(id)
|
|
}
|
|
|
|
func (r *artistRepository) ReadAll(options ...rest.QueryOptions) (interface{}, error) {
|
|
role := "total"
|
|
if len(options) > 0 {
|
|
if v, ok := options[0].Filters["role"].(string); ok {
|
|
role = v
|
|
}
|
|
}
|
|
r.sortMappings["song_count"] = "sum(stats->>'" + role + "'->>'m')"
|
|
r.sortMappings["album_count"] = "sum(stats->>'" + role + "'->>'a')"
|
|
r.sortMappings["size"] = "sum(stats->>'" + role + "'->>'s')"
|
|
return r.GetAll(r.parseRestOptions(r.ctx, options...))
|
|
}
|
|
|
|
func (r *artistRepository) EntityName() string {
|
|
return "artist"
|
|
}
|
|
|
|
func (r *artistRepository) NewInstance() interface{} {
|
|
return &model.Artist{}
|
|
}
|
|
|
|
var _ model.ArtistRepository = (*artistRepository)(nil)
|
|
var _ model.ResourceRepository = (*artistRepository)(nil)
|