Deluan Quintão
5cd1fcb492
* feat(scheduler): add CrontabSchedule with crontab(5) random ~ syntax Implement ParseCrontab() that extends robfig/cron with support for the crontab(5) random ~ operator (e.g., 0~30 * * * *). Random values are resolved fresh on each Next() call for load spreading. Supports A~B, ~B, A~, and bare ~ forms in all 6 fields (including seconds). Expressions without ~ delegate to robfig's standard parser with zero overhead. Integrates into scheduler.Add() and conf.validateSchedule() so that scanner.schedule and backup.schedule config values accept ~ syntax. * refactor(scheduler): resolve random ~ values once at parse time Change from per-Next() randomization to per-parse randomization, matching crontab(5) semantics. This prevents double-firing within the same period when random values land after the current time. ParseCrontab now resolves ~ fields to concrete values, substitutes them into the spec string, and delegates to robfig's parser. This eliminates CrontabSchedule, randomField, and resolveField entirely. * test(scheduler): replace WaitGroup with channel for job execution synchronization Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
79 lines
1.5 KiB
Go
79 lines
1.5 KiB
Go
package scheduler
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/log"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/robfig/cron/v3"
|
|
)
|
|
|
|
func TestScheduler(t *testing.T) {
|
|
log.SetLevel(log.LevelFatal)
|
|
RegisterFailHandler(Fail)
|
|
RunSpecs(t, "Scheduler Suite")
|
|
}
|
|
|
|
var _ = Describe("Scheduler", func() {
|
|
var s *scheduler
|
|
|
|
BeforeEach(func() {
|
|
c := cron.New(cron.WithLogger(&logger{}))
|
|
s = &scheduler{c: c}
|
|
s.c.Start() // Start the scheduler for tests
|
|
})
|
|
|
|
AfterEach(func() {
|
|
s.c.Stop() // Stop the scheduler after tests
|
|
})
|
|
|
|
It("adds and executes a job", func() {
|
|
done := make(chan struct{})
|
|
|
|
id, err := s.Add("@every 50ms", func() {
|
|
close(done)
|
|
})
|
|
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(id).ToNot(BeZero())
|
|
|
|
Eventually(done).Should(BeClosed())
|
|
})
|
|
|
|
It("adds a job with random ~ syntax", func() {
|
|
id, err := s.Add("0~59 * * * *", func() {})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(id).ToNot(BeZero())
|
|
s.Remove(id)
|
|
})
|
|
|
|
It("removes a job", func() {
|
|
done := make(chan struct{})
|
|
|
|
counter := 0
|
|
id, err := s.Add("@every 50ms", func() {
|
|
counter++
|
|
if counter == 1 {
|
|
close(done)
|
|
}
|
|
})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(id).ToNot(BeZero())
|
|
|
|
// Verify job executed
|
|
Eventually(done).Should(BeClosed())
|
|
Expect(counter).To(Equal(1))
|
|
|
|
// Remove the job
|
|
s.Remove(id)
|
|
|
|
// Wait some time to ensure job doesn't execute again
|
|
time.Sleep(200 * time.Millisecond)
|
|
|
|
// Verify counter didn't increase
|
|
Expect(counter).To(Equal(1))
|
|
})
|
|
})
|