f03ca44a8e
* feat(plugins): add lyrics provider plugin capability Refactor the lyrics system from a static function to an interface-based service that supports WASM plugin providers. Plugins listed in the LyricsPriority config (alongside "embedded" and file extensions) are now resolved through the plugin system. Includes capability definition, Go/Rust PDK, adapter, Wire integration, and tests for plugin fallback behavior. * test(plugins): add lyrics capability integration test with test plugin * fix(plugins): default lyrics language to 'xxx' when plugin omits it Per the OpenSubsonic spec, the server must return 'und' or 'xxx' when the lyrics language is unknown. The lyrics plugin adapter was passing an empty string through when a plugin didn't provide a language value. This defaults the language to 'xxx', consistent with all other callers of model.ToLyrics() in the codebase. * refactor(plugins): rename lyrics import to improve clarity Signed-off-by: Deluan <deluan@navidrome.org> * refactor(lyrics): update TrackInfo description for clarity Signed-off-by: Deluan <deluan@navidrome.org> * fix(lyrics): enhance lyrics plugin handling and case sensitivity Signed-off-by: Deluan <deluan@navidrome.org> * fix(plugins): update payload type to string with byte format for task data Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
146 lines
4.1 KiB
Go
146 lines
4.1 KiB
Go
package subsonic
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/core/scrobbler"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/request"
|
|
"github.com/navidrome/navidrome/server/events"
|
|
"github.com/navidrome/navidrome/tests"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("MediaAnnotationController", func() {
|
|
var router *Router
|
|
var ds model.DataStore
|
|
var playTracker *fakePlayTracker
|
|
var eventBroker *fakeEventBroker
|
|
var ctx context.Context
|
|
|
|
BeforeEach(func() {
|
|
ctx = context.Background()
|
|
ds = &tests.MockDataStore{}
|
|
playTracker = &fakePlayTracker{}
|
|
eventBroker = &fakeEventBroker{}
|
|
router = New(ds, nil, nil, nil, nil, nil, nil, eventBroker, nil, playTracker, nil, nil, nil, nil)
|
|
})
|
|
|
|
Describe("Scrobble", func() {
|
|
It("submit all scrobbles with only the id", func() {
|
|
submissionTime := time.Now()
|
|
r := newGetRequest("id=12", "id=34")
|
|
|
|
_, err := router.Scrobble(r)
|
|
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(playTracker.Submissions).To(HaveLen(2))
|
|
Expect(playTracker.Submissions[0].Timestamp).To(BeTemporally(">", submissionTime))
|
|
Expect(playTracker.Submissions[0].TrackID).To(Equal("12"))
|
|
Expect(playTracker.Submissions[1].Timestamp).To(BeTemporally(">", submissionTime))
|
|
Expect(playTracker.Submissions[1].TrackID).To(Equal("34"))
|
|
})
|
|
|
|
It("submit all scrobbles with respective times", func() {
|
|
time1 := time.Now().Add(-20 * time.Minute)
|
|
t1 := time1.UnixMilli()
|
|
time2 := time.Now().Add(-10 * time.Minute)
|
|
t2 := time2.UnixMilli()
|
|
r := newGetRequest("id=12", "id=34", fmt.Sprintf("time=%d", t1), fmt.Sprintf("time=%d", t2))
|
|
|
|
_, err := router.Scrobble(r)
|
|
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(playTracker.Submissions).To(HaveLen(2))
|
|
Expect(playTracker.Submissions[0].Timestamp).To(BeTemporally("~", time1))
|
|
Expect(playTracker.Submissions[0].TrackID).To(Equal("12"))
|
|
Expect(playTracker.Submissions[1].Timestamp).To(BeTemporally("~", time2))
|
|
Expect(playTracker.Submissions[1].TrackID).To(Equal("34"))
|
|
})
|
|
|
|
It("checks if number of ids match number of times", func() {
|
|
r := newGetRequest("id=12", "id=34", "time=1111")
|
|
|
|
_, err := router.Scrobble(r)
|
|
|
|
Expect(err).To(HaveOccurred())
|
|
Expect(playTracker.Submissions).To(BeEmpty())
|
|
})
|
|
|
|
Context("submission=false", func() {
|
|
var req *http.Request
|
|
BeforeEach(func() {
|
|
_ = ds.MediaFile(ctx).Put(&model.MediaFile{ID: "12"})
|
|
ctx = request.WithPlayer(ctx, model.Player{ID: "player-1"})
|
|
req = newGetRequest("id=12", "submission=false")
|
|
req = req.WithContext(ctx)
|
|
})
|
|
|
|
It("does not scrobble", func() {
|
|
_, err := router.Scrobble(req)
|
|
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(playTracker.Submissions).To(BeEmpty())
|
|
})
|
|
|
|
It("registers a NowPlaying", func() {
|
|
_, err := router.Scrobble(req)
|
|
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(playTracker.Playing).To(HaveLen(1))
|
|
Expect(playTracker.Playing).To(HaveKey("player-1"))
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
type fakePlayTracker struct {
|
|
Submissions []scrobbler.Submission
|
|
Playing map[string]string
|
|
Error error
|
|
}
|
|
|
|
func (f *fakePlayTracker) NowPlaying(_ context.Context, playerId string, _ string, trackId string, position int) error {
|
|
if f.Error != nil {
|
|
return f.Error
|
|
}
|
|
if f.Playing == nil {
|
|
f.Playing = make(map[string]string)
|
|
}
|
|
f.Playing[playerId] = trackId
|
|
return nil
|
|
}
|
|
|
|
func (f *fakePlayTracker) GetNowPlaying(_ context.Context) ([]scrobbler.NowPlayingInfo, error) {
|
|
return nil, f.Error
|
|
}
|
|
|
|
func (f *fakePlayTracker) Submit(_ context.Context, submissions []scrobbler.Submission) error {
|
|
if f.Error != nil {
|
|
return f.Error
|
|
}
|
|
f.Submissions = append(f.Submissions, submissions...)
|
|
return nil
|
|
}
|
|
|
|
var _ scrobbler.PlayTracker = (*fakePlayTracker)(nil)
|
|
|
|
type fakeEventBroker struct {
|
|
http.Handler
|
|
Events []events.Event
|
|
}
|
|
|
|
func (f *fakeEventBroker) SendMessage(_ context.Context, event events.Event) {
|
|
f.Events = append(f.Events, event)
|
|
}
|
|
|
|
func (f *fakeEventBroker) SendBroadcastMessage(_ context.Context, event events.Event) {
|
|
f.Events = append(f.Events, event)
|
|
}
|
|
|
|
var _ events.Broker = (*fakeEventBroker)(nil)
|